Delete unused PCMQueueInAudioInputStream [chromium/src : main]
0 views
Skip to first unread message
Thomas Guilbert (Gerrit)
Feb 23, 2026, 8:13:43 PM (20 hours ago) Feb 23
to Thomas Guilbert, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org
Attention needed from Dale Curtis
Thomas Guilbert voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Guilbert
| Auto-Submit | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Thomas Guilbert . resolved
PTAL! LMK if there are any gotchas that I'm missing.
Related details
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
12:38 PM (4 hours ago) 12:38 PM
to Thomas Guilbert, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org
Attention needed from Thomas Guilbert
Dale Curtis voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dale Curtis
| Code-Review | +1 |
1 comment
File media/audio/ios/audio_manager_ios.cc
Line 105, Patchset 4 (Latest):
DUMP_WILL_BE_NOTREACHED();Dale Curtis . unresolved
This can still be reached via a compromised renderer at the moment, so we don't want it to be a CHECK() until that's fixed.
Related details
Attention is currently required from:
- Thomas Guilbert
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
2:45 PM (2 hours ago) 2:45 PM
to Thomas Guilbert, Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org
Thomas Guilbert voted and added 1 comment![]( "Open in Gerrit")
Votes added by Thomas Guilbert
| Commit-Queue | +2 |
1 comment
File media/audio/ios/audio_manager_ios.cc
Line 105, Patchset 4 (Latest):
DUMP_WILL_BE_NOTREACHED();Dale Curtis . resolved
This can still be reached via a compromised renderer at the moment, so we don't want it to be a CHECK() until that's fixed.
Thomas Guilbert
Ack. `DUMP_WILL_BE_NOTREACHED()` will be just do a non-crashing dump for now. It also indicates that one day, this will be replaced by a `NOTREACHED()` (or just deleted in our case).
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:48 PM (2 hours ago) 2:48 PM
to Thomas Guilbert, Dale Curtis, chromium...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Delete unused PCMQueueInAudioInputStream
Comments in `media/audio/apple/audio_input.cc` mention that Pepper is
the only place where we create AUDIO_PCM_LINEAR input devices.
Looking at UMAs, it seems that
"Media.Audio.InputStartupSuccessMac_HighLatency" has not received any
entries recently.
This CL deletes the unused class and files.
Fixed: 485960324
Change-Id: Ib5820fd0f57fea5cb89abfa780769418c9d1e28d
Auto-Submit: Thomas Guilbert <tgui...@chromium.org>
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Commit-Queue: Thomas Guilbert <tgui...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1589600}
Files:
- M media/audio/BUILD.gn
- D media/audio/apple/audio_input.cc
- D media/audio/apple/audio_input.h
- M media/audio/ios/audio_manager_ios.cc
- M media/audio/mac/audio_manager_mac.cc
Change size: L
Delta: 5 files changed, 6 insertions(+), 485 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages