clang-format in depot_tools

[Luigi Semenzato]

As mentioned in b/279222930, the minigbm presubmit tries to run clang-format and, when run outside the cros_sdk, it finds the one in depot_tools, which complains that it can't find a valid binary, even though I have one in /usr/bin/clang-format.  It's probably not the same clang-format as inside the sdk, but maybe it's good enough?  Cheers!

[Gurchetan Singh]

On Sat, Sep 2, 2023 at 11:10 AM Luigi Semenzato <seme...@google.com> wrote:

As mentioned in b/279222930, the minigbm presubmit tries to run clang-format and, when run outside the cros_sdk, it finds the one in depot_tools, which complains that it can't find a valid binary, even though I have one in /usr/bin/clang-format.  It's probably not the same clang-format as inside the sdk, but maybe it's good enough?  Cheers!

This happens many times when depot_tools is available, but the user is not inside the chroot.

You need to download chromium build tools:

https://chromium.googlesource.com/chromium/src/buildtools/

And download the clang-format with the correct sha1:

https://chromium.googlesource.com/chromium/src/buildtools/+/refs/heads/main/linux64/

https://chromium.googlesource.com/chromium/src/buildtools/+/refs/heads/main/clang_format/README.txt

Then you need to set CHROMIUM_BUILDTOOLS_PATH=~/buildtools

Then it will work.

 

[Luigi Semenzato]

Thank you for the information!