RE: Clang Tidy in Chromium

[Hoch Hochkeppel (HE/HIM)]

Hello,

 

I was exploring proactively applying some of clang-tidy’s recommendations to more of the codebase, and wanted to check on the expected behavior.

 

Clang_tidy.md indicates

• Clang-tidy automatically runs on any CL that Chromium committers upload to Gerrit, and will leave code review comments there.

 

but I have been unable to trigger comments about existing or newly regressed rules. If I manually queue a linux-clang-tidy-rel tryjob, it completes without warning or comments, but if I inspect the generated clang_tidy_complaints.yaml or findings.json I see the various warnings I would have expected to be surfaced.

 

Is this because my account does not have Committer status? Or possibly another step I’m missing?

 

Thanks for any clarifications/help you can give,

-Hoch

 

 

Example CL I’ve been using for testing: Turn on clang-tidy checks for resolver dir (6936189) · Gerrit Code Review

Latest findings.json

 

[Hoch Hochkeppel (HE/HIM)]

+gbiv and dcheng who I forgot to CC to start with.

[George Burgess]

Hey,

Thanks for your interest in clang-tidy! I'm unfamiliar with the linting system that clang-tidy has been migrated to, but it seems like it could be an ACL issue of some kind.

On patch-set 7 of your change, I see 4 lints from clang-tidy. I pressed 'please fix' on two of them to convert them to Gerrit comments, in case that helps.

Thanks,

George

--

Folks have varying work hours; if I caught you outside of yours, please don't feel pressured to respond immediately.

[Hoch Hochkeppel (HE/HIM)]

Thanks George,

 

It’s good to know it is still being moderately surfaced to at least some users. I’ll see if I can find the right people to talk to about why this isn’t more readily visible.

 

From: George Burgess <gb...@google.com>
Sent: Monday, September 22, 2025 6:17 AM
To: Hoch Hochkeppel (HE/HIM) <mho...@microsoft.com>
Cc: infra-de...@chromium.org; dch...@chromium.org
Subject: [EXTERNAL] Re: Clang Tidy in Chromium

 

You don't often get email from gb...@google.com. Learn why this is important