gclient gitmodules erases third_party/devtools-frontend/src

832 views
Skip to first unread message

Khushal Sagar

unread,
Oct 9, 2023, 9:01:01 PM10/9/23
to Chromium-dev, infr...@chromium.org, Josip Sokcevic
Hey folks,

I seem to have messed up my chromium checkout in a peculiar way. The `third_party/devtools-frontend/src` directory is empty. Running `gclient sync` or `gclient gitmodules` doesn't fix that.

I've pasted my .gclient config below. Any help would be appreciated!

```
solutions = [
  {
    "name": "src",
    "url": "https://chromium.googlesource.com/chromium/src.git",
    "managed": False,
    "custom_deps": {
      "src/third_party/devtools-frontend/src": None,
    },
    "custom_vars": {},
  },
  {
    # devtools-frontend project
    "name": "devtools-frontend",
    "url": "https://chromium.googlesource.com/devtools/devtools-frontend",
    "custom_deps": {}
  }
]

hooks = [
  {
    # Ensure devtools is symlinked in the correct location on every gclient sync
    'name': 'Symlink Depot Tools',
    'pattern': '.',
    'action': [
        'python',
        'src/third_party/devtools-frontend/src/scripts/deps/ensure_symlink.py',
        'src',
        'src/third_party/devtools-frontend/src/'
    ],
  }
]

target_os = [ 'android' ]
```

Josip Sokcevic

unread,
Oct 10, 2023, 1:20:17 PM10/10/23
to Khushal Sagar, Chromium-dev, infr...@chromium.org, Joanna Wang
Sorry to hear that. Do you happen to know how third_party/devtools-frontend/src got deleted? If it is one of depot_tools scripts, or a command from the official documentation, please file a bug with more details so it can be fixed.

Regarding your current state, you have the following entry in .gclient custom_deps:

      "src/third_party/devtools-frontend/src": None,

This tells gclient to ignore it, even if it's not cloned. I suggest you temporarily remove that line in .gclient file, run gclient sync, and then restore that line.

--
Josip Sokcevic
Reply all
Reply to author
Forward
0 new messages