Query about Intentional Lack of cache_dir Support in "fetch" Command

[ohlab kr]

When executing the fetch command to specify the cache_dir for fetching, as shown below, the cache_dir setting did not appear in the .gclient file:

$ fetch android --cache_dir=/workspace/mycache

Adding the following code to the depot_tools/fetch_configs/chromium.py file makes it work:

if props.get('cache_dir'): 

    spec['cache_dir'] = props['cache_dir']

Is the lack of support for cache_dir in the fetch command intentional?

[Josip Sokcevic]

I don't believe it's intentional, and it's reasonable to set it. Please create a CL and feel free to set me as a reviewer.

Best,

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/c9a02432-b1a1-4b8c-bf1e-609c9dcd1b5an%40chromium.org.

--

Josip Sokcevic

[ohlab kr]

I am a beginner and not familiar with the process of creating and reviewing CLs. I will try to challenge myself next time, but for now, it might be better for someone else to handle this.

I have made the following modifications and am currently using it. The caching behavior during fetch seems to be working correctly.

depot_tools/fetch_configs/chromium.py (line number 36)

if props.get('cache_dir'):
    spec['cache_dir'] = props['cache_dir']

Thank you for your understanding and assistance.

2024년 1월 23일 화요일 오전 8시 55분 42초 UTC+9에 sokc...@google.com님이 작성: