Why does CQ run all the bots on revert with "No-Try: true"?

7 views
Skip to first unread message

Cammie Smith Barnes

unread,
Sep 14, 2022, 11:15:53 AM9/14/22
to infr...@chromium.org
Hello,

I am trying to land the revert https://chromium-review.googlesource.com/c/chromium/src/+/3895773 to reopen the tree. It has the following in the commit description:

No-Presubmit: true No-Tree-Checks: true No-Try: true

But for some reason the CQ is running all of the normal CQ trybots anyway.  What did I do wrong?  And how can I get this to land faster?  

Quinten Yearsley

unread,
Sep 14, 2022, 5:31:38 PM9/14/22
to Cammie Smith Barnes, infra-dev
I believe the discussion in the CL comment and crbug/1363673 was correct: the flags were not in the right place; they must be in the "last paragraph" (where paragraphs are separated by blank lines) otherwise they aren't considered git footer flags.

They had been auto-generated above BUG=, and BUG= itself was not in the last paragraph (although it often or usually is). Maybe Ideally Findit should have generated the flags in the last paragraph regardless of the BUG= line.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAJ8xcq5iRrOJxq%2BKhCa0GNxHFPtT%3DCyFE_aws3k4bUW0ubzibg%40mail.gmail.com.
Reply all
Reply to author
Forward
0 new messages