Re: "git cl split" to migrate off deprecated method

[Chris Fredrickson]

Having not heard any response, I'm going to go ahead with this.

On Fri, Jul 26, 2024 at 12:46 PM Chris Fredrickson <cfre...@google.com> wrote:

Hi all,

I've put together a CL to take care of (most of) https://crbug.com/355451174, and was planning to split it via `git cl split`. I got a warning that it was generating a large number of CLs and should email here first, to check if it's ok. So the options are:

• Don't split at all: 1 CL, 125 changed files, 975 insertions, 1215 deletions
• Split w/ max-depth=1: 10 CLs
• Split w/ max-depth=2: 31 CLs
• Split w/ max-depth=3: 60 CLs
• Split w/o max-depth: 68 CLs

I don't want to overload the build infrastructure, but also don't want to overload a single (or small number) of reviewers. What do you suggest?

Thanks,

Chris

[Chris Fredrickson]

[Ben Pastene]

Where did you send your first post to? Your "Having not heard any response" follow-up only came 1-min before your initial post earlier today:

https://groups.google.com/a/chromium.org/g/infra-dev/c/EKIc0TaWcNY

So it's unsurprising that you hadn't heard from anyone in that -1min window.

With the recent-ish work on implementing CQ attempt rate-limiting, I suspect you could go the "68 CLs" route. The CQ will just deny any attempt if there are already a few in-flight. 

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAC79nvd2jd17AGCN5rgABuwCjf3t5NGOcRWz%3DFMQ8yShzWY9%3DA%40mail.gmail.com.

[Chris Fredrickson]

I sent both emails to infr...@chromium.org. First email was on 7/26, second email was this morning. I'm surprised that my original mail wasn't shown until today, maybe it got stuck in spam moderation?

Thanks, I did find out about the rate limiting, and adjusted the warning in `git cl split` to be less scary.