lucicfg generate deletes most of my config values?

[W. James MacLean]

HI all,

I'm trying to create a config for a new CI bot, and I would like to base the new config on an existing bot (linux-bfcache-rel). This bot runs a limited subset of tests.

Similar to linux-bfcache-rel, my new bot is intended to run a subset of tests (browser_tests, unit_tests, content_browsertests, content_unittests, blink_web_tests, blink_wpt_tests) with a particular feature flag enabled. Since, when launched, the new feature will only be default on part of the population, we're hoping this bot can provide coverage for the feature being on, and the main waterfall can test for when the feature is off (or vice-versa).

But ... while trying to upload my new config, presubmit told me I had to run lucicfg generate "main.star", but doing this deletes all my config file's contents in targets/chromium.linux.json, and replaces it with

"additional_compile_targets": [ "all" ]

This seems wrong, in particular because this file is where I specify the feature to enable and test with, which is the whole point of the new bot.

Any thoughts on what I'm doing wrong?

⭘ W. James MacLean ⭘ Software Engineer ⭘ Google Waterloo, Canada

[Ben Pastene]

To tie up this thread, this was cross-posted internally at http://shortn/_OEt8EpB86w, which got some response. TLDR is: don't hand-modify anything in //infra/config/generated/. Instead, change //infra/config/targets/ and //infra/config/subprojects/, and run //infra/config/main.star.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CADAYvofH-OZpzOkZJh6gL%2B43w43E6f3UBSxDjH_zO3w-6kvaeQ%40mail.gmail.com.