Gerrit forgot that blundell@chromium.org is a Chromium committer?

[Colin Blundell]

Hi folks,

Would anyone be able to give insight into what happened here (relevant message copied below)?

Thanks,

Colin

Uploaded patch set 4.

rebase

Outdated Votes:

• Code-Review+1 by Vasiliy Telezhnikov (copy condition*: "changekind:NO_CHANGE OR changekind:NO_CODE_CHANGE OR changekind:TRIVIAL_REBASE OR (has:unchanged-files AND uploaderin:cria/project-chromium-committers) OR is:MIN")

* The label has labelCopyEnforcement or labelCopyRestriction configured. Only the most relevant condition that determined the outcome is shown.

[Takuto Ikuta (生田 拓人)]

I think bold statement is evaluated to be true, but the diff has gpu/command_buffer/service/shared_image/gpu_memory_buffer_factory_dxgi.{cc,h} as additional files. So it didn't satisfy `has:unchanged-files` part.

--
You received this message because you are subscribed to the Google Groups "infra-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to infra-dev+...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/infra-dev/CAMGE5NFbwziAwZ-%3DnNr3Uc-i9H4%2B1s0r%2BpHSJA19YKm4sijGgA%40mail.gmail.com.

--

Takuto Ikuta

Software Engineer in Tokyo

Chrome Ops (chrome browser build team)

[Colin Blundell]

On Wed, Sep 24, 2025 at 10:20 AM Takuto Ikuta (生田 拓人) <tik...@google.com> wrote:

I think bold statement is evaluated to be true, but the diff has gpu/command_buffer/service/shared_image/gpu_memory_buffer_factory_dxgi.{cc,h} as additional files. So it didn't satisfy `has:unchanged-files` part.

Ah, that makes more sense, thanks! It's the fact that the CL was rebased across a move of the files.