RFC: Move //services/identity/public/cpp to //components/signin/public/browser for this first milestone?

[Colin Blundell]

Hi all,

As the milestones doc notes, in the current milestone we're building a new public C++ API for the signin codebase: essentially building out the API surface of the client library, but backed directly by the signin C++ code.

This new public C++ API currently lives in //services/identity/public/cpp. However, I'm now thinking that it would provide clarity to this stage of the project for it to instead live in //components/signin/public/browser: that way, it's clear what it is and what it isn't (yet). It's also clear that if you want to connect to the Identity Service today, you should do so via //services/identity/public/mojom.

When the C++ public API becomes a true client library of the Identity Service, it would then move (back) to //services/identity/public/cpp. It's somewhat unclear how we should structure the code in the stage where we're building out the client library but the browser is still using the browser-backed implementation. My inclination there would be to have the public C++ API then live as C++ interfaces in //components/signin/public/common, with the browser-backed impl and the client library impl. Once the browser is switched to the client library and the browser-backed impl is nuked, that's when the whole kit-and-caboodle would move to //services/identity/public/cpp.

Does anyone have strong feelings about this proposal one way or the other?

Thanks,

Colin

[Mihai Sardarescu]

Hi Colin,

I strongly prefer keeping the code in its final location, otherwise we lose the git log on these files (or it is way harder to go back in time).

- Mihai

--
You received this message because you are subscribed to the Google Groups "identity-service-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to identity-service...@chromium.org.
To post to this group, send email to identity-s...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/identity-service-dev/CAMGE5NF6zLDQ9N%2BesJ2gmoSmEg53Whg-hUYhTc%2Bf%3D1az-PDUCA%40mail.gmail.com.

[John Abd-El-Malek]

I'm also inclined to favor not moving it back and forth since I suspect the subtlety of the different directories would not be figured out by most engineers.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/identity-service-dev/CAEPrgOOnpuyrAEwDmA9SfpieqbXZLWTk1OfWiHRNEzrecm8xLQ%40mail.gmail.com.

[Colin Blundell]

OK, thanks for the feedback! I'll keep it where it is and sharpen the documentation in //services/identity/public.

Best,

Colin