How to properly configure window width and height?

[xivan...@gmail.com]

Hello,

i'm trying to configure width and height of the opened tab window, but seems that my changes almost has no effect (i.e. it affects only screenshots viewport).

➜  chrome-linux ./chrome --version

Chromium 62.0.3173.0 

➜  chrome-linux lsb_release -a

No LSB modules are available.

Distributor ID: Ubuntu

Description: Ubuntu 16.04.2 LTS

Release: 16.04

Codename: xenial

Steps to reproduce:

open ws://127.0.0.1:9222/devtools/browser

=> {"id":1, "method":"Target.createTarget", "params":{ "url":"about:blank", "width":1024, "height":768 } }

<= {"id":1, "result":{"targetId":"2ed8ea7a-ed8a-4ad4-94d4-82799ea5a32d"}}

open ws://127.0.0.1:9222/devtools/page/2ed8ea7a-ed8a-4ad4-94d4-82799ea5a32d

=> {"id":2, "method":"Emulation.setDeviceMetricsOverride", "params":{"width":1024, "height":768,"screenWidth":1024,"screenHeight":768, "deviceScaleFactor": 1, "mobile": false}}

=> {"id":3, "method":"Emulation.setVisibleSize", "params":{"width":1024,"height":768}}

=> {"id":4, "method":"Page.navigate", "params":{"url": "http://ya.ru"}}

wait 5 seconds

=> {"id":5, "method":"Runtime.evaluate", "params":{"expression": "window.screen.width"}}

<= {"id":5,"result":{"result":{"type":"number","value":800,"description":"800"}}}

=> {"id":6, "method":"Runtime.evaluate", "params":{"expression": "window.screen.height"}}

<= {"id":6,"result":{"result":{"type":"number","value":600,"description":"600"}}}

=> {"id":7, "method":"Runtime.evaluate", "params":{"expression": "window.screen.availWidth"}}

<= {"id":7,"result":{"result":{"type":"number","value":800,"description":"800"}}}

=> {"id":8, "method":"Runtime.evaluate", "params":{"expression": "window.screen.availHeight"}}

<= {"id":8,"result":{"result":{"type":"number","value":600,"description":"600"}}}

In other words i'm trying to create a target with w/h = 1024/768, then calling Emulation.setDeviceMetricsOverride and Emulation.setVisibleSize with same w/h and screen w/h, but getting 800/600 in JS window.screen obj.

[Eric Seckler]

Hm, does window.innerWidth/Height change to the correct values?

--
You received this message because you are subscribed to the Google Groups "headless-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev...@chromium.org.
To post to this group, send email to headle...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/aec4a770-f353-41c6-b213-299711fb9a2c%40chromium.org.

[Alex Clarke]

This is because RenderWidget::GetScreenInfo does not know about the device metrics override (it should). 

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev+unsubscribe@chromium.org.

To post to this group, send email to headle...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/aec4a770-f353-41c6-b213-299711fb9a2c%40chromium.org.

--

You received this message because you are subscribed to the Google Groups "headless-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev+unsubscribe@chromium.org.

To post to this group, send email to headle...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/CAHZJZiFCwKXssW0Ff7qXJ9QR9iCzrp9_Rus1mfe02UVSZNNeuA%40mail.gmail.com.

[Alex Clarke]

Actually scratch that, there's something more complex going on.  As it happens I'm debugging a similar problem and naively altering RenderWidget::GetScreenInfo  breaks some layout tests (although it did fix my problem).

[Alex Clarke]

It looks like screen_width & screen_height are only overridden when emulating a mobile device.  I don't really know why that's the case.

[Eric Seckler]

+dgozman, pfeldman

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev...@chromium.org.

To post to this group, send email to headle...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/aec4a770-f353-41c6-b213-299711fb9a2c%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "headless-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev...@chromium.org.

To post to this group, send email to headle...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/CAHZJZiFCwKXssW0Ff7qXJ9QR9iCzrp9_Rus1mfe02UVSZNNeuA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "headless-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev...@chromium.org.

To post to this group, send email to headle...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/CAPG_qM6_M%3D00%2B7Bs2F38CSKLW8NyBLCAiVC-nAFRAfacFLDQDQ%40mail.gmail.com.

[Dmitry Gozman]

Here is what protocol says:

{ "name": "screenWidth", "type": "integer", "optional": true, "experimental": true, "description": "Overriding screen width value in pixels (minimum 0, maximum 10000000). Only used for |mobile==true|." },

The reason for it is historical, but we can certainly support it in desktop emulation as well. Mind making a patch (look at RenderWidgetScreenMetricsEmulator::Apply)?

Thanks,

Dmitry

+dgozman, pfeldman

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev+unsubscribe@chromium.org.

To post to this group, send email to headle...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/aec4a770-f353-41c6-b213-299711fb9a2c%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "headless-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev+unsubscribe@chromium.org.

To post to this group, send email to headle...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/CAHZJZiFCwKXssW0Ff7qXJ9QR9iCzrp9_Rus1mfe02UVSZNNeuA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "headless-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev+unsubscribe@chromium.org.

[Alex Clarke]

I was writing a patch earlier :)  Is the current desktop behavior important? (There don't seem to be any layout tests for it) Should we just make it do the same thing as mobile always or should we add a new flag to control desktop behavior?

[Dmitry Gozman]

Just make it similar to mobile, preserving existing values if I didn't pass anything and overriding otherwise.

- Dmitry

[xivan...@gmail.com]

Eric Seckler, i have re-checked and can confirm that window.innerWidth/Height was changed to correct values.

Also while trying this stuff i have found a bug - 

  if Emulation.setDeviceMetricsOverride was called with deviceScaleFactor = 0 then Page.captureScreenshot method hangs (or fails silently).

According to docs deviceScaleFactor "0 disables the override."

ws dump:

open ws://127.0.0.1:9222/devtools/browser

=> {"id":1, "method":"Target.createTarget", "params":{ "url":"about:blank", "width":1024, "height":768 } }

<= {"id":1, "result":{"targetId":"2ed8ea7a-ed8a-4ad4-94d4-82799ea5a32d"}}

open ws://127.0.0.1:9222/devtools/page/2ed8ea7a-ed8a-4ad4-94d4-82799ea5a32d

=> {"id":2, "method":"Emulation.setDeviceMetricsOverride", "params":{"width":1024, "height":768,"screenWidth":1024,"screenHeight":768, "deviceScaleFactor": 0, "mobile": false}}

=> {"id":3, "method":"Page.navigate", "params":{"url": "http://ya.ru"}}

wait 5 seconds

=> {"id":4, "method":"Page.captureScreenshot", "params":{}}

It's not crucial but counter intuitive as per docs 0 looks like a good default value.

+dgozman, pfeldman

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev...@chromium.org.

To post to this group, send email to headle...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/aec4a770-f353-41c6-b213-299711fb9a2c%40chromium.org.

--
You received this message because you are subscribed to the Google Groups "headless-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev...@chromium.org.

To post to this group, send email to headle...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/CAHZJZiFCwKXssW0Ff7qXJ9QR9iCzrp9_Rus1mfe02UVSZNNeuA%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "headless-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to headless-dev...@chromium.org.

[Sami Kyostila]

Thanks, I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=755653 for the last issue.

- Sami

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/headless-dev/7414bfad-cbae-4cad-a575-41a5c8acfebe%40chromium.org.