new version of chrome-build-extract has been uploaded

22 views
Skip to first unread message

Mike Stipicevic

unread,
Sep 30, 2014, 12:02:33 AM9/30/14
to hackability-cy, hin...@chromium.org
Hello hackability-cyers!

An error was found today in which stale data was served by chrome-build-extract if a builder's build count was reset to zero. I'm uploading a fix now which should correct the issue as new builds are scanned. See https://code.google.com/p/chromium/issues/detail?id=418849 for details.

Please contact me or hinoka@ if you have any questions.

- Mike

Ojan Vafai

unread,
Sep 30, 2014, 12:10:24 AM9/30/14
to Mike Stipicevic, hackability-cy, Ryan Tseng, Eric Roman
FWIW, this is almost certainly the root cause of all the cases where sheriff-o-matic showed incorrect data, including both missing failures that were happening and reporting failures that weren't happening.

\o/

--
You received this message because you are subscribed to the Google Groups "Chromium Hackability Code Yellow" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hackability-c...@chromium.org.
To post to this group, send email to hackabi...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/hackability-cy/CAP8mwOCVHkBifOfVZ27tEQK8O-LjTPJVN6ocngppmkO6C8tb7A%40mail.gmail.com.

Levi Weintraub

unread,
Sep 30, 2014, 12:27:44 AM9/30/14
to Ojan Vafai, Mike Stipicevic, hackability-cy, Ryan Tseng, Eric Roman
\o/

This had been a source of a lot of consternation. Kudos for figuring it out!!

Mike Stipicevic

unread,
Sep 30, 2014, 3:49:09 PM9/30/14
to Levi Weintraub, Ojan Vafai, Mike Stipicevic, hackability-cy, Ryan Tseng, Eric Roman
It looks like the fix is working and new data is being served. It looks like it's taking a while to fill in all the new data though, I'm conversing with Ryan to see how we can speed this up.

Mike Stipicevic

unread,
Oct 6, 2014, 8:53:17 PM10/6/14
to hackability-cy, Ryan Tseng, Levi Weintraub, Ojan Vafai
Hello hackability-cyers!

A new version of chrome-build-extract has been uploaded which adds created_timestamp for both master and build jsons. This gives you the unix timestamp of when the json was crawled or the build was first seen.

- Mike

Sergey Berezin

unread,
Oct 7, 2014, 2:56:11 PM10/7/14
to Mike Stipicevic, hackability-cy, Ryan Tseng, Levi Weintraub, Ojan Vafai
Thanks, Mike!

To understand it better, the existing "times" stamps are what buildbot reported, and "created_timestamp" is when CBE has actually loaded the latest JSON, is that right?

In the few builds I looked at, the create_timestamp is always more recent than the end time of the build. 

Sergey.

--
You received this message because you are subscribed to the Google Groups "Chromium Hackability Code Yellow" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hackability-c...@chromium.org.
To post to this group, send email to hackabi...@chromium.org.

Mike Stipicevic

unread,
Oct 7, 2014, 6:17:26 PM10/7/14
to Sergey Berezin, Mike Stipicevic, hackability-cy, Ryan Tseng, Levi Weintraub, Ojan Vafai
created_timestamp has two meanings, due to the colorful architecture of chrome-build-extract. For master json, it is when the json was retrieved. For build json, it is when the build was first seen as finished (roughly corresponding to when the master json was crawled, not when the build json was crawled). Thus, a build created_timestamp is expected to be after the build has finished.

On Tue Oct 07 2014 at 11:56:11 AM Sergey Berezin <sergey...@google.com> wrote:
Thanks, Mike!

To understand it better, the existing "times" stamps are what buildbot reported, and "created_timestamp" is when CBE has actually loaded the latest JSON, is that right?

In the few builds I looked at, the create_timestamp is always more recent than the end time of the build. 

Sergey.

On Mon, Oct 6, 2014 at 5:53 PM, Mike Stipicevic <st...@chromium.org> wrote:
Hello hackability-cyers!

A new version of chrome-build-extract has been uploaded which adds created_timestamp for both master and build jsons. This gives you the unix timestamp of when the json was crawled or the build was first seen.

- Mike

--
You received this message because you are subscribed to the Google Groups "Chromium Hackability Code Yellow" group.
To unsubscribe from this group and stop receiving emails from it, send an email to hackability-cy+unsubscribe@chromium.org.
Reply all
Reply to author
Forward
0 new messages