Issue 1384604 in chromium: Remove expired histograms GPU.AppContainer.EnableState, GPU.AppContainer.Status, GPU.GPUProcessTerminationOrigin, GPU.GPUProcessTerminationStatus, GPU.ProcessIntegrityResult, GPU.ProcessLifetimeEvents.DisplayCompositor

3 views
Skip to first unread message

histogram-eraser via monorail

unread,
Nov 15, 2022, 12:29:16 PM11/15/22
to graphi...@chromium.org
Status: Untriaged
Owner: ----
CC: msi...@igalia.com, rjkr...@chromium.org, vmi...@chromium.org, w...@chromium.org, for...@chromium.org, graphi...@chromium.org, ssm...@microsoft.com, z...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>GPU>Internals
Pri: 3
Type: Task

New issue 1384604 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms GPU.AppContainer.EnableState, GPU.AppContainer.Status, GPU.GPUProcessTerminationOrigin, GPU.GPUProcessTerminationStatus, GPU.ProcessIntegrityResult, GPU.ProcessLifetimeEvents.DisplayCompositor
https://bugs.chromium.org/p/chromium/issues/detail?id=1384604

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- GPU.AppContainer.EnableState (expired as of 2020-07-31)
- GPU.AppContainer.Status (expired as of 2020-10-11)
- GPU.GPUProcessTerminationOrigin (expired as of 2019-08-14)
- GPU.GPUProcessTerminationStatus (expired as of 2018-04-23)
- GPU.ProcessIntegrityResult (expired as of 2021-12-12)
- GPU.ProcessLifetimeEvents.DisplayCompositor (expired as of M85)

The following code locations were found:

content/browser/gpu/gpu_process_host.cc:141:
"GPU.ProcessLifetimeEvents.DisplayCompositor";
content/browser/gpu/gpu_process_host.cc:384:
base::UmaHistogramEnumeration("GPU.AppContainer.EnableState",
content/browser/gpu/gpu_process_host.cc:390:
base::UmaHistogramEnumeration("GPU.AppContainer.EnableState",
content/browser/gpu/gpu_process_host.cc:396:
base::UmaHistogramEnumeration("GPU.AppContainer.EnableState", AC_ENABLED,
content/browser/gpu/gpu_process_host.cc:518:
UMA_HISTOGRAM_ENUMERATION("GPU.ProcessIntegrityResult",
content/browser/gpu/gpu_process_host.cc:526:
UMA_HISTOGRAM_ENUMERATION("GPU.ProcessIntegrityResult",
content/browser/gpu/gpu_process_host.cc:530:
UMA_HISTOGRAM_ENUMERATION("GPU.ProcessIntegrityResult",
content/browser/gpu/gpu_process_host.cc:547:
base::UmaHistogramSparse("GPU.AppContainer.Status", error_code);
content/browser/gpu/gpu_process_host.cc:797:
UMA_HISTOGRAM_ENUMERATION("GPU.GPUProcessTerminationStatus2",
content/browser/gpu/gpu_process_host.cc:843:
UMA_HISTOGRAM_ENUMERATION("GPU.GPUProcessTerminationOrigin",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- Mark the bug as Available to confirm that the histograms can be removed.
- Annotate the histograms as intentionally expired (see above) and update the bug.

Available bugs will be added to the Code Health Rotation to have the code cleaned up by participants in the rotation.

If the bug is left in the Untriaged state without any activity by histogram owners, it will be marked as Available after approximately two weeks.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

takemoto via monorail

unread,
Nov 16, 2022, 10:52:11 AM11/16/22
to graphi...@chromium.org
Updates:
Labels: Pri-2
Status: Available

Comment #1 on issue 1384604 by take...@google.com: Remove expired histograms GPU.AppContainer.EnableState, GPU.AppContainer.Status, GPU.GPUProcessTerminationOrigin, GPU.GPUProcessTerminationStatus, GPU.ProcessIntegrityResult, GPU.ProcessLifetimeEvents.DisplayCompositor
https://bugs.chromium.org/p/chromium/issues/detail?id=1384604#c1

(No comment was entered for this change.)

asvitkine via monorail

unread,
Nov 16, 2022, 4:32:59 PM11/16/22
to graphi...@chromium.org
Updates:
Labels: Proj-CodeHealthRotation-Bug

Comment #2 on issue 1384604 by asvi...@chromium.org: Remove expired histograms GPU.AppContainer.EnableState, GPU.AppContainer.Status, GPU.GPUProcessTerminationOrigin, GPU.GPUProcessTerminationStatus, GPU.ProcessIntegrityResult, GPU.ProcessLifetimeEvents.DisplayCompositor
https://bugs.chromium.org/p/chromium/issues/detail?id=1384604#c2

arichiv via monorail

unread,
Nov 29, 2022, 2:03:24 PM11/29/22
to graphi...@chromium.org
Updates:
Status: Fixed

Comment #4 on issue 1384604 by ari...@chromium.org: Remove expired histograms GPU.AppContainer.EnableState, GPU.AppContainer.Status, GPU.GPUProcessTerminationOrigin, GPU.GPUProcessTerminationStatus, GPU.ProcessIntegrityResult, GPU.ProcessLifetimeEvents.DisplayCompositor
https://bugs.chromium.org/p/chromium/issues/detail?id=1384604#c4

Git Watcher via monorail

unread,
Nov 30, 2022, 2:42:12 PM11/30/22
to graphi...@chromium.org

Comment #5 on issue 1384604 by Git Watcher: Remove expired histograms GPU.AppContainer.EnableState, GPU.AppContainer.Status, GPU.GPUProcessTerminationOrigin, GPU.GPUProcessTerminationStatus, GPU.ProcessIntegrityResult, GPU.ProcessLifetimeEvents.DisplayCompositor
https://bugs.chromium.org/p/chromium/issues/detail?id=1384604#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/a6b2bb3af5e28acb32d729e4fb446f30544213db

commit a6b2bb3af5e28acb32d729e4fb446f30544213db
Author: Ari Chivukula <ari...@chromium.org>
Date: Wed Nov 30 19:41:36 2022

[Expired Histograms] GPU.AppContainer.EnableState, GPU.AppContainer.Status, GPU.GPUProcessTerminationOrigin, GPU.GPUProcessTerminationStatus, GPU.ProcessIntegrityResult, GPU.ProcessLifetimeEvents.DisplayCompositor

This CL is part of a code health project to remove expired histogram
logging from the codebase. This data has not been recorded since
2018/2019/2020/2021/M85.

GPU.GPUProcessTerminationOrigin was brought back to life and
extended six months at the request of @rkaplow

Bug: 1384604
Change-Id: I2f4c14beb71014b23833c597caccbe87e6b09dc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4040947
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Auto-Submit: Ari Chivukula <ari...@chromium.org>
Reviewed-by: Kenneth Russell <k...@chromium.org>
Commit-Queue: Kenneth Russell <k...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1077620}

[modify] https://crrev.com/a6b2bb3af5e28acb32d729e4fb446f30544213db/tools/metrics/histograms/metadata/gpu/histograms.xml
[modify] https://crrev.com/a6b2bb3af5e28acb32d729e4fb446f30544213db/content/browser/gpu/gpu_process_host.cc
Reply all
Reply to author
Forward
0 new messages