Issue 1384850 in chromium: Remove expired histograms Gpu.MetalProxy.NewLibraryTime, Gpu.MetalProxy.NewRenderPipelineStateTime

0 views
Skip to first unread message

histogram-eraser via monorail

unread,
Nov 15, 2022, 2:22:43 PM11/15/22
to graphi...@chromium.org
Status: Untriaged
Owner: ----
CC: graphi...@chromium.org, ccam...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>Compositing
Pri: 3
Type: Task

New issue 1384850 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Gpu.MetalProxy.NewLibraryTime, Gpu.MetalProxy.NewRenderPipelineStateTime
https://bugs.chromium.org/p/chromium/issues/detail?id=1384850

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Gpu.MetalProxy.NewLibraryTime (expired as of M82)
- Gpu.MetalProxy.NewRenderPipelineStateTime (expired as of M82)

The following code locations were found:

components/viz/common/gpu/metal_api_proxy.mm:59:
SCOPED_UMA_HISTOGRAM_TIMER("Gpu.MetalProxy.NewLibraryTime");
components/viz/common/gpu/metal_api_proxy.mm:106:
SCOPED_UMA_HISTOGRAM_TIMER("Gpu.MetalProxy.NewRenderPipelineStateTime");
components/viz/common/gpu/metal_api_proxy.mm:167:
SCOPED_UMA_HISTOGRAM_TIMER("Gpu.MetalProxy.NewLibraryTime");
components/viz/common/gpu/metal_api_proxy.mm:349:
SCOPED_UMA_HISTOGRAM_TIMER("Gpu.MetalProxy.NewRenderPipelineStateTime");

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- Mark the bug as Available to confirm that the histograms can be removed.
- Annotate the histograms as intentionally expired (see above) and update the bug.

Available bugs will be added to the Code Health Rotation to have the code cleaned up by participants in the rotation.

If the bug is left in the Untriaged state without any activity by histogram owners, it will be marked as Available after approximately two weeks.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

takemoto via monorail

unread,
Nov 16, 2022, 10:37:59 AM11/16/22
to graphi...@chromium.org
Updates:
Labels: Pri-2
Owner: sun...@chromium.org
Status: Assigned

Comment #1 on issue 1384850 by take...@google.com: Remove expired histograms Gpu.MetalProxy.NewLibraryTime, Gpu.MetalProxy.NewRenderPipelineStateTime
https://bugs.chromium.org/p/chromium/issues/detail?id=1384850#c1

sunnyps@ can you triage further?
Reply all
Reply to author
Forward
0 new messages