Issue 1384572 in chromium: Remove expired histograms GPU.FenceSupport, GPU.RenderableFormat.R11F_G11F_B10F.FLOAT, GPU.RenderableFormat.R16F.FLOAT, GPU.RenderableFormat.R32F.FLOAT, GPU.RenderableFormat.RG16F.FLOAT, GPU.RenderableFormat.RG32F.FLOAT, GPU.RenderableFormat.RGB32F.FLOAT, GPU.RenderableFormat.RGBA16F.FLOAT, GPU.RenderableFormat.RGBA16F.HALF_FLOAT, GPU.RenderableFormat.RGBA32F.FLOAT, GPU.TextureRG

1 view
Skip to first unread message

histogram-eraser via monorail

unread,
Nov 15, 2022, 12:26:28 PM11/15/22
to graphi...@chromium.org
Status: Untriaged
Owner: ----
CC: rev...@chromium.org, graphi...@chromium.org, z...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>GPU>Internals
Pri: 3
Type: Task

New issue 1384572 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms GPU.FenceSupport, GPU.RenderableFormat.R11F_G11F_B10F.FLOAT, GPU.RenderableFormat.R16F.FLOAT, GPU.RenderableFormat.R32F.FLOAT, GPU.RenderableFormat.RG16F.FLOAT, GPU.RenderableFormat.RG32F.FLOAT, GPU.RenderableFormat.RGB32F.FLOAT, GPU.RenderableFormat.RGBA16F.FLOAT, GPU.RenderableFormat.RGBA16F.HALF_FLOAT, GPU.RenderableFormat.RGBA32F.FLOAT, GPU.TextureRG
https://bugs.chromium.org/p/chromium/issues/detail?id=1384572

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- GPU.FenceSupport (expired as of M77)
- GPU.RenderableFormat.R11F_G11F_B10F.FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.R16F.FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.R32F.FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.RG16F.FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.RG32F.FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.RGB32F.FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.RGBA16F.FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.RGBA16F.HALF_FLOAT (expired as of 2021-09-15)
- GPU.RenderableFormat.RGBA32F.FLOAT (expired as of 2021-09-15)
- GPU.TextureRG (expired as of M77)

The following code locations were found:

gpu/command_buffer/service/feature_info.cc:1400:
UMA_HISTOGRAM_BOOLEAN("GPU.FenceSupport", ui_gl_fence_works);
gpu/command_buffer/service/feature_info.cc:1498:
UMA_HISTOGRAM_BOOLEAN("GPU.TextureRG", feature_flags_.ext_texture_rg);
gpu/command_buffer/service/feature_info.cc:1899:
base::UmaHistogramBoolean("GPU.RenderableFormat.RGBA32F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1901:
base::UmaHistogramBoolean("GPU.RenderableFormat.RGB32F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1915:
"GPU.RenderableFormat.R16F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1916:
"GPU.RenderableFormat.RG16F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1917:
"GPU.RenderableFormat.RGBA16F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1918:
"GPU.RenderableFormat.R32F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1919:
"GPU.RenderableFormat.RG32F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1920:
"GPU.RenderableFormat.R11F_G11F_B10F.FLOAT",
gpu/command_buffer/service/feature_info.cc:1950:
base::UmaHistogramBoolean("GPU.RenderableFormat.RGBA16F.HALF_FLOAT",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- Mark the bug as Available to confirm that the histograms can be removed.
- Annotate the histograms as intentionally expired (see above) and update the bug.

Available bugs will be added to the Code Health Rotation to have the code cleaned up by participants in the rotation.

If the bug is left in the Untriaged state without any activity by histogram owners, it will be marked as Available after approximately two weeks.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

takemoto via monorail

unread,
Nov 16, 2022, 10:31:26 AM11/16/22
to graphi...@chromium.org
Updates:
Labels: Pri-2
Status: Available

Comment #1 on issue 1384572 by take...@google.com: Remove expired histograms GPU.FenceSupport, GPU.RenderableFormat.R11F_G11F_B10F.FLOAT, GPU.RenderableFormat.R16F.FLOAT, GPU.RenderableFormat.R32F.FLOAT, GPU.RenderableFormat.RG16F.FLOAT, GPU.RenderableFormat.RG32F.FLOAT, GPU.RenderableFormat.RGB32F.FLOAT, GPU.RenderableFormat.RGBA16F.FLOAT, GPU.RenderableFormat.RGBA16F.HALF_FLOAT, GPU.RenderableFormat.RGBA32F.FLOAT, GPU.TextureRG
https://bugs.chromium.org/p/chromium/issues/detail?id=1384572#c1

(No comment was entered for this change.)

arichiv via monorail

unread,
Nov 29, 2022, 2:01:01 PM11/29/22
to graphi...@chromium.org
Updates:
Status: Fixed

Comment #4 on issue 1384572 by ari...@chromium.org: Remove expired histograms GPU.FenceSupport, GPU.RenderableFormat.R11F_G11F_B10F.FLOAT, GPU.RenderableFormat.R16F.FLOAT, GPU.RenderableFormat.R32F.FLOAT, GPU.RenderableFormat.RG16F.FLOAT, GPU.RenderableFormat.RG32F.FLOAT, GPU.RenderableFormat.RGB32F.FLOAT, GPU.RenderableFormat.RGBA16F.FLOAT, GPU.RenderableFormat.RGBA16F.HALF_FLOAT, GPU.RenderableFormat.RGBA32F.FLOAT, GPU.TextureRG
https://bugs.chromium.org/p/chromium/issues/detail?id=1384572#c4

Git Watcher via monorail

unread,
Nov 29, 2022, 2:57:12 PM11/29/22
to graphi...@chromium.org

Comment #5 on issue 1384572 by Git Watcher: Remove expired histograms GPU.FenceSupport, GPU.RenderableFormat.R11F_G11F_B10F.FLOAT, GPU.RenderableFormat.R16F.FLOAT, GPU.RenderableFormat.R32F.FLOAT, GPU.RenderableFormat.RG16F.FLOAT, GPU.RenderableFormat.RG32F.FLOAT, GPU.RenderableFormat.RGB32F.FLOAT, GPU.RenderableFormat.RGBA16F.FLOAT, GPU.RenderableFormat.RGBA16F.HALF_FLOAT, GPU.RenderableFormat.RGBA32F.FLOAT, GPU.TextureRG
https://bugs.chromium.org/p/chromium/issues/detail?id=1384572#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c1af4a974f69b1cf3eaa868b81f932418508a246

commit c1af4a974f69b1cf3eaa868b81f932418508a246
Author: Ari Chivukula <ari...@chromium.org>
Date: Tue Nov 29 19:56:53 2022

[Expired Histograms] GPU.FenceSupport GPU.TextureRG GPU.RenderableFormat.*

This CL is part of a code health project to remove expired histogram
logging from the codebase. This data has not been recorded since
2021/M77.

Bug: 1384572
Change-Id: I2e5a9d79153251327cac22bd2535bb7a77c7443b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4040107
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Reviewed-by: Kenneth Russell <k...@chromium.org>
Commit-Queue: Kenneth Russell <k...@chromium.org>
Auto-Submit: Ari Chivukula <ari...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1077025}

[modify] https://crrev.com/c1af4a974f69b1cf3eaa868b81f932418508a246/tools/metrics/histograms/metadata/gpu/histograms.xml
[modify] https://crrev.com/c1af4a974f69b1cf3eaa868b81f932418508a246/gpu/command_buffer/service/feature_info.cc
Reply all
Reply to author
Forward
0 new messages