Issue 1521778 in chromium: LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer is flaky

[rouslan via monorail]

Status: Untriaged
Owner: ----
CC: graphi...@chromium.org
Components: Internals>Compositing>Scroll
OS: Mac
Pri: 3
Type: Bug

New issue 1521778 by rou...@chromium.org: LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1521778

LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer is flaky on mac_chromium_asan_rel_ng - https://ci.chromium.org/ui/p/chromium/builders/ci/Mac%20ASan%2064%20Tests%20%281%29

Failure reason:

Layer_tree_host_unittest_scroll.cc(656): Expected equality of these values:
javascript_scroll_ + scroll_amount_
Which is: 42,4
CurrentScrollOffset(expected_scroll_layer_)
Which is: 40,5

Summary:

[ RUN ] LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer
../../cc/trees/layer_tree_host_unittest_scroll.cc:656: Failure
Expected equality of these values:
javascript_scroll_ + scroll_amount_
Which is: 42,4
CurrentScrollOffset(expected_scroll_layer_)
Which is: 40,5
Stack trace:
0 cc_unittests 0x000000010ee47dc7 cc::(anonymous namespace)::LayerTreeHostScrollTestCaseWithChild::UpdateLayerTreeHost() + 2887
1 cc_unittests 0x0000000111c8b86c cc::LayerTreeHost::RequestMainFrameUpdate(bool) + 396
2 cc_unittests 0x0000000111defa78 cc::ProxyMain::BeginMainFrame(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>) + 5480
3 cc_unittests 0x0000000111de9d42 void base::internal::Invoker<base::internal::BindState<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, void ()>::RunImpl<void (cc::ProxyMain::*)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>, 0ul, 1ul>(void (cc::ProxyMain::*&&)(std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>), std::__Cr::tuple<base::WeakPtr<cc::ProxyMain>, std::__Cr::unique_ptr<cc::BeginMainFrameAndCommitState, std::__Cr::default_delete<cc::BeginMainFrameAndCommitState>>>&&, std::__Cr::integer_sequence<unsigned long, 0ul, 1ul>) + 498
4 cc_unittests 0x000000010caddbe4 base::OnceCallback<void ()>::Run() && + 404
5 cc_unittests 0x000000011339c2e1 base::TaskAnnotator::RunTaskImpl(base::PendingTask&) + 913
6 cc_unittests 0x00000001134239fd base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) + 3981
7 cc_unittests 0x0000000113422045 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 549
8 cc_unittests 0x0000000113425025 non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 21
9 cc_unittests 0x00000001133128d3 base::MessagePumpDefault::Run(base::MessagePump::Delegate*) + 611
10 cc_unittests 0x00000001134263a1 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 1809
11 cc_unittests 0x00000001133746a8 base::RunLoop::Run(base::Location const&) + 1528
12 cc_unittests 0x0000000111ea1339 cc::LayerTreeTest::RunTest(cc::CompositorMode) + 2025

../../cc/trees/layer_tree_host_unittest_scroll.cc:736: Failure
Expected equality of these values:
javascript_scroll_ + scroll_amount_
Which is: 42,4
ScrollOffsetBase(expected_scroll_layer_impl)
Which is: 40,5
Stack trace:
0 cc_unittests 0x000000010ee495e1 cc::(anonymous namespace)::LayerTreeHostScrollTestCaseWithChild::DidActivateTreeOnThread(cc::LayerTreeHostImpl*) + 5281
1 cc_unittests 0x0000000111eaaa23 cc::LayerTreeHostImplForTesting::ActivateSyncTree() + 499
2 cc_unittests 0x0000000111de3ad6 cc::ProxyImpl::ScheduledActionActivateSyncTree() + 726
3 cc_unittests 0x0000000111b163e6 cc::Scheduler::ProcessScheduledActions() + 2310
4 cc_unittests 0x0000000111dd9589 cc::ProxyImpl::NotifyReadyToCommitOnImpl(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool) + 2105
5 cc_unittests 0x0000000111dfe462 void base::internal::Invoker<base::internal::BindState<void (cc::ProxyImpl::*)(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool), base::internal::UnretainedWrapper<cc::ProxyImpl, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::internal::UnretainedWrapper<cc::CompletionEvent, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, base::internal::UnretainedWrapper<cc::ThreadUnsafeCommitState, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::TimeTicks, viz::BeginFrameArgs, bool, base::internal::UnretainedWrapper<cc::CommitTimestamps, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, bool>, void ()>::RunImpl<void (cc::ProxyImpl::*)(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool), std::__Cr::tuple<base::internal::UnretainedWrapper<cc::ProxyImpl, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::internal::UnretainedWrapper<cc::CompletionEvent, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, base::internal::UnretainedWrapper<cc::ThreadUnsafeCommitState, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::TimeTicks, viz::BeginFrameArgs, bool, base::internal::UnretainedWrapper<cc::CommitTimestamps, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, bool>, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>(void (cc::ProxyImpl::*&&)(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool), std::__Cr::tuple<base::internal::UnretainedWrapper<cc::ProxyImpl, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::internal::UnretainedWrapper<cc::CompletionEvent, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, base::internal::UnretainedWrapper<cc::ThreadUnsafeCommitState, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::TimeTicks, viz::BeginFrameArgs, bool, base::internal::UnretainedWrapper<cc::CommitTimestamps, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, bool>&&, std::__Cr::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>) + 850
6 cc_unittests 0x000000010caddbe4 base::OnceCallback<void ()>::Run() && + 404
7 cc_unittests 0x000000011339c2e1 base::TaskAnnotator::RunTaskImpl(base::PendingTask&) + 913
8 cc_unittests 0x00000001134239fd base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) + 3981
9 cc_unittests 0x0000000113422045 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 549
10 cc_unittests 0x0000000113425025 non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 21
11 cc_unittests 0x00000001133128d3 base::MessagePumpDefault::Run(base::MessagePump::Delegate*) + 611
12 cc_unittests 0x00000001134263a1 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 1809
13 cc_unittests 0x00000001133746a8 base::RunLoop::Run(base::Location const&) + 1528
14 cc_unittests 0x00000001134be8f3 base::Thread::Run(base::RunLoop*) + 355
15 cc_unittests 0x00000001134bf0af base::Thread::ThreadMain() + 1599
16 cc_unittests 0x00000001134fab8f base::(anonymous namespace)::ThreadFunc(void*) + 351
17 libclang_rt.asan_osx_dynamic.dylib 0x000000011b6d52f7 __sanitizer_weak_hook_memcmp + 207079
18 libsystem_pthread.dylib 0x00007ff80d5ed1d3 _pthread_start + 125

../../cc/trees/layer_tree_host_unittest_scroll.cc:738: Failure
Expected equality of these values:
gfx::Vector2d()
Which is: [0 0]
ScrollDelta(expected_scroll_layer_impl)
Which is: [2 -1]
Stack trace:
0 cc_unittests 0x000000010ee4a0b3 cc::(anonymous namespace)::LayerTreeHostScrollTestCaseWithChild::DidActivateTreeOnThread(cc::LayerTreeHostImpl*) + 8051
1 cc_unittests 0x0000000111eaaa23 cc::LayerTreeHostImplForTesting::ActivateSyncTree() + 499
2 cc_unittests 0x0000000111de3ad6 cc::ProxyImpl::ScheduledActionActivateSyncTree() + 726
3 cc_unittests 0x0000000111b163e6 cc::Scheduler::ProcessScheduledActions() + 2310
4 cc_unittests 0x0000000111dd9589 cc::ProxyImpl::NotifyReadyToCommitOnImpl(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool) + 2105
5 cc_unittests 0x0000000111dfe462 void base::internal::Invoker<base::internal::BindState<void (cc::ProxyImpl::*)(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool), base::internal::UnretainedWrapper<cc::ProxyImpl, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::internal::UnretainedWrapper<cc::CompletionEvent, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, base::internal::UnretainedWrapper<cc::ThreadUnsafeCommitState, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::TimeTicks, viz::BeginFrameArgs, bool, base::internal::UnretainedWrapper<cc::CommitTimestamps, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, bool>, void ()>::RunImpl<void (cc::ProxyImpl::*)(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool), std::__Cr::tuple<base::internal::UnretainedWrapper<cc::ProxyImpl, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::internal::UnretainedWrapper<cc::CompletionEvent, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, base::internal::UnretainedWrapper<cc::ThreadUnsafeCommitState, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::TimeTicks, viz::BeginFrameArgs, bool, base::internal::UnretainedWrapper<cc::CommitTimestamps, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, bool>, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>(void (cc::ProxyImpl::*&&)(cc::CompletionEvent*, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, cc::ThreadUnsafeCommitState const*, base::TimeTicks, viz::BeginFrameArgs const&, bool, cc::CommitTimestamps*, bool), std::__Cr::tuple<base::internal::UnretainedWrapper<cc::ProxyImpl, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::internal::UnretainedWrapper<cc::CompletionEvent, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::unique_ptr<cc::CommitState, std::__Cr::default_delete<cc::CommitState>>, base::internal::UnretainedWrapper<cc::ThreadUnsafeCommitState, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, base::TimeTicks, viz::BeginFrameArgs, bool, base::internal::UnretainedWrapper<cc::CommitTimestamps, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, bool>&&, std::__Cr::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul, 5ul, 6ul, 7ul, 8ul>) + 850
6 cc_unittests 0x000000010caddbe4 base::OnceCallback<void ()>::Run() && + 404
7 cc_unittests 0x000000011339c2e1 base::TaskAnnotator::RunTaskImpl(base::PendingTask&) + 913
8 cc_unittests 0x00000001134239fd base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) + 3981
9 cc_unittests 0x0000000113422045 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 549
10 cc_unittests 0x0000000113425025 non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 21
11 cc_unittests 0x00000001133128d3 base::MessagePumpDefault::Run(base::MessagePump::Delegate*) + 611
12 cc_unittests 0x00000001134263a1 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 1809
13 cc_unittests 0x00000001133746a8 base::RunLoop::Run(base::Location const&) + 1528
14 cc_unittests 0x00000001134be8f3 base::Thread::Run(base::RunLoop*) + 355
15 cc_unittests 0x00000001134bf0af base::Thread::ThreadMain() + 1599
16 cc_unittests 0x00000001134fab8f base::(anonymous namespace)::ThreadFunc(void*) + 351
17 libclang_rt.asan_osx_dynamic.dylib 0x000000011b6d52f7 __sanitizer_weak_hook_memcmp + 207079
18 libsystem_pthread.dylib 0x00007ff80d5ed1d3 _pthread_start + 125

[ FAILED ] LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer (291 ms)

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[rouslan via monorail]

Comment #1 on issue 1521778 by rou...@chromium.org: LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1521778#c1

https://crrev.com/c/5237475 disables the test on Mac ASan.

[Git Watcher via monorail]

Comment #2 on issue 1521778 by Git Watcher: LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1521778#c2

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c815807e68d0beb1ec4180909615715a56f0fb91

commit c815807e68d0beb1ec4180909615715a56f0fb91
Author: Rouslan Solomakhin <rou...@chromium.org>
Date: Thu Jan 25 15:34:04 2024

[Gardening] Disable a flaky scroll test on Mac ASan.

Bug: 1521778
Change-Id: I62eeb091a530afa7296526e6001bb952a007401b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5237475
Commit-Queue: Rouslan Solomakhin <rou...@chromium.org>
Auto-Submit: Rouslan Solomakhin <rou...@chromium.org>
Owners-Override: Rouslan Solomakhin <rou...@chromium.org>
Reviewed-by: David Bokan <bo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1252098}

[modify] https://crrev.com/c815807e68d0beb1ec4180909615715a56f0fb91/cc/trees/layer_tree_host_unittest_scroll.cc

[takemoto via monorail]

Updates:
Cc: sun...@chromium.org
Labels: Needs-Further-Triage Pri-2

Comment #3 on issue 1521778 by take...@google.com: LayerTreeHostScrollTestCaseWithChild.DeviceScaleFactor2_ScrollRootScrollLayer is flaky
https://bugs.chromium.org/p/chromium/issues/detail?id=1521778#c3

(No comment was entered for this change.)