Issue 1384280 in chromium: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2

2 views
Skip to first unread message

asvitkine via monorail

unread,
Nov 14, 2022, 5:45:38 PM11/14/22
to graphi...@chromium.org
Status: Untriaged
Owner: ----
CC: sun...@chromium.org, graphi...@chromium.org, z...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>GPU>Internals
Pri: 3
Type: Bug

New issue 1384280 by asvi...@chromium.org: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- GPU.DirectComposition.CompositionMode2.VideoOrCanvas (expired as of 2021-12-31)
- GPU.DirectComposition.DecodeSwapChainCreationResult (expired as of M76)
- GPU.DirectComposition.DecodeSwapChainNotUsedReason (expired as of M76)
- GPU.DirectComposition.DecodeSwapChainUsed (expired as of M76)
- GPU.DirectComposition.SwapChainCreationResult (expired as of M75)
- GPU.DirectComposition.SwapChainCreationResult2 (expired as of 2019-05-31)

The following code locations were found:

ui/gl/swap_chain_presenter.cc:910:
"GPU.DirectComposition.DecodeSwapChainNotUsedReason", not_used_reason);
ui/gl/swap_chain_presenter.cc:964:
"GPU.DirectComposition.DecodeSwapChainCreationResult", hr);
ui/gl/swap_chain_presenter.cc:1295:
UMA_HISTOGRAM_BOOLEAN("GPU.DirectComposition.DecodeSwapChainUsed",
ui/gl/swap_chain_presenter.cc:1316:
"GPU.DirectComposition.CompositionMode2.VideoOrCanvas",
ui/gl/swap_chain_presenter.cc:1647:
"GPU.DirectComposition.SwapChainCreationResult2.";
ui/gl/swap_chain_presenter.cc:1650:
"GPU.DirectComposition.SwapChainCreationResult3.";

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- Mark the bug as Available to confirm that the histograms can be removed.
- Annotate the histograms as intentionally expired (see above) and update the bug.

Available bugs will be added to the Code Health Rotation to have the code cleaned up by participants in the rotation.

If the bug is left in the Untriaged state without any activity by histogram owners, it will be marked as Available after approximately two weeks.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

takemoto via monorail

unread,
Nov 15, 2022, 10:42:35 AM11/15/22
to graphi...@chromium.org
Updates:
Labels: Pri-2
Status: Available

Comment #1 on issue 1384280 by take...@google.com: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c1

(No comment was entered for this change.)

asvitkine via monorail

unread,
Nov 15, 2022, 11:41:52 AM11/15/22
to graphi...@chromium.org
Updates:
Labels: Proj-CodeHealthRotation

Comment #3 on issue 1384280 by asvi...@chromium.org: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c3

asvitkine via monorail

unread,
Nov 15, 2022, 3:14:38 PM11/15/22
to graphi...@chromium.org
Updates:
Labels: -Proj-CodeHealthRotation Proj-CodeHealthRotation-Bug

Comment #4 on issue 1384280 by asvi...@chromium.org: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c4

magchen via monorail

unread,
Nov 21, 2022, 2:25:01 PM11/21/22
to graphi...@chromium.org
Updates:
Cc: mag...@chromium.org

Comment #6 on issue 1384280 by mag...@chromium.org: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c6

Hi Mo and Sunny, I think GPU.DirectComposition.CompositionMode2.VideoOrCanvas should be marked as a permanent histogram. This is the one that shows the percentage of overlay candidates being promoted to HW MPO. We should monitor this number. If this number dropped significantly without a reason, we need to take action.

arichiv via monorail

unread,
Nov 21, 2022, 4:58:23 PM11/21/22
to graphi...@chromium.org

Comment #7 on issue 1384280 by ari...@chromium.org: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c7

Heads up that I'm working on this here: https://chromium-review.googlesource.com/c/chromium/src/+/4041850

I can make it permanent if that's what's best, keep in mind no data has been captured since 2021 though.

magchen via monorail

unread,
Nov 21, 2022, 5:03:16 PM11/21/22
to graphi...@chromium.org

Comment #8 on issue 1384280 by mag...@chromium.org: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c8

Hi arichiv@, Yes please make GPU.DirectComposition.CompositionMode2.VideoOrCanvas permanent. Thank you.
I will abandon my CL that extends this histogram.

Git Watcher via monorail

unread,
Nov 22, 2022, 3:00:13 PM11/22/22
to graphi...@chromium.org

Comment #9 on issue 1384280 by Git Watcher: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c9

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/d3d85d6b438a4f89fce6c16e0665638f67081ad3

commit d3d85d6b438a4f89fce6c16e0665638f67081ad3
Author: Ari Chivukula <ari...@chromium.org>
Date: Tue Nov 22 19:59:40 2022

[Expired Histograms] GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2

This CL is part of a code health project to remove expired histogram
logging from the codebase. This data has not been recorded since
2019/2021/M75/M76.

This CL also extends one metric:
GPU.DirectComposition.CompositionMode2.VideoOrCanvas
as it is health related and should have been kept.

Bug: 1384280
Change-Id: I467ee7eaac2496ab757d6ae6e757c7ec071eb58f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4041850
Auto-Submit: Ari Chivukula <ari...@chromium.org>
Reviewed-by: Maggie Chen <mag...@chromium.org>
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Commit-Queue: Maggie Chen <mag...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1074816}

[modify] https://crrev.com/d3d85d6b438a4f89fce6c16e0665638f67081ad3/tools/metrics/histograms/metadata/gpu/histograms.xml
[modify] https://crrev.com/d3d85d6b438a4f89fce6c16e0665638f67081ad3/tools/metrics/histograms/metadata/histogram_suffixes_list.xml
[modify] https://crrev.com/d3d85d6b438a4f89fce6c16e0665638f67081ad3/ui/gl/swap_chain_presenter.cc
[modify] https://crrev.com/d3d85d6b438a4f89fce6c16e0665638f67081ad3/ui/gl/swap_chain_presenter.h

arichiv via monorail

unread,
Nov 22, 2022, 3:34:11 PM11/22/22
to graphi...@chromium.org
Updates:
Status: Fixed

Comment #10 on issue 1384280 by ari...@chromium.org: Remove expired histograms GPU.DirectComposition.CompositionMode2.VideoOrCanvas, GPU.DirectComposition.DecodeSwapChainCreationResult, GPU.DirectComposition.DecodeSwapChainNotUsedReason, GPU.DirectComposition.DecodeSwapChainUsed, GPU.DirectComposition.SwapChainCreationResult, GPU.DirectComposition.SwapChainCreationResult2
https://bugs.chromium.org/p/chromium/issues/detail?id=1384280#c10


(No comment was entered for this change.)

Reply all
Reply to author
Forward
0 new messages