Issue 1384826 in chromium: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate

2 views
Skip to first unread message

histogram-eraser via monorail

unread,
Nov 15, 2022, 2:20:42 PM11/15/22
to graphi...@chromium.org
Status: Untriaged
Owner: ----
CC: vmi...@chromium.org, graphi...@chromium.org, tomm...@chromium.org, speed-me...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>Compositing
Pri: 3
Type: Task

New issue 1384826 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Event.LatencyInfo.Debug.SourceIdConsistency (expired as of 2020-09-01)
- GPU.AcceleratedSurfaceRefreshRate (expired as of M97)

The following code locations were found:

cc/trees/layer_tree_host_impl.cc:257:
UMA_HISTOGRAM_ENUMERATION("Event.LatencyInfo.Debug.SourceIdConsistency",
cc/trees/layer_tree_host_impl.cc:2967:
UMA_HISTOGRAM_CUSTOM_COUNTS("GPU.AcceleratedSurfaceRefreshRate",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- Mark the bug as Available to confirm that the histograms can be removed.
- Annotate the histograms as intentionally expired (see above) and update the bug.

Available bugs will be added to the Code Health Rotation to have the code cleaned up by participants in the rotation.

If the bug is left in the Untriaged state without any activity by histogram owners, it will be marked as Available after approximately two weeks.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

takemoto via monorail

unread,
Nov 16, 2022, 10:36:32 AM11/16/22
to graphi...@chromium.org
Updates:
Labels: Pri-2
Owner: sun...@chromium.org
Status: Available

Comment #1 on issue 1384826 by take...@google.com: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826#c1

sunnyps@ can you triage further?

temao via monorail

unread,
Dec 15, 2022, 6:21:36 PM12/15/22
to graphi...@chromium.org
Updates:
Status: Assigned

Comment #3 on issue 1384826 by te...@chromium.org: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826#c3

(No comment was entered for this change.)

Git Watcher via monorail

unread,
Dec 21, 2022, 5:55:19 PM12/21/22
to graphi...@chromium.org

Comment #4 on issue 1384826 by Git Watcher: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/5360f4589947ae5ff13a8a1360b5c3801b0cf6cb

commit 5360f4589947ae5ff13a8a1360b5c3801b0cf6cb
Author: Teresa Mao <te...@chromium.org>
Date: Wed Dec 21 22:54:46 2022

Remove UMA histogram GPU.AcceleratedSurfaceRefreshRate

Cleaning up out-dated UML historgrams as part of the code health rotation.
Doc: https://docs.google.com/document/d/1oNXMzNIae3i_7VapOyask_VXpljPTFjSjXgrHgs7lEI

Bug: 1384826
Change-Id: I8d1dbcd701aac13d35796a0e9943171db810ac33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4117957
Reviewed-by: Jonathan Ross <jon...@chromium.org>
Reviewed-by: Luc Nguyen <lucn...@google.com>
Commit-Queue: Teresa Mao <te...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1086125}

[modify] https://crrev.com/5360f4589947ae5ff13a8a1360b5c3801b0cf6cb/tools/metrics/histograms/metadata/gpu/histograms.xml
[modify] https://crrev.com/5360f4589947ae5ff13a8a1360b5c3801b0cf6cb/cc/trees/layer_tree_host_impl.cc

temao via monorail

unread,
Dec 29, 2022, 3:39:56 PM12/29/22
to graphi...@chromium.org
Updates:
Status: Available

Comment #5 on issue 1384826 by te...@chromium.org: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826#c5


(No comment was entered for this change.)

Git Watcher via monorail

unread,
Jan 5, 2023, 5:12:15 PMJan 5
to graphi...@chromium.org

Comment #6 on issue 1384826 by Git Watcher: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826#c6


The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/e8cd1d8c34965d041d8fdc0a82179d49523bd253

commit e8cd1d8c34965d041d8fdc0a82179d49523bd253
Author: Teresa Mao <te...@chromium.org>
Date: Thu Jan 05 22:11:43 2023

Remove UMA histogram Event.LatencyInfo.Debug.SourceIdConsistency


Cleaning up out-dated UML historgrams as part of the code health rotation.
Doc: https://docs.google.com/document/d/1oNXMzNIae3i_7VapOyask_VXpljPTFjSjXgrHgs7lEI

maffourtit via monorail

unread,
Jan 18, 2023, 6:05:03 PMJan 18
to graphi...@chromium.org
Updates:
Owner: maffo...@google.com
Status: Assigned

Comment #7 on issue 1384826 by maffo...@google.com: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826#c7


(No comment was entered for this change.)

maffourtit via monorail

unread,
Jan 18, 2023, 6:32:09 PMJan 18
to graphi...@chromium.org
Updates:
Status: Fixed

Comment #8 on issue 1384826 by maffo...@google.com: Remove expired histograms Event.LatencyInfo.Debug.SourceIdConsistency, GPU.AcceleratedSurfaceRefreshRate
https://bugs.chromium.org/p/chromium/issues/detail?id=1384826#c8

Event.LatencyInfo.Debug.SourceIdConsistency was removed in https://chromium-review.googlesource.com/c/chromium/src/+/4111355

GPU.AcceleratedSurfaceRefreshRate was removed in https://chromium-review.googlesource.com/c/chromium/src/+/4117957
Reply all
Reply to author
Forward
0 new messages