Status: Untriaged
Owner: ----
CC:
graphi...@chromium.org,
z...@chromium.org Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>GPU>Internals
Pri: 3
Type: Task
New issue 1508066 by
histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Hardware.Concurrency
https://bugs.chromium.org/p/chromium/issues/detail?id=1508066The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Hardware.Concurrency (expired as of 2021-12-12)
The following code locations were found:
gpu/config/gpu_util.cc:1036:
UMA_HISTOGRAM_COUNTS_100("Hardware.Concurrency",
As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.
In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histogramsIf you're an owner of any of the histograms, please triage this bug and either:
- If the histogram should be removed:
- Recommended: Mark the bug as Available and add the label Proj-CodeHealthRotation-Bug.
- Or, assign to yourself if you'd prefer to do the clean up yourself.
- Otherwise, annotate the histograms as intentionally expired (see above) and update the bug.
- If you believe the bug was filed in error, cc:
asvi...@chromium.org and mention the problem.
Available bugs with the label Proj-CodeHealthRotation-Bug will be eligible for cleanup by participants in the code health rotation.
If the bug is left in the Untriaged state without any activity by histogram owner(s), we will consider that the histogram is not needed and it will be considered for removal.
--
You received this message because:
1. You were specifically CC'd on the issue
You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settingsReply to this email to add a comment or make updates.