Access to ninjas 'console' pool through GN

63 views
Skip to first unread message

arvid.g...@gmail.com

unread,
Jan 20, 2018, 12:16:03 PM1/20/18
to gn-dev
Ninja has a specific pool called `console`, to allow access to stdout/stderr for the running process. This is useful for test, and would be great to be exposed in GN. Here is an example (the "start in ..." are added for the effect): https://imgur.com/a/YoSvV
As of right now, any pool created in GN is prefixed with the directory it's in, and trying to simply use `console` as a pool name results in an error.

Brett Wilson

unread,
Jan 20, 2018, 12:20:26 PM1/20/18
to arvid.g...@gmail.com, gn-dev
We used to have some Ninja console pools but I think nobody used it, it bitrotted, and was eventually removed (https://chromium-review.googlesource.com/c/chromium/src/+/554300)

Brett

Tomasz Śniatowski

unread,
Jan 20, 2018, 3:54:23 PM1/20/18
to Brett Wilson, arvid.g...@gmail.com, gn-dev
More background in https://codereview.chromium.org/2926013002

--
Tomasz Śniatowski

--
You received this message because you are subscribed to the Google Groups "gn-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to gn-dev+unsubscribe@chromium.org.

Nico Weber

unread,
Apr 20, 2018, 2:43:25 PM4/20/18
to Tomasz Śniatowski, Brett Wilson, arvid.g...@gmail.com, gn-dev
I added back support for this, mostly as a side effect of a bugfix, in https://crrev.com/552353. If you define a pool called "console" in your root BUILD.gn file in the default toolchain, it will map to the ninja console pool.


--
Tomasz Śniatowski

To unsubscribe from this group and stop receiving emails from it, send an email to gn-dev+un...@chromium.org.


Reply all
Reply to author
Forward
0 new messages