Fwd: phony target inputs for shared_library vs static_library

[Andrew Grieve]

I'm investigating why is_component_build=true in chrome results in much smaller build.ninja files, and the main reason seems to be that transitive source_sets are listed as inputs for static_library, but not for shared_library.

E.g. Looking at //third_party/perfetto/src/trace_processor/util:zip_reader, it has a dep on //third_party/zlib (a "component").

When component == shared_library, the zip_reader.ninja file does not have an input edge on clang_x64/phony/third_party/zlib/zlib_adler32_simd, but when component == static_library, it does have this edge.

I can't figure out why this would be correct in one case and not the other... Anyone have insights?

[Andrew Grieve]

To answer my own question, there is a "complete_static_lib = true" flag for static_library targets, that if absent causes them to link only direct sources and not dependent source_sets.

[Nico Weber]

Tangentially related: If you're looking at build.ninja size, maybe you'll find crbug.com/40278737 interesting.

[Andrew Grieve]

oooh, yes, thanks! We should implement those ideas!