Can't add reviewers to a pull request

44 views
Skip to first unread message

Vladimir Nuzhdin (nespie1)

unread,
Apr 22, 2025, 5:27:05 AMApr 22
to gn-dev
Hi guys, it's my first time making a commit to GN. And currently I am stuck at adding reviewers to my PR (link)

What should I do to add reviewers?

Vladimir Nuzhdin (nespie1)

unread,
May 18, 2025, 6:49:38 AMMay 18
to gn-dev, Vladimir Nuzhdin

Hi again everyone

Following up on that, reviewers were successfully added to my PR (link)

But there is a new problem: it's been a couple weeks since then, and the change hasn't been reviewed yet. What should I do and how can I "ping" the reviewers? (I have no rights to mention them with `@` in Gerrit itself)


вторник, 22 апреля 2025 г. в 12:27:05 UTC+3, Vladimir Nuzhdin:

Vladimir Nuzhdin

unread,
May 18, 2025, 6:58:34 AMMay 18
to gn-dev
it's been a couple weeks since then
Pardon me, *since my last patch set was uploaded.

вс, 18 мая 2025 г. в 13:49, Vladimir Nuzhdin (nespie1) <nesp...@gmail.com>:

Takuto Ikuta (生田 拓人)

unread,
May 18, 2025, 10:55:11 PMMay 18
to Vladimir Nuzhdin, gn-dev
Hi Vladimir,

Thanks for the update. Sorry for the delay in reviewing your change. In the future, please feel free to ping the reviewers directly in the CL to bring new patchsets to our attention, as you've done in this case.

Best,
Takuto

To unsubscribe from this group and stop receiving emails from it, send an email to gn-dev+un...@chromium.org.


--
Takuto Ikuta
Software Engineer in Tokyo
Chrome Ops (chrome browser build team)
Reply all
Reply to author
Forward
0 new messages