Binary size increase because of Perfetto SDK migration

Mikhail Khokhlov

unread,

Feb 20, 2024, 9:46:39 AM2/20/24

to fuchs...@chromium.org, Web on Android Performance team

Hi fuchsia-dev,

We're migrating Chrome's tracing backend to the Perfetto client library, which makes tracing in Chrome easier to maintain, and also makes multiple improvements possible. Most platforms have been migrated already (Android, desktop Linux, Mac, Windows). Fuchsia is one of the remaining platforms where it hasn't been done yet.

Unfortunately, this change increases the binary size by ~170KB. I wonder if you are okay with us landing it. I don't know how/if Chrome tracing is used in Fuchsia, but it will definitely allow us to remove the old implementation, unblock improvements in Chrome tracing and reduce technical debt.

For context, the binary size issue was discussed extensively during Android migration, and we invested a lot of effort last year to mitigate it. It was finally decided that the benefits are worth it. See the doc for an overview of this effort and the rationale behind the migration.

Thanks!

Eric Seckler

unread,

Feb 27, 2024, 7:21:16 AM2/27/24

to Mikhail Khokhlov, tracing, Zijie He, fuchs...@chromium.org, Web on Android Performance team

+tracing +Zijie He

Friendly ping on this.

This refactor has shipped on most platforms now and the old backend is due to be deleted imminently.

As Mikhail mentioned, we thoroughly addressed binary size concerns for Android before, so we believe there aren't any feasible further reductions left.

If there are concerns about the increase, I think the only other option would be to disable tracing support on the relevant fuchsia platform(s).

Thanks!

--
You received this message because you are subscribed to the Google Groups "WoAPerf team" group.
To unsubscribe from this group and stop receiving emails from it, send an email to woa-performance-...@google.com.
To view this discussion on the web, visit https://groups.google.com/a/google.com/d/msgid/woa-performance-team/CA%2BpL2F5XkHnyjLaAFeJaUzZBj%2B3t6ZtHrobUeqnqkzriVHtS9g%40mail.gmail.com.
For more options, visit https://groups.google.com/a/google.com/d/optout.

Zijie He

unread,

Feb 27, 2024, 12:48:54 PM2/27/24

to Eric Seckler, Mikhail Khokhlov, tracing, fuchs...@chromium.org, Web on Android Performance team