2 comments on fuchsia_binary_size_trybot.md

[Paul Jensen]

The doc says "think a low-end phone with a <1GB in total disk storage".

Chrome doesn't support phones with <1GB of total disk storage.  Chrome currently requires at least Android Kitkat, which requires at least 1.5GB of application storage (in addition to system storage) and "STRONGLY RECOMMENDS" at least 3 GB of application storage.  I can't think of any Kitkat-capable phones that had less than 8GB of storage.  The Nexus S and Galaxy Nexus, which can only be upgraded to Jelly Bean, had 16 or 32 GB of storage.

There's some example code:

  #if BUILDFLAG(IS_FUCHSIA) && defined(ARCH_CPU_ARM64)
  // Feature you want to exclude from fuchsia-arm64
  #endif  // BUILDFLAG(IS_FUCHSIA) && defined(ARCH_CPU_ARM64)

But I think the #if condition is reversed here as it will include the code in that block for fuchsia-arm64.