Binary size regression in CL 7205138

[Jan Wilken Dörrie]

Hi Fuchsia Dev team,

I am writing regarding a binary size regression on my CL https://crrev.com/c/7205138, which is causing web_engine and chrome_fuchsia to grow by ~49KB compressed and ~16KB uncompressed: https://ci.chromium.org/ui/p/chromium/builders/try/fuchsia-binary-size/1368562/overview

My CL isn't doing anything extraordinary; it only includes some commonly used headers and adds ~100 lines of business logic, so I'm a bit surprised this triggered the check.

My reviewer and I were wondering if the sign-in feature is actually needed for Chromium on Fuchsia? If not, would removing the sign-in component from the Fuchsia build entirely be an option?

Thanks,
Jan

[Zijie He]

Thank you for reaching out Jan.

16k is acceptable, but usually most of the changes added 8k. Compressed size can be impacted by compression logic and is not linear.

The size check is enabled on all CLs. We do not use sign in, but components/ dependence tree may bring the folder into the final binary since fuchsia team doesn't control the dependencies between them, and we'd like to avoid the differences between fuchsia and other platforms to reduce the maintenance cost.

.Hzj_jie

--
You received this message because you are subscribed to the Google Groups "fuchsia-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fuchsia-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/fuchsia-dev/CALB5StYQfxAajZbYuKNQkpnQB7PCdFC41FDdBhr2WZ0ihH3OKQ%40mail.gmail.com.

[David Song]

We could try turning off enable_dice_support which I see is currently enabled on Fuchsia by default (likely for the deprecated Fuchsia Workstation project). That might reduce our binary size as well.

I gave it a quick try locally, but found that we're pulling in //components/signin and the compiler is unhappy.

gen/third_party/libc++/src/include/__memory/unique_ptr.h:75:19: error: invalid application of 'sizeof' to an incomplete type 'ProfileOAuth2TokenServiceDelegate'

From gn path, looks like signin/identity_manager is pulled in by GCM, which (correct me if I'm wrong Zijie) is needed for your current work? 

$ gn path out/arm //fuchsia_web/webengine:web_engine_exe //components/signin/internal/identity_manager
//fuchsia_web/webengine:web_engine_exe --[private]-->
//fuchsia_web/webengine:web_engine_core --[private]-->
//components/gcm_driver:gcm_driver --[private]-->
//components/signin/public/identity_manager:identity_manager --[private]-->
//components/signin/internal/identity_manager:identity_manager

David

To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/fuchsia-dev/CAJBMYs5PqchvDJwWu1P-nr2%2B-vSvePdohWnQtViyRp_cSaoE0A%40mail.gmail.com.