fuchsia-binary-size

[Ryan Tarpine]

Hi Fuchsia chromies,

I have a big CL moving code from //chrome to //content that's failing on the fuchsia-binary-size bot. It shouldn't be much new code, just a move. Can someone help me figure out what's wrong? https://chromium-review.googlesource.com/c/chromium/src/+/6000406?attempt=2&checksRunsSelected=fuchsia-binary-size&tab=checks

Thank you!

Ryan

[David Song]

The target that the bot is checking is Fuchsia WebEngine, which depends on //content and does not depend on //chrome.

So moving libraries into //content is expected to sound alarm bells on the bot.

Best,

David

--
You received this message because you are subscribed to the Google Groups "fuchsia-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to fuchsia-dev...@chromium.org.
To view this discussion visit https://groups.google.com/a/chromium.org/d/msgid/fuchsia-dev/CAFdQzkR%3DVZEBNa%3DjSjs3vLaCRj_YMf3dG80-0GDq91oCbi6LuQ%40mail.gmail.com.

[David Song]

I see that the change is meant for content-embedders to be able to use a feature that Chrome has.

Ideally, Fuchsia WebEngine (and other content-embedders) should be able to choose the features that are included as part of their build, but I don't think we've set up a convention for doing this.

57KB shouldn't be a huge deal for Fuchsia's binary size, and we could look to exclude the feature later in the ongoing binary size reduction efforts.

I'm OK with using the Fuchsia-Binary-Size= footer to bypass the check. 

+Zijie He usually makes the call, but he is OOO for a couple of weeks. Tagging +Sergey Ulanov if you had any thoughts.

Best,

David

[Ryan Tarpine]

Thanks David for the quick response!

I did suspect that for web_engine, but thought that chrome_fuchsia might be different.

I'll use the footer to skip the check

Thanks again,

Ryan

[Zijie He]

Yes, as David said, in theory we can select what libs / features to include, but it will introduce a set of new build rules and increase the maintenance cost, and we never did it unless we have no choice.

57KB isn't something unacceptable, and a quick glance shows we may really want the feature to be included in fuchsia indeed. 😜

.Hzj_jie