Issue 1504869 in chromium: Move MutableFlagWithSafeDefault to base

[hnakashima via monorail]

Status: Started
Owner: hnaka...@chromium.org
CC: sk...@chromium.org
Components: Internals>Flags
OS: Android
Pri: 3
Type: Bug

New issue 1504869 by hnaka...@chromium.org: Move MutableFlagWithSafeDefault to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1504869

Flags are a base concept, but in Java code they have much more support in the Chrome layer.

MutableFlagWithSafeDefault should be moved to the base layer so that components and base can use MutableFlagWithSafeDefault without using hacks.

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[hnakashima via monorail]

Comment #1 on issue 1504869 by hnaka...@chromium.org: Move MutableFlagWithSafeDefault to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1504869#c1

Current state: working on the CL, but it's been non-trivial because of internal code. Will have to do a three-sided patch and disable some flag duplication checking temporarily.

[Git Watcher via monorail]

Comment #2 on issue 1504869 by Git Watcher: Move MutableFlagWithSafeDefault to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1504869#c2

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/c75e452b7ddd108ea3bc6784c31931336a409aee

commit c75e452b7ddd108ea3bc6784c31931336a409aee
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Nov 24 19:29:39 2023

[Android] Declare sCCTTextFragmentLookupAPIEnabled in ChromeFeatureList

MutableFlagWithSafeDefault instance are being centralized in the
FeatureLists.

This is patch 1/3 to move the internal MutableFlagWithSafeDefault
instance upstream

Bug: 1504869
Change-Id: I2364db7388b1ff0b7956fff701203b2403c08f23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054507
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1228867}

[modify] https://crrev.com/c75e452b7ddd108ea3bc6784c31931336a409aee/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/MutableFlagWithSafeDefaultUnitTest.java
[modify] https://crrev.com/c75e452b7ddd108ea3bc6784c31931336a409aee/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FlagUnitTest.java
[modify] https://crrev.com/c75e452b7ddd108ea3bc6784c31931336a409aee/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/c75e452b7ddd108ea3bc6784c31931336a409aee/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagUnitTest.java
[modify] https://crrev.com/c75e452b7ddd108ea3bc6784c31931336a409aee/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/PostNativeFlagUnitTest.java
[modify] https://crrev.com/c75e452b7ddd108ea3bc6784c31931336a409aee/base/android/java/src/org/chromium/base/Flag.java

[Git Watcher via monorail]

Comment #3 on issue 1504869 by Git Watcher: Move MutableFlagWithSafeDefault to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1504869#c3

The following revision refers to this bug:

https://chrome-internal.googlesource.com/clank/internal/apps/+/3a41a8f52121f98d6d64e38578c97b073d698fa8

commit 3a41a8f52121f98d6d64e38578c97b073d698fa8
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Nov 24 18:38:11 2023

[Git Watcher via monorail]

Comment #4 on issue 1504869 by Git Watcher: Move MutableFlagWithSafeDefault to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1504869#c4

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/097692de4a5fcd8621a2f94bd4fa0052f44ae225

commit 097692de4a5fcd8621a2f94bd4fa0052f44ae225
Author: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Date: Fri Nov 24 22:29:39 2023

Roll clank/internal/apps from 02aa7a491dc9 to 3a41a8f52121 (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/02aa7a491dc9..3a41a8f52121

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-bra...@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1504869
Tbr:
No-Try: true
Change-Id: I6d2c722f56afad69e9e16726c0663e3eff59211e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5056897
Commit-Queue: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1228899}

[modify] https://crrev.com/097692de4a5fcd8621a2f94bd4fa0052f44ae225/clank
[modify] https://crrev.com/097692de4a5fcd8621a2f94bd4fa0052f44ae225/DEPS

[Git Watcher via monorail]

Comment #5 on issue 1504869 by Git Watcher: Move MutableFlagWithSafeDefault to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1504869#c5

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/6e173175aa9fa06e7cd6eb25279869709b4f5f68

commit 6e173175aa9fa06e7cd6eb25279869709b4f5f68
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Mon Nov 27 22:32:41 2023

[Android] Move MutableFlagWithSafeDefault to //base

Also move existing instances to ChromeFeatureList like CachedFlags.

This opens up MutableFlagWithSafeDefault to be used by other
FeatureMaps/FeatureLists in components/, ui/, etc.

This is patch 3/3 to move the internal MutableFlagWithSafeDefault
instance upstream.

Bug: 1504869
Change-Id: If9479dc8d1c452bdc6682f0f7391b53161b6089d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5054525
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Reviewed-by: Zaina Al-Mashni <zalm...@google.com>
Owners-Override: Andrew Grieve <agr...@chromium.org>

Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>

Cr-Commit-Position: refs/heads/main@{#1229565}

[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBar.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/flags/BUILD.gn
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[delete] https://crrev.com/c7a608be866422ad9ffc2dc61bfc3c2b9b7898aa/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/MutableFlagWithSafeDefaultUnitTest.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/java/src/org/chromium/chrome/browser/incognito/IncognitoSnapshotController.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/ui/android/omnibox/BUILD.gn
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/java/src/org/chromium/chrome/browser/compositor/CompositorViewHolder.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerTabUtils.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/UrlBarUiUnitTest.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/base/android/java/src/org/chromium/base/FeatureMap.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/base/BUILD.gn
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/quick_delete/android/java/src/org/chromium/chrome/browser/quick_delete/QuickDeleteController.java
[add] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/base/android/junit/src/org/chromium/base/MutableFlagWithSafeDefaultUnitTest.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/base/android/java/src/org/chromium/base/Flag.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkFeatures.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagUnitTest.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/features/start_surface/java/src/org/chromium/chrome/features/tasks/TasksView.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/PostNativeFlagUnitTest.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabThumbnailView.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/voice/VoiceRecognitionUtil.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FlagUnitTest.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabUiFeatureUtilities.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/ToolbarFeatures.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[rename] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/base/android/java/src/org/chromium/base/MutableFlagWithSafeDefault.java
[modify] https://crrev.com/6e173175aa9fa06e7cd6eb25279869709b4f5f68/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/OmniboxFeatures.java

[hnakashima via monorail]

Updates:
Status: Fixed

Comment #6 on issue 1504869 by hnaka...@chromium.org: Move MutableFlagWithSafeDefault to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1504869#c6

(No comment was entered for this change.)