Issue 1366941 in chromium: Cached flags set in fieldtrial_testing_config.json don't work on bots

[hnakashima via monorail]

Updates:
Components: -UI>Browser>Mobile>Start Internals>Flags
Labels: Pri-2 Type-Feature
Owner: ----
Status: Available

Comment #5 on issue 1366941 by hnaka...@chromium.org: Cached flags set in fieldtrial_testing_config.json don't work on bots
https://bugs.chromium.org/p/chromium/issues/detail?id=1366941#c5

That's WAI, but I get that it's something we expect to work for Cached Flags because it works for regular native flags. Changing to Feature Request, putting in triage for 2023. It's a very non-trivial change.

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[hnakashima via monorail]

Comment #6 on issue 1366941 by hnaka...@chromium.org: Cached flags set in fieldtrial_testing_config.json don't work on bots
https://bugs.chromium.org/p/chromium/issues/detail?id=1366941#c6

Looked today with Xi at how to do this, and we need to replicate the generation of https://source.chromium.org/chromium/chromium/src/+/main:out/android-Debug/gen/components/variations/field_trial_config/fieldtrial_testing_config.cc as a .java file, then write logic to use values from that Java file in CachedFlags when the command line has the appropriate switch. It's feasible, but non-trivial.

[peilinwang via monorail]

Updates:
Owner: peili...@google.com
Status: Started

Comment #7 on issue 1366941 by peili...@google.com: Cached flags set in fieldtrial_testing_config.json don't work on bots
https://bugs.chromium.org/p/chromium/issues/detail?id=1366941#c7

(No comment was entered for this change.)

[Git Watcher via monorail]

Comment #8 on issue 1366941 by Git Watcher: Cached flags set in fieldtrial_testing_config.json don't work on bots
https://bugs.chromium.org/p/chromium/issues/detail?id=1366941#c8

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/d58797232610d7dd82f383bedf9e94aeea810968

commit d58797232610d7dd82f383bedf9e94aeea810968
Author: Peilin Wang <peili...@google.com>
Date: Tue Oct 24 20:17:13 2023

[FieldtrialTestingConfig] Generate fieldtrial_testing_config.java

Right now, fieldtrial testing configs can't be read if native is not
loaded, so the configs aren't being used for many tests. To fix this,
we can generate a java file from fieldtrial_testing_config.json so it
can be read without native.

This cl generates a java file very similar to the generated native file.

Future cl's will come to add logic in java to read this file, and to
filter the generated file to consist of only relevant experiments.

Bug: 1366941
Change-Id: I332e0faa2d0ed8b96618a7eab4a0f33969f2a2cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4906146
Commit-Queue: Peilin Wang <peili...@google.com>
Reviewed-by: Nico Weber <tha...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1214421}

[modify] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/android_webview/test/components/run_webview_component_smoketest.pydeps
[modify] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/tools/perf/process_perf_results.pydeps
[modify] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/tools/json_to_struct/json_to_struct.py
[modify] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/components/variations/field_trial_config/field_trial_testing_config_schema.json
[add] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/tools/json_to_struct/class_generator.py
[modify] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/tools/metrics/BUILD.gn
[add] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/tools/json_to_struct/java_element_generator.py
[modify] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/tools/variations/fieldtrial_to_struct.py
[modify] https://crrev.com/d58797232610d7dd82f383bedf9e94aeea810968/components/variations/field_trial_config/BUILD.gn