Issue 1386108 in chromium: Regression: #customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag

[suhasr via monorail]

Status: Untriaged
Owner: ----
CC: nyerr...@chromium.org, susmith...@chromium.org
Labels: Inhouse-HYD-Reported M-110 Target-110 FoundIn-110 RegressedIn-110
Components: Internals>Flags>Expired
OS: Linux Windows Mac
Pri: 2
Type: Bug-Regression

New issue 1386108 by suh...@chromium.org: Regression: #customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag
https://bugs.chromium.org/p/chromium/issues/detail?id=1386108

Chrome Version : 110.0.5425.0 (Official Build) (64-bit) (cohort: Stable)
Revision : 7d6bbec189194f1762a75a9da64f30679984efb2-refs/branch-heads/5425@{#1}

OS: Win(10,11,7), Linux, Mac 11.4

Pre Conditions:

Steps to reproduce:
1. Launch Chrome
2. Navigate to chrome://flags/
3. Type "unified side"

Actual Result :
#customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag

Expected Result :
#customize-chrome-side-panel and #unified-side-panel flags gotto be either expired or unexpired together
as the former flag has got a direct dependency on the latter flag

This is a regression issue, broken in M108, and please find the bisect info below.

Good Build : 109.0.5414.0 (Revision: 1070088)
Bad Build : 110.0.5415.0 (Revision: 1070565)

Please find the screenshots attached below..!

Actual Result:
Attached below

Note:
1. This issue is not repro on Latest Dev #109.0.5414.10, Beta #108.0.5359.48 or on Stable #107.0.5304.107
2. Will provide bisect soon

Thank You

Attachments:
Bad Build.PNG 152 KB
Good Build.PNG 161 KB

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags>Expired

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[ellyjones via monorail]

Updates:
Owner: pb...@chromium.org
Status: Assigned

Comment #1 on issue 1386108 by elly...@chromium.org: Regression: #customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag
https://bugs.chromium.org/p/chromium/issues/detail?id=1386108#c1

That's because #unified-side-panel expired in M109: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/flag-metadata.json;l=6664?q=unified-side-panel%20flag-metadata.json&ss=chromium

[pbos via monorail]

Updates:
Cc: pb...@chromium.org
Owner: cori...@chromium.org

Comment #2 on issue 1386108 by pb...@chromium.org: Regression: #customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag
https://bugs.chromium.org/p/chromium/issues/detail?id=1386108#c2

->corising@ is this being cleaned up so M109 expiry is OK because it's always enabled in 110?

[Git Watcher via monorail]

Comment #3 on issue 1386108 by Git Watcher: Regression: #customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag
https://bugs.chromium.org/p/chromium/issues/detail?id=1386108#c3

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/03344aaad14b2b4bfc62d335d3ba8d70d54e7d50

commit 03344aaad14b2b4bfc62d335d3ba8d70d54e7d50
Author: Caroline Rising <cori...@chromium.org>
Date: Mon Nov 28 21:47:54 2022

Side panel: extend flag expiry while waiting to finish rollout.

Bug: 1270923, 1386108
Change-Id: Iad52cc2afa2806ce92404212a8094e788d0fdbe6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4062112
Reviewed-by: Peter Boström <pb...@chromium.org>
Auto-Submit: Caroline Rising <cori...@chromium.org>
Commit-Queue: Peter Boström <pb...@chromium.org>
Commit-Queue: Caroline Rising <cori...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1076432}

[modify] https://crrev.com/03344aaad14b2b4bfc62d335d3ba8d70d54e7d50/chrome/browser/flag-metadata.json

[suhasr via monorail]

Updates:
Labels: TE-Verified-M110 TE-Verified-110.0.5447.0

Comment #4 on issue 1386108 by suh...@chromium.org: Regression: #customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag
https://bugs.chromium.org/p/chromium/issues/detail?id=1386108#c4

Verified the Fix on OS : Win(10,11), Mac 11.4, Linux using Latest Canary #110.0.5447.0

Observed that, now #customize-chrome-side-panel and #unified-side-panel flags are present under chrome://flags/ without enabling unexpiring flags

Please refer the screenshot attached below.

Fix is working as expected hence adding TE Verified labels

Thanks...!

Attachments:
CL Fix.PNG 132 KB

[corising via monorail]

Updates:
Status: Verified

Comment #5 on issue 1386108 by cori...@chromium.org: Regression: #customize-chrome-side-panel flag is present under chrome://flags/ without #unified-side-panel flag
https://bugs.chromium.org/p/chromium/issues/detail?id=1386108#c5

(No comment was entered for this change.)