Issue 1442353 in chromium: Deduplicate Features annotation processors

[hnakashima via monorail]

Status: Assigned
Owner: hnaka...@chromium.org
Components: Internals>Flags
OS: Android
Pri: 3
Type: Bug

New issue 1442353 by hnaka...@chromium.org: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353

There are currently two Features.java annotation processors:

1. https://source.chromium.org/chromium/chromium/src/+/main:base/test/android/javatests/src/org/chromium/base/test/util/Features.java
2. https://source.chromium.org/chromium/chromium/src/+/main:chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java

This is confusing and the annotations aren't compatible, making it easy to make mistakes using the wrong annotation. We should only have one in base.

The blockers are CachedFlags and FieldTrials (because of CachedFlags).

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[Git Watcher via monorail]

Comment #1 on issue 1442353 by Git Watcher: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c1

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/eff03fda15acbb7f6439559551b6e1beaac0fc61

commit eff03fda15acbb7f6439559551b6e1beaac0fc61
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Mon Jan 15 21:08:29 2024

[Android] Make equal both Features processors in //chrome and //base

Move the CachedFlags and FieldTrials override and resetting logic to
FeaturesBase such that chrome/.../Features.java and
util/.../Features.java are equivalent.

They are not mutually interchangeable so the simplest migration is
to move usages of the //chrome one to the //base one, then delete the
//chrome Features.java.

Bug: 1442353
Change-Id: I4c0393b1172791ad7738dfc8f23dc769166e691c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5194503
Owners-Override: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1247297}

[modify] https://crrev.com/eff03fda15acbb7f6439559551b6e1beaac0fc61/chrome/test/android/BUILD.gn
[modify] https://crrev.com/eff03fda15acbb7f6439559551b6e1beaac0fc61/base/test/android/javatests/src/org/chromium/base/test/util/FeaturesBase.java
[modify] https://crrev.com/eff03fda15acbb7f6439559551b6e1beaac0fc61/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
[modify] https://crrev.com/eff03fda15acbb7f6439559551b6e1beaac0fc61/base/BUILD.gn
[modify] https://crrev.com/eff03fda15acbb7f6439559551b6e1beaac0fc61/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FieldTrialsInstrumentationTest.java
[rename] https://crrev.com/eff03fda15acbb7f6439559551b6e1beaac0fc61/base/test/android/javatests/src/org/chromium/base/test/util/FieldTrials.java

[hnakashima via monorail]

Issue 1442353: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353

This issue is now blocking issue 1335923.
See https://bugs.chromium.org/p/chromium/issues/detail?id=1335923

[Git Watcher via monorail]

Comment #3 on issue 1442353 by Git Watcher: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c3

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/89f718992248f964ba2816b55e985337409cf46c

commit 89f718992248f964ba2816b55e985337409cf46c
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Tue Jan 16 18:04:51 2024

[Android] //chrome Features.*Processors honors //base annotations

Make //chrome's Features.JUnitProcessor and
Features.InstrumentationProcessor compatible with both //chrome and
//base Features.EnableFeatures and Features.DisableFeatures.

This forward compatibility allows changing the annotations before the
processor, which is necessary for downstream tests that rely on
InstrumentationProcessor being a default rule in
ChromeJUnit4ClassRunner.

Bug: 1442353
Change-Id: I27ab88df504521364c677a46bb5069f73b65f317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5199306

Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1247595}

[modify] https://crrev.com/89f718992248f964ba2816b55e985337409cf46c/base/test/android/javatests/src/org/chromium/base/test/util/FeaturesBase.java
[modify] https://crrev.com/89f718992248f964ba2816b55e985337409cf46c/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java

[Git Watcher via monorail]

Comment #4 on issue 1442353 by Git Watcher: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c4

The following revision refers to this bug:

https://chrome-internal.googlesource.com/clank/internal/apps/+/b879bfeb6ed72486d693c9e6e3919451afa38b1f

commit b879bfeb6ed72486d693c9e6e3919451afa38b1f
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Mon Jan 15 21:21:29 2024

[Git Watcher via monorail]

Comment #5 on issue 1442353 by Git Watcher: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c5

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/5c9ecaf057b895fa7a9f0c175992cf9f32413f44

commit 5c9ecaf057b895fa7a9f0c175992cf9f32413f44
Author: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Date: Tue Jan 16 21:26:28 2024

Roll clank/internal/apps from 18c63109ad4f to b879bfeb6ed7 (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/18c63109ad4f..b879bfeb6ed7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-bra...@google.com,ne...@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1442353
Tbr: ne...@google.com
No-Try: true
Change-Id: I6fbbe6e3a85d0eea57cdae814ba484d947f54d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5202214
Bot-Commit: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1247738}

[modify] https://crrev.com/5c9ecaf057b895fa7a9f0c175992cf9f32413f44/clank
[modify] https://crrev.com/5c9ecaf057b895fa7a9f0c175992cf9f32413f44/DEPS

[Git Watcher via monorail]

Comment #6 on issue 1442353 by Git Watcher: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c6

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/b4491b9c8233b6a8465372de0b10d1016a447f1c

commit b4491b9c8233b6a8465372de0b10d1016a447f1c
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Thu Jan 18 20:46:28 2024

[Android] Use Features annotations from //base

The //chrome version is being moved to //base. Migrate usages to
reference the //base Features.JUnitProcessor and
.InstrumentationProcessor, along with @EnableFeatures and
@DisableFeatures.

Mark the //chrome Features as deprecated, soon to be removed.

Bug: 1442353
Change-Id: Id76cdec75237b9437468fece7d3c8e45388af193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5199091
Reviewed-by: Andrew Grieve <agr...@chromium.org>

Owners-Override: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1249015}

[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/IncognitoNewTabPageTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/autofill/internal/java/src/org/chromium/chrome/browser/ui/autofill/AutofillProgressDialogBridgeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/signin/junit/src/org/chromium/chrome/browser/ui/signin/SyncPromoControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/content/EngagementSignalsHandlerUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/page_info/PageInfoViewTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/sections/SectionHeaderViewTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/content/RealtimeEngagementSignalObserverUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/video/FullscreenVideoTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/VoiceToolbarButtonControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeaderUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabSuggestionMessageCardTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/PwaRestoreBottomSheetIntegrationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/compositor/scene_layer/TabStripSceneLayerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/commerce/subscriptions/test/android/java/src/org/chromium/chrome/browser/subscriptions/ImplicitPriceDropSubscriptionsManagerUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/survey/ChromeStartupSurveyIntegrationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/start_surface/javatests/src/org/chromium/chrome/features/start_surface/InstantStartTabSwitcherTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/data_sharing/android/java/src/org/chromium/chrome/browser/data_sharing/DataSharingServiceFactoryTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/ToolbarTabletUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/banners/android/java/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/adaptive/AdaptiveButtonActionMenuCoordinatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/quick_delete/android/javatests/src/org/chromium/chrome/browser/quick_delete/QuickDeleteDialogDelegateTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/suggestions/TabContextTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabPrivacySandboxDialogTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/features/partialcustomtab/PartialCustomTabDisplayManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/toolbar/java/src/org/chromium/chrome/browser/toolbar/top/TopToolbarOverlayMediatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherThumbnailTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninCheckerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/toolbar/top/StartSurfaceToolbarMediatorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripLayoutHelperManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/javascript/CloseWatcherTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/app/bookmarks/BookmarkTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/start_surface/javatests/src/org/chromium/chrome/features/start_surface/StartSurfaceNoTabsTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/RevampedIncognitoNewTabPageTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/keyboard_accessory/junit/src/org/chromium/chrome/browser/keyboard_accessory/sheet_tabs/AddressAccessorySheetControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/all_passwords_bottom_sheet/AllPasswordsBottomSheetViewTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkInstallNotificationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/segmentation_platform/ContextualPageActionControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/answer/AnswerSuggestionProcessorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/tab/state/ShoppingPersistedTabDataDeferredStartupTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/IncognitoCustomTabSnapshotControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/commerce/merchant_viewer/android/javatests/src/org/chromium/chrome/browser/merchant_viewer/MerchantTrustMessageContextTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadLocationChangeEnd2EndTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/carousel/BaseCarouselSuggestionViewBinderUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/locale/LocaleManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/pseudotab/PseudoTabUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkSearchBoxRowRenderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/sheet_tabs/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FieldTrialsInstrumentationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/site_settings/CookieControlsBridgeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/subresource_filter/SubresourceFilterTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/autofill/internal/java/src/org/chromium/chrome/browser/ui/autofill/AuthenticatorSelectionDialogTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/homepage/HomepageManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/safety_check/android/javatests/src/org/chromium/chrome/browser/safety_check/SafetyCheckMediatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/compositor/layouts/StaticLayoutUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkToolbarTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/download/dialogs/DownloadDialogIncognitoTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/night_mode/java/src/org/chromium/chrome/browser/night_mode/AutoDarkFeedbackSourceUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/TabSwitcherMediatorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGridAccessibilityHelperTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/paint_preview/android/javatests/src/org/chromium/chrome/browser/paint_preview/DemoPaintPreviewTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/action/OmniboxActionDelegateImplUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/selection/android/java/src/org/chromium/chrome/browser/selection/SelectionPopupBackPressTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/NavigateTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/commerce/merchant_viewer/android/javatests/src/org/chromium/chrome/browser/merchant_viewer/MerchantTrustSignalsStorageFactoryTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/settings/AutofillProfilesFragmentTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/start_surface/junit/src/org/chromium/chrome/features/start_surface/StartSurfaceMediatorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/tab/state/ShoppingPersistedTabDataTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/status/StatusMediatorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/ImprovedBookmarkQueryHandlerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/toolbar/ToolbarTabControllerImplTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/features/minimizedcustomtab/CustomTabMinimizationManagerUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/content/CustomTabActivityTabControllerUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/fullscreen/FullscreenHtmlApiHandlerLegacyUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionUpdateMessageTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/touch_to_fill/autofill/android/internal/java/src/org/chromium/chrome/browser/touch_to_fill/payments/TouchToFillCreditCardControllerRobolectricTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInstrumentationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SyncConsentFragmentTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/start_surface/javatests/src/org/chromium/chrome/features/start_surface/StartSurfaceTabSwitcherTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/settings/MainSettingsFragmentTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappDisplayModeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/CustomTabsOpenTimeRecorderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/password_manager/android/junit/src/org/chromium/chrome/browser/password_manager/PasswordSyncControllerDelegateBridgeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/payments/AddressEditorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/night_mode/java/src/org/chromium/chrome/browser/night_mode/WebContentsDarkModeMessageControllerUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabListEditorMenuTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProviderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/suggestions/TabSuggestionTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/OmniboxSuggestionsDropdownEmbedderImplTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/password_check/android/junit/src/org/chromium/chrome/browser/password_check/PasswordCheckControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/compositor/overlays/strip/TabStripTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/password_check/android/javatests/src/org/chromium/chrome/browser/password_check/PasswordCheckIntegrationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSystemTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/features/toolbar/CustomTabToolbarUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/signin/SigninManagerImplTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuHeaderMediatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/keyboard_accessory/javatests/src/org/chromium/chrome/browser/keyboard_accessory/sheet_component/AccessorySheetRenderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/touch_to_fill/password_manager/android/javatests/src/org/chromium/chrome/browser/touch_to_fill/TouchToFillRenderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/feedmanagement/FeedManagementCoordinatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureListInstrumentationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/fullscreen/BrowserControlsManagerUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/BookmarkImageFetcherTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/ReaderModeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/password_manager/android/junit/src/org/chromium/chrome/browser/password_manager/PasswordSettingsUpdaterDispatcherBridgeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/LaunchesWithColorSchemeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/history/HistoryUITest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/site_settings/SingleWebsiteSettingsTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/FeaturesAnnotationsTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/status_indicator/StatusIndicatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/settings/SettingsActivityUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/DropdownItemViewInfoListBuilderUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/tile/MostVisitedTilesLayoutTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/commerce/merchant_viewer/android/javatests/src/org/chromium/chrome/browser/merchant_viewer/MerchantTrustMessageSchedulerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/IntentHandlerRobolectricTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/autofill/internal/java/src/org/chromium/chrome/browser/ui/autofill/AuthenticatorSelectionDialogBridgeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/settings/AutofillLocalCardEditorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/SelectableTabListEditorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/keyboard_accessory/junit/src/org/chromium/chrome/browser/keyboard_accessory/sheet_tabs/CreditCardAccessorySheetControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeActivityTestRule.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/LocationBarTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/findinpage/FindTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGridIphTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/autofill/android/javatest/src/org/chromium/chrome/browser/autofill/editors/AddressEditorRenderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/base/BaseSuggestionViewTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/features/partialcustomtab/PartialCustomTabFullSizeStrategyTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkSearchBoxRowTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/site_settings/WebsitePermissionsFetcherTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/webfeed/WebFeedSnackbarControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/app/tabmodel/TabPersistentStoreIntegrationTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/features/minimizedcustomtab/MinimizedCustomTabIPHControllerUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/PopupTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/password_manager/settings/PasswordSettingsExportTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/tab_group/DEPS
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/incognito/IncognitoTabLauncherTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/features/partialcustomtab/PartialCustomTabBottomSheetStrategyTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/TabGridDialogMediatorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/safe_browsing/android/javatests/src/org/chromium/chrome/browser/safe_browsing/settings/EnhancedProtectionSettingsFragmentTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/base/BaseSuggestionProcessorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/permissions/PermissionPromptRenderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/base/SuggestionLayoutUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/search_engines/settings/SearchEngineAdapterTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/keyboard_accessory/junit/src/org/chromium/chrome/browser/keyboard_accessory/sheet_tabs/PasswordAccessorySheetControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/background_sync/BackgroundSyncBackgroundTaskSchedulerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/features/partialcustomtab/PartialCustomTabVersionCompatTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/TabGroupTitleEditorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdownUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/safe_browsing/android/javatests/src/org/chromium/chrome/browser/safe_browsing/settings/SafeBrowsingSettingsFragmentTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/BaseCustomTabRootUiCoordinatorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/bookmarks/LegacyBookmarkQueryHandlerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/share/android/javatests/src/org/chromium/chrome/browser/share/scroll_capture/ScrollCaptureCallbackRenderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/autofill/internal/java/src/org/chromium/chrome/browser/ui/autofill/AutofillErrorDialogBridgeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureListWithProcessorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/MessageCardProviderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/commerce/price_tracking/android/javatests/src/org/chromium/chrome/browser/price_tracking/PriceTrackingFeaturesTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/pseudotab/TabAttributeCacheUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/incognito/IncognitoTabbedSnapshotControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/LocationBarMediatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGridPanelViewBinderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/commerce/merchant_viewer/android/javatests/src/org/chromium/chrome/browser/merchant_viewer/MerchantTrustMetricsTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/start_surface/javatests/src/org/chromium/chrome/features/start_surface/StartSurfaceTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/commerce/merchant_viewer/android/javatests/src/org/chromium/chrome/browser/merchant_viewer/MerchantTrustBottomSheetMediatorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/push_messaging/PushMessagingTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/autofill/test/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/page_info/PermissionParamsListBuilderUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkFolderPickerRenderTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/share/android/javatests/src/org/chromium/chrome/browser/share/share_sheet/ShareSheetUsageRankingHelperTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/junit/src/org/chromium/chrome/browser/tasks/tab_management/TabGridViewBinderUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/share/android/javatests/src/org/chromium/chrome/browser/share/screenshot/ScreenshotShareSheetMediatorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/app/tab_activity_glue/ActivityTabWebContentsDelegateAndroidUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHistogramTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxActionsTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/continuous_search/ContinuousSearchFullUiTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/compositor/overlays/strip/StripTabHoverCardViewUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/start_surface/javatests/src/org/chromium/chrome/features/start_surface/StartSurfaceMVTilesTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/autofill/internal/java/src/org/chromium/chrome/browser/ui/autofill/OtpVerificationDialogTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/recent_tabs/internal/android/java/src/org/chromium/chrome/browser/recent_tabs/RestoreTabsTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/app/bookmarks/ReadingListTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/LocationBarModelTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/customtabs/content/CustomTabActivityNavigationControllerTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/junit/src/org/chromium/chrome/browser/feedback/FeedFeedbackCollectorTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/page_info/PageInfoViewDarkModeTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/carousel/BaseCarouselSuggestionProcessorUnitTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistillabilityServiceTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/javatests/src/org/chromium/chrome/browser/privacy/settings/PrivacySettingsFragmentTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/features/tab_ui/javatests/src/org/chromium/chrome/browser/tasks/tab_management/TabGridIncognitoReauthPromoTest.java
[modify] https://crrev.com/b4491b9c8233b6a8465372de0b10d1016a447f1c/chrome/android/fe...--

[Git Watcher via monorail]

Comment #7 on issue 1442353 by Git Watcher: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c7

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/de2b8f81cb3d0963b3587b8864d4f1934ad5c654

commit de2b8f81cb3d0963b3587b8864d4f1934ad5c654
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Mon Jan 22 20:15:27 2024

[Android] Remove //chrome Features annotations and processors

Simplify the Processors' inheritance tree and instance management
back to how it was before splitting the Features into //chrome and
//base.

Bug: 1442353
Change-Id: Id0f365c54720acc0da730f11bacf1bdf29d869f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5218492
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Reviewed-by: Xi Han <ha...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1250381}

[modify] https://crrev.com/de2b8f81cb3d0963b3587b8864d4f1934ad5c654/chrome/test/android/BUILD.gn
[modify] https://crrev.com/de2b8f81cb3d0963b3587b8864d4f1934ad5c654/base/test/android/javatests/src/org/chromium/base/test/util/Features.java
[delete] https://crrev.com/208a54c8034a5ce1f153bbbfbec85e32e304db1f/base/test/android/javatests/src/org/chromium/base/test/util/FeaturesBase.java
[delete] https://crrev.com/208a54c8034a5ce1f153bbbfbec85e32e304db1f/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
[modify] https://crrev.com/de2b8f81cb3d0963b3587b8864d4f1934ad5c654/chrome/browser/magic_stack/android/junit/src/org/chromium/chrome/browser/magic_stack/HomeModulesCoordinatorUnitTest.java
[modify] https://crrev.com/de2b8f81cb3d0963b3587b8864d4f1934ad5c654/chrome/android/java/src/org/chromium/chrome/browser/tab/DEPS
[modify] https://crrev.com/de2b8f81cb3d0963b3587b8864d4f1934ad5c654/chrome/browser/magic_stack/android/junit/src/org/chromium/chrome/browser/magic_stack/HomeModulesMediatorUnitTest.java
[modify] https://crrev.com/de2b8f81cb3d0963b3587b8864d4f1934ad5c654/base/BUILD.gn

[hnakashima via monorail]

Updates:
Cc: ckit...@chromium.org
Status: Fixed

Comment #8 on issue 1442353 by hnaka...@chromium.org: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c8

(No comment was entered for this change.)

[Git Watcher via monorail]

Comment #9 on issue 1442353 by Git Watcher: Deduplicate Features annotation processors
https://bugs.chromium.org/p/chromium/issues/detail?id=1442353#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/e5294cc391188c6d0124e30262d65d88f4ca7c12

commit e5294cc391188c6d0124e30262d65d88f4ca7c12
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Tue Jan 23 07:45:11 2024

[Android] Make Features.enable()/disable() private

These methods are not intended to be a public API.

Bug: 1442353
Change-Id: I4bc71f4654b073c11f4d06627ae244cf8ce4b209
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5225803
Commit-Queue: Jan Keitel <jke...@google.com>
Auto-Submit: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Jan Keitel <jke...@google.com>
Cr-Commit-Position: refs/heads/main@{#1250667}

[modify] https://crrev.com/e5294cc391188c6d0124e30262d65d88f4ca7c12/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupWithKeyboardTest.java
[modify] https://crrev.com/e5294cc391188c6d0124e30262d65d88f4ca7c12/base/test/android/javatests/src/org/chromium/base/test/util/Features.java