Issue 1442347 in chromium: Move CachedFlag to base

[hnakashima via monorail]

Status: Assigned
Owner: hnaka...@chromium.org
Components: Internals>Flags
OS: Android
Pri: 3
Type: Bug

New issue 1442347 by hnaka...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347

Flags are a base concept, but in Java code they have much more support in the Chrome layer.

CachedFlags should be moved to the base layer so that components and base can use CachedFlags without using hacks.

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[hnakashima via monorail]

Updates:
Blockedon: 1069897

Comment #1 on issue 1442347 by hnaka...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c1

(No comment was entered for this change.)

[hnakashima via monorail]

Issue 1442347: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347

This issue is now blocking issue 1335923.
See https://bugs.chromium.org/p/chromium/issues/detail?id=1335923

[hnakashima via monorail]

Issue 1442347: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347

This issue is now blocking issue 1442353.
See https://bugs.chromium.org/p/chromium/issues/detail?id=1442353

[hnakashima via monorail]

Updates:
Blockedon: 1060097

Comment #4 on issue 1442347 by hnaka...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c4

(No comment was entered for this change.)

[Git Watcher via monorail]

Comment #5 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c5

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/4877e5a41e14851b264a1d9c111ad11d69c664cd

commit 4877e5a41e14851b264a1d9c111ad11d69c664cd
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Tue May 16 17:24:43 2023

[Android] Sync CachedFlags declared with listed in ChromeCachedFlags

There are some CachedFlags in ChromeFeatureList which are not listed
in ChromeCachedFlags, which means their value is not cached (but past
cached values are still used, so it may be useful in this corner case
if they were at some point in ChromeCachedFlags).

This CL:
- Cleans up some launched flags that aren't being cached:
- CCTAllowCrossUidActivitySwitchFromBelow
- PartnerHomepageInitialLoadImprovement
- Starts caching a flag that is not currently cached but seems like
it should
- BackGestureRefactorActivityAndroid
- Removes some CachedFlags that were only declared presumably because
they had related cached field trial params (in this case it's not
required to cache the flag itself)
- LensCameraAssistedSearch
- OmahaMinSdkVersionAndroid
- Removes a completely unused CachedFlag
- PrefetchNotificationSchedulingIntegration

-

Bug: 1442347
Change-Id: Ia24480dcbc5f6b23ed02085dd67765de59a66314
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4533145
Reviewed-by: Wenyu Fu <wen...@chromium.org>
Reviewed-by: Lijin Shen <laz...@google.com>
Code-Coverage: Findit <findit...@appspot.gserviceaccount.com>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144795}

[modify] https://crrev.com/4877e5a41e14851b264a1d9c111ad11d69c664cd/chrome/browser/flags/android/chrome_feature_list.h
[modify] https://crrev.com/4877e5a41e14851b264a1d9c111ad11d69c664cd/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/4877e5a41e14851b264a1d9c111ad11d69c664cd/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
[modify] https://crrev.com/4877e5a41e14851b264a1d9c111ad11d69c664cd/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/4877e5a41e14851b264a1d9c111ad11d69c664cd/chrome/browser/flags/android/chrome_feature_list.cc

[skym via monorail]

Updates:
Cc: sk...@chromium.org
Labels: sheriff-android

Comment #6 on issue 1442347 by sk...@google.com: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c6

https://ci.chromium.org/ui/p/chromium/builders/ci/android-12l-x64-dbg-tests/5156/overview failed for test case org.chromium.chrome.browser.partnercustomizations.PartnerDisableIncognitoModeUnitTest#testParentalControlsProviderDelayed

java.util.ConcurrentModificationException
at java.util.ArrayList$Itr.next(ArrayList.java:860)
at org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations$1.onFinalized(PartnerBrowserCustomizations.java:246)
at org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations$1.onPostExecute(PartnerBrowserCustomizations.java:229)
at org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomizations$1.onPostExecute(PartnerBrowserCustomizations.java:190)
at org.chromium.base.task.AsyncTask.finish(AsyncTask.java:455)
at org.chromium.base.task.AsyncTask.lambda$postResult$1$org-chromium-base-task-AsyncTask(AsyncTask.java:147)
at org.chromium.base.task.AsyncTask$$ExternalSyntheticLambda0.run(Unknown Source:4)
at org.chromium.base.task.TaskRunnerImpl.runPreNativeTask(TaskRunnerImpl.java:248)
at org.chromium.base.task.TaskRunnerImpl$$ExternalSyntheticLambda0.run(Unknown Source:2)
at android.os.Handler.handleCallback(Handler.java:938)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7870)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

Of which https://crrev.com/c/4533145 is in the blame list.

[Git Watcher via monorail]

Comment #7 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c7

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/870c206040349fa3011cb4ab54a41dadbee188a8

commit 870c206040349fa3011cb4ab54a41dadbee188a8
Author: Sky Malice <sk...@chromium.org>
Date: Tue May 16 19:56:04 2023

Revert "[Android] Sync CachedFlags declared with listed in ChromeCachedFlags"

This reverts commit 4877e5a41e14851b264a1d9c111ad11d69c664cd.

Reason for revert: Speculative revert for testParentalControlsProviderDelayed test failure

Original change's description:

Bug: 1442347
Change-Id: If4c019c67b6188285f23f4278a0b9eec388a94bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4540267
Auto-Submit: Sky Malice <sk...@chromium.org>
Owners-Override: Sky Malice <sk...@chromium.org>
Reviewed-by: Tomasz Wiszkowski <en...@google.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Tomasz Wiszkowski <en...@google.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1144861}

[modify] https://crrev.com/870c206040349fa3011cb4ab54a41dadbee188a8/chrome/browser/flags/android/chrome_feature_list.h
[modify] https://crrev.com/870c206040349fa3011cb4ab54a41dadbee188a8/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/870c206040349fa3011cb4ab54a41dadbee188a8/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
[modify] https://crrev.com/870c206040349fa3011cb4ab54a41dadbee188a8/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/870c206040349fa3011cb4ab54a41dadbee188a8/chrome/browser/flags/android/chrome_feature_list.cc

[skym via monorail]

Comment #8 on issue 1442347 by sk...@google.com: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c8

Henrique pointed out this test case from comment#6 was already flaky, moved the tracking of it to issue 1446093.

[Git Watcher via monorail]

Comment #9 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c9

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/3a56615ddbed70666c8320b8daff191dadfaabc7

commit 3a56615ddbed70666c8320b8daff191dadfaabc7
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Tue May 16 21:43:01 2023

Reland "[Android] Sync CachedFlags declared with listed in ChromeCachedFlags"

This is a reland of commit 4877e5a41e14851b264a1d9c111ad11d69c664cd

Test case for revert was already flaky. Not this CL's fault.

Change-Id: Ic85f22e51c659b02f44d1b2e1bb89e58019c9599
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4540021
Owners-Override: Sky Malice <sk...@chromium.org>
Auto-Submit: Sky Malice <sk...@chromium.org>
Reviewed-by: Henrique Nakashima <hnaka...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Commit-Queue: Sky Malice <sk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1144944}

[modify] https://crrev.com/3a56615ddbed70666c8320b8daff191dadfaabc7/chrome/browser/flags/android/chrome_feature_list.h
[modify] https://crrev.com/3a56615ddbed70666c8320b8daff191dadfaabc7/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/3a56615ddbed70666c8320b8daff191dadfaabc7/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
[modify] https://crrev.com/3a56615ddbed70666c8320b8daff191dadfaabc7/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/3a56615ddbed70666c8320b8daff191dadfaabc7/chrome/browser/flags/android/chrome_feature_list.cc

[Git Watcher via monorail]

Comment #11 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c11

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/1ce30b46f0d225c5063d0db14d423df8d8ea230e

commit 1ce30b46f0d225c5063d0db14d423df8d8ea230e
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Wed May 17 16:15:03 2023

[Android] Move lists of CachedFlags from ChromeCachedFlags

ChromeFeatureList now contains the lists of CachedFlags (and the
CachedFlags themselves).

It is necessary to have a list of all CachedFlags in
ChromeFeatureList, since we need to map the feature name to the
legacy shared preference key in the CachedFlag when:
1. Setting up test values via @EnableFeatures/@DisableFeatures
* Currently done through CachedFeatureFlags#setForTesting, but
requires CachedFeatureFlags to know legacy SharedPrefs key
overrides, which blocks its migration to //base.
2. Called via Java_CachedFeatureFlags_IsEnabled()
* Currently uses the default from native passed as a param through
JNI.

This also adds a test to ensure flags aren't declared and not cached,
which is a common pitfall.

Bug: 1442347
Change-Id: I24092289f438fcc367d9c51a8cb1d7d85e54c5a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4540276
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1145394}

[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/chrome/browser/flags/BUILD.gn
[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/chrome/browser/flags/android/cached_feature_flags.cc
[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureListWithProcessorUnitTest.java
[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlag.java
[modify] https://crrev.com/1ce30b46f0d225c5063d0db14d423df8d8ea230e/base/android/java/src/org/chromium/base/Flag.java

[Git Watcher via monorail]

Comment #12 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c12

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/152b78a87123e24b787abcdf7c39105c306bf481

commit 152b78a87123e24b787abcdf7c39105c306bf481
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri May 19 18:05:22 2023

[Android] Move legacy SharedPrefs map out of CachedFeatureFlags

The mapping is now in the CachedFlags themselves for the few that are
from 2019 or older and still use a legacy pref key.

This is a step to move CachedFlag into //base as the legacy preference
keys are Chrome-specific, so they need to remain somewhere in
//chrome as opposed to the generic code in CachedFlag and
CachedFeatureFlags that will get moved down to //base.

Disable-Rts: True
Bug: 1442347
Change-Id: I029816a098ab02fb000d8f64e3e8817598e65636
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4500337

Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>

Code-Coverage: Findit <findit...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1146590}

[modify] https://crrev.com/152b78a87123e24b787abcdf7c39105c306bf481/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/152b78a87123e24b787abcdf7c39105c306bf481/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/152b78a87123e24b787abcdf7c39105c306bf481/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlag.java

[Git Watcher via monorail]

Comment #13 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c13

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/5a72c3488530e37470fcd405015269524a74b1a8

commit 5a72c3488530e37470fcd405015269524a74b1a8
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri May 19 21:11:59 2023

[Android] Move code from CachedFeatureFlags to CachedFlag

Move static methods from CachedFeatureFlags to be instance methods in
CachedFlag. This makes CachedFlag more cohesive and separates it from
CachedFeatureFlags code that concerns field trials or special-cased
flags.

This is a step to move CachedFlag to //base.

Disable-Rts: True
Bug: 1442347
Change-Id: Ic18de98a6475ada089a0d32ce7057286f7f72bf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4529355
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Code-Coverage: Findit <findit...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1146713}

[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFieldTrialParameterUnitTest.java
[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagsSafeMode.java
[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/pseudotab/PseudoTab.java
[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ValuesReturned.java
[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/android/expectations/lint-baseline.xml
[modify] https://crrev.com/5a72c3488530e37470fcd405015269524a74b1a8/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlag.java

[ntfschr via monorail]

Updates:
Labels: -sheriff-android

Comment #14 on issue 1442347 by ntf...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c14

Build gardener (formerly known as sheriff) update. I think the test failure has been resolved so this no longer requires build gardener attention. Please add the label if appropriate.

[Git Watcher via monorail]

Comment #15 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c15

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/e69c57557d83852c45407913dd6b120ab0f5ccb7

commit e69c57557d83852c45407913dd6b120ab0f5ccb7
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Tue Aug 22 20:35:58 2023

[Android] Cleanup caching of WarmUpNetworkProcess

WarmUpNetworkProcess has been stagnant since 2020, so clean up the
caching of the flag. We can make it a proper CachedFlag if
eventually we decide to enable this again.

This removes a blocker of the migration of CachedFlag from //chrome to
//base.

Bug: 932566,1442347
Change-Id: Ic45ef4ab4d36f2482d9deaf8f6c434fef31f0631
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4775894
Reviewed-by: Clark DuVall <cdu...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Michael Thiessen <mthi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1186787}

[modify] https://crrev.com/e69c57557d83852c45407913dd6b120ab0f5ccb7/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/e69c57557d83852c45407913dd6b120ab0f5ccb7/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/DeprecatedChromePreferenceKeys.java
[modify] https://crrev.com/e69c57557d83852c45407913dd6b120ab0f5ccb7/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/LegacyChromePreferenceKeys.java
[modify] https://crrev.com/e69c57557d83852c45407913dd6b120ab0f5ccb7/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
[modify] https://crrev.com/e69c57557d83852c45407913dd6b120ab0f5ccb7/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitTaskRunner.java
[modify] https://crrev.com/e69c57557d83852c45407913dd6b120ab0f5ccb7/chrome/browser/flags/android/cached_feature_flags.cc

[Git Watcher via monorail]

Comment #16 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c16

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/7050b773a137c4c2671f545d0847d6263c278e6a

commit 7050b773a137c4c2671f545d0847d6263c278e6a
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Aug 25 19:26:27 2023

[Android] Move cacheAdditionalNativeFlags() to ChromeCachedFlags

Also move native bridge from CachedFeatureFlags to ChromeCachedFlags.

CachedFeatureFlags is being emptied out to be removed.

This CL moves Chrome-specific code from CachedFeatureFlags to
ChromeCachedFlags. Generic code from CachedFeatureFlags is getting
moved from CachedFeatureFlag to CachedFlag (so CachedFlag can be moved
to //base).

Bug: 1442347
Change-Id: Ia537ea7740c69bd35d1d7e1c26466534806cf9f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4774604
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Reviewed-by: David Trainor <dtra...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1188466}

[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/flags/BUILD.gn
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/download/android/download_manager_service.cc
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/chrome_browser_field_trials.cc
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/android/BUILD.gn
[rename] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/android/flags/chrome_cached_flags.cc
[rename] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/android/flags/chrome_cached_flags.h
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagsSafeMode.java
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/notifications/notification_permission_context.cc
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlagsSafeModeUnitTest.java
[modify] https://crrev.com/7050b773a137c4c2671f545d0847d6263c278e6a/chrome/browser/BUILD.gn

[Git Watcher via monorail]

Comment #17 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c17

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202

commit 1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Mon Aug 28 19:32:35 2023

[Android] Move cacheMinimalBrowserFlagsTimeFromNativeTime()

Move cacheMinimalBrowserFlagsTimeFromNativeTime() from
CachedFeatureFlags to ChromeCachedFlags. This is an app-level value,
so belongs to ChromeCached flags rather than CachedFlag (which will be
moved to //base).

This is CL 1/3 in a 3-step migration with downstream.

Bug: 1442347
Change-Id: I29d7afffe3568b833dbbc807a4041299a35231d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4774782
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: David Trainor <dtra...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1189109}

[rename] https://crrev.com/1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202/chrome/android/junit/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlagsUnitTest.java
[modify] https://crrev.com/1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202/chrome/browser/flags/BUILD.gn
[modify] https://crrev.com/1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202/chrome/android/chrome_junit_test_java_sources.gni
[modify] https://crrev.com/1468c987b2dab8dd6b8aa8a4c7b14aefd13cf202/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FieldTrialsInstrumentationTest.java

[Git Watcher via monorail]

Comment #18 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c18

The following revision refers to this bug:

https://chrome-internal.googlesource.com/clank/internal/apps/+/5aaf4a1289be810768dd3d0ab3b88f4cbaf816d1

commit 5aaf4a1289be810768dd3d0ab3b88f4cbaf816d1
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Aug 11 20:45:16 2023

[Git Watcher via monorail]

Comment #19 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c19

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/8214e911c4048a14a607869f0fe7c07df2b68a63

commit 8214e911c4048a14a607869f0fe7c07df2b68a63
Author: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Date: Mon Sep 11 20:27:13 2023

Roll clank/internal/apps from b579c0e31825 to 5aaf4a1289be (1 revision)

https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/b579c0e31825..5aaf4a1289be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-bra...@google.com,peili...@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1442347
Tbr: peili...@google.com
No-Try: true
Change-Id: I1a284766c4845d2ccd61478cbe48b6cd695c2ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4857033
Commit-Queue: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-inte...@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1195025}

[modify] https://crrev.com/8214e911c4048a14a607869f0fe7c07df2b68a63/clank
[modify] https://crrev.com/8214e911c4048a14a607869f0fe7c07df2b68a63/DEPS

[Git Watcher via monorail]

Comment #21 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c21

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/d6972b4067b37b7fcbd99e5efe7519ea3f729814

commit d6972b4067b37b7fcbd99e5efe7519ea3f729814
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Tue Sep 12 19:04:36 2023

[Android] Cleanup cacheMinimalBrowserFlagsTimeFromNativeTime

Just inline cacheMinimalBrowserFlagsTimeFromNativeTime() from
CachedFeatureFlags into ChromeCachedFlags. Also inline
getLastCachedMinimalBrowserFlagsTimeMillis().

This is CL 3/3 in a 3-step migration with downstream.

Bug: 1442347
Change-Id: Ie81a30d9dafc38b4062d200368a744655ba26cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4859821
Auto-Submit: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Michael Thiessen <mthi...@chromium.org>
Commit-Queue: Michael Thiessen <mthi...@chromium.org>

Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1195547}

[modify] https://crrev.com/d6972b4067b37b7fcbd99e5efe7519ea3f729814/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/d6972b4067b37b7fcbd99e5efe7519ea3f729814/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java

[Git Watcher via monorail]

Comment #22 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c22

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/6eac3f2f1561f20425a43522f38d5c33100488ce

commit 6eac3f2f1561f20425a43522f38d5c33100488ce
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Wed Sep 13 18:40:03 2023

[Android] Inline + remove getConsistent*Value() from CachedFeatureFlags

These methods are only used and effectively the logic of
CachedFieldTrialParameters, so move them there.

CachedFeatureFlags is being cleared out so caching can be moved to
//base.

Bug: 1442347,1481249
Change-Id: Ic1928945996dd10c6ee76b133f970cab6e694b03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4860421
Reviewed-by: Michael Thiessen <mthi...@chromium.org>

Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1196155}

[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/BooleanCachedFieldTrialParameter.java
[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/DoubleCachedFieldTrialParameter.java
[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFieldTrialParameter.java
[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/android/features/tab_ui/public/android/java/src/org/chromium/chrome/browser/tasks/tab_management/TabUiThemeUtil.java
[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/StringCachedFieldTrialParameter.java
[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/IntCachedFieldTrialParameter.java
[modify] https://crrev.com/6eac3f2f1561f20425a43522f38d5c33100488ce/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/AllCachedFieldTrialParameters.java

[Git Watcher via monorail]

Comment #24 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c24

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3

commit 2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Sep 29 19:28:23 2023

[Android] Inline methods from CachedFeatureFlags

CachedFeatureFlags's logic is being distributed to other classes. It
is meant to be deleted soon.

Also move the header comment of CachedFeatureFlags since now
it should not be referenced very often, and move the header to
CachedFlag, now the main class for CachedFlags.

Bug: 1442347,1487364
Change-Id: Id1c20a948967ceb3164a38c74dd0eef286c678f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4860422
Reviewed-by: Shakti Sahu <shakt...@chromium.org>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Reviewed-by: Michael Thiessen <mthi...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1203404}

[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/FieldTrials.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagsSafeMode.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlags.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlagsSafeModeUnitTest.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/android/junit/src/org/chromium/chrome/browser/download/service/DownloadBackgroundTaskTest.java
[modify] https://crrev.com/2756f4e9bd6dbe32130c400a09d8f6ee0910a3e3/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlag.java

[Git Watcher via monorail]

Comment #25 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c25

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/c14513ae6e993de6eae5549c1ed60c6b85c6c87e

commit c14513ae6e993de6eae5549c1ed60c6b85c6c87e
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Sep 29 23:59:35 2023

[Android] Rename CachedFeatureFlags to CachedFlagUtils

This class used to contain most of the CachedFlag logic, but now
it's just some convenience methods as the generic logic has been
moved to CachedFlag and the app-layer logic to ChromeCachedFlags.

Bug: 1442347
Change-Id: Ib4a3d41876b73108ff124404c6a23dc168b0ed47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4899236

Reviewed-by: Michael Thiessen <mthi...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>

Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1203543}

[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/FieldTrials.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFieldTrialParameterUnitTest.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagsSafeMode.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/BUILD.gn
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/BaseFlagTestRule.java
[rename] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagUtils.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagUnitTest.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlagsSafeModeUnitTest.java
[modify] https://crrev.com/c14513ae6e993de6eae5549c1ed60c6b85c6c87e/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlagsAnnotationUnitTest.java

[hnakashima via monorail]

Updates:
Blockedon: -1060097 1483469

Comment #26 on issue 1442347 by hnaka...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c26

(No comment was entered for this change.)

[hnakashima via monorail]

Updates:
Blockedon: -1069897

Comment #27 on issue 1442347 by hnaka...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c27

[hnakashima via monorail]

Updates:
Blockedon: 1060097

Comment #28 on issue 1442347 by hnaka...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c28

[Git Watcher via monorail]

Comment #29 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c29

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/94a3b22f21f441e3ec1299f9205e608907dba10c

commit 94a3b22f21f441e3ec1299f9205e608907dba10c
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Tue Jan 02 20:29:45 2024

[Android] De-localize "Developer Build" string in version_info

This is a developer-only string and in other places it's not
localized. Removing this dependency simplifies the code and allows
it to be moved to //base without setting up localization in //base.

Bug: 1442347
Change-Id: Ib755acea4f9830c95be565c4297cff63af846330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5142266
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Ted Choc <ted...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1242105}

[modify] https://crrev.com/94a3b22f21f441e3ec1299f9205e608907dba10c/components/version_info/BUILD.gn
[modify] https://crrev.com/94a3b22f21f441e3ec1299f9205e608907dba10c/components/version_info/version_string.cc

[Git Watcher via monorail]

Comment #31 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c31

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/bd0644c6efe324506e382abd2ca4b620b7fc6f40

commit bd0644c6efe324506e382abd2ca4b620b7fc6f40
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Thu Jan 11 20:16:55 2024

[Android] CachedFlag does not search for instance to set test override

Previously, some CachedFlags has legacy shared preference keys that were
not generated by a KeyPrefix, so we needed to search the list of
existing CachedFlags to find if it was ones of those when setting test
overrides (which are keyed by the shared preferences key).

After crbug.com/1446352 got fixed, all keys are now generated by the
prefix and we can sever this dependency from CachedFlag to
ChromeFeatureList to prepare it to be moved to //base.

Bug: 1442347
Change-Id: I305d79c41d8146957c79a9103a75f010a287516d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5185865

Reviewed-by: Michael Thiessen <mthi...@chromium.org>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>

Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246034}

[modify] https://crrev.com/bd0644c6efe324506e382abd2ca4b620b7fc6f40/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlag.java

[Git Watcher via monorail]

Comment #32 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c32

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/814448322ca6ac7e92eb0d1730dcd91a711dfcd6

commit 814448322ca6ac7e92eb0d1730dcd91a711dfcd6
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Jan 12 18:10:16 2024

[Android] Move more keys to CachedFlagsSharedPreferences

CachedFlag, CachedFlagsSafeMode and CachedFieldTrialParameters are
being moved to //base. Break the rest of the dependencies from them to ChromeSharedPreferences.

Bug: 1442347
Change-Id: Ia184160931e7f0f058fb3a2ff259fe924f06112d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5190444
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1246539}

[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/BooleanCachedFieldTrialParameter.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagsSafeMode.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/DoubleCachedFieldTrialParameter.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFieldTrialParameter.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/base/android/java/src/org/chromium/base/cached_flags/CachedFlagsSharedPreferences.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/StringCachedFieldTrialParameter.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/AllCachedFieldTrialParameters.java
[modify] https://crrev.com/814448322ca6ac7e92eb0d1730dcd91a711dfcd6/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/IntCachedFieldTrialParameter.java

[Git Watcher via monorail]

Comment #33 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c33

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/c98bc01fc496a5011e9b6088efab06cdcc11bf74

commit c98bc01fc496a5011e9b6088efab06cdcc11bf74
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Fri Jan 12 21:12:15 2024

[Android] Remove dependencies from Flag subclasses to ChromeFeatureList

CachedFlag and PostNativeFlag should work with any FeatureMap,
thus they should take the FeatureMap instance as a constructor
parameter.

Bug: 1442347
Change-Id: I5f77c24b382b782488b1f1cf13904fe2708587d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5186596
Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>
Reviewed-by: Brandon Fong <bjf...@google.com>
Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1246665}

[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/PostNativeFlag.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FlagUnitTest.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/BaseFlagTestRule.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/recent_tabs/android/java/src/org/chromium/chrome/browser/recent_tabs/RestoreTabsFeatureHelper.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/base/android/java/src/org/chromium/base/MutableFlagWithSafeDefault.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlagsSafeModeUnitTest.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlagUnitTest.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/PostNativeFlagUnitTest.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/base/android/java/src/org/chromium/base/Flag.java
[modify] https://crrev.com/c98bc01fc496a5011e9b6088efab06cdcc11bf74/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFlag.java

[Git Watcher via monorail]

Comment #34 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c34

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/180fa05bfc1bb421077f1b77c980c6835be19461

commit 180fa05bfc1bb421077f1b77c980c6835be19461
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Mon Jan 15 15:30:47 2024

[Android] Remove dependencies from CachedFieldTrialParameters to chrome

CachedFieldTrialParameters and subclasses were
ChromeFeatureList-specific, but after the FeatureMap refactor they can
be used with other FeatureMaps too.

This change is analogous to https://crrev.com/c/5186596 which makes
this change for CachedFlag.

Bug: 1442347
Change-Id: Ib7b13122e8e10bebde68e58e5ee40ec1cd864be6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5193147

Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Reviewed-by: Andrew Grieve <agr...@chromium.org>

Owners-Override: Andrew Grieve <agr...@chromium.org>
Commit-Queue: Andrew Grieve <agr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1247173}

[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/state/ShoppingPersistedTabDataService.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/DoubleCachedFieldTrialParameter.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/hub/android/java/src/org/chromium/chrome/browser/hub/HubFieldTrial.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/java/src/org/chromium/chrome/browser/customtabs/features/minimizedcustomtab/MinimizedFeatureUtils.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/back_press/android/java/src/org/chromium/chrome/browser/back_press/MinimizeAppAndCloseTabBackPressHandler.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/back_press/android/java/src/org/chromium/chrome/browser/back_press/BackPressManager.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/BooleanCachedFieldTrialParameter.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFieldTrialParameterUnitTest.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/features/start_surface/java/src/org/chromium/chrome/features/start_surface/StartSurfaceConfiguration.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/FeedPlaceholderLayout.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/notifications/chime/android/java/src/org/chromium/chrome/browser/notifications/chime/ChimeFeatures.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/features/tab_ui/public/android/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementFieldTrial.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/java/src/org/chromium/chrome/browser/new_tab_url/DseNewTabUrlManager.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/optimization_guide/android/java/src/org/chromium/chrome/browser/optimization_guide/OptimizationGuidePushNotificationManager.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/recent_tabs/android/java/src/org/chromium/chrome/browser/recent_tabs/RestoreTabsFeatureHelper.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/StringCachedFieldTrialParameter.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/IntCachedFieldTrialParameter.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FieldTrialsInstrumentationTest.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFieldTrialParameter.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabUiFeatureUtilities.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlagsSafeModeUnitTest.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/OmniboxFeatures.java
[modify] https://crrev.com/180fa05bfc1bb421077f1b77c980c6835be19461/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/AllCachedFieldTrialParameters.java

[Git Watcher via monorail]

Comment #35 on issue 1442347 by Git Watcher: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c35

The following revision refers to this bug:

https://chromium.googlesource.com/chromium/src/+/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5

commit db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5
Author: Henrique Nakashima <hnaka...@chromium.org>
Date: Mon Jan 15 18:58:51 2024

[Android] Move CachedFlag and CachedFieldTrialParameter to //base

Move all generic flags classes, including CachedFlag, PostNativeFlag,
CachedFieldTrialParameter and subclasses to //base/cached_flags, along
with tests.

Bug: 1442347
Change-Id: I629933d48474b343598c49410520e946b8f4f489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5193149

Commit-Queue: Henrique Nakashima <hnaka...@chromium.org>
Reviewed-by: Andrew Grieve <agr...@chromium.org>

Code-Coverage: findit...@appspot.gserviceaccount.com <findit...@appspot.gserviceaccount.com>
Owners-Override: Andrew Grieve <agr...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1247258}

[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/IntCachedFieldTrialParameter.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/hub/android/java/src/org/chromium/chrome/browser/hub/HubFieldTrial.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlags.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/StringCachedFieldTrialParameter.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/CachedFlag.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/recent_tabs/internal/android/java/src/org/chromium/chrome/browser/recent_tabs/RestoreTabsMediatorUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/back_press/android/java/src/org/chromium/chrome/browser/back_press/BackPressManager.java
[add] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/DIR_METADATA
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/tasks/ReturnToChromeUtil.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/CachedFlagUtils.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/notifications/chime/android/java/src/org/chromium/chrome/browser/notifications/chime/ChimeFeatures.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/BUILD.gn
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/ValuesReturned.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/new_tab_url/DseNewTabUrlManager.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubPaneHostMediatorUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/optimization_guide/android/java/src/org/chromium/chrome/browser/optimization_guide/OptimizationGuidePushNotificationManager.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/junit/src/org/chromium/base/cached_flags/CachedFieldTrialParameterUnitTest.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/CachedFieldTrialParameter.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/app/ChromeActivity.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/CachedFeatureFlagsAnnotationUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/tab/java/src/org/chromium/chrome/browser/tab/state/ShoppingPersistedTabDataService.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/flags/BUILD.gn
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/customtabs/features/minimizedcustomtab/MinimizedFeatureUtils.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/back_press/android/java/src/org/chromium/chrome/browser/back_press/MinimizeAppAndCloseTabBackPressHandler.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/PostNativeFlag.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureListWithProcessorUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/FieldTrials.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/AllCachedFieldTrialParameters.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/hub/internal/android/java/src/org/chromium/chrome/browser/hub/HubToolbarMediatorUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/features/start_surface/java/src/org/chromium/chrome/features/start_surface/StartSurfaceConfiguration.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/feed/android/java/src/org/chromium/chrome/browser/feed/FeedPlaceholderLayout.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/junit/src/org/chromium/base/FlagUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/features/tab_ui/public/android/java/src/org/chromium/chrome/browser/tasks/tab_management/TabManagementFieldTrial.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/ValuesOverridden.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/junit/src/org/chromium/chrome/browser/app/flags/ChromeCachedFlagsUnitTest.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/junit/src/org/chromium/base/cached_flags/CachedFlagUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/Features.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/recent_tabs/android/java/src/org/chromium/chrome/browser/recent_tabs/RestoreTabsFeatureHelper.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/junit/src/org/chromium/base/PostNativeFlagUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/java/src/org/chromium/chrome/browser/omaha/VersionNumberGetter.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/FieldTrialsInstrumentationTest.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/BooleanCachedFieldTrialParameter.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/test/android/junit/src/org/chromium/base/test/util/BaseFlagTestRule.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/junit/src/org/chromium/base/cached_flags/CachedFeatureFlagsSafeModeUnitTest.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/TabUiFeatureUtilities.java
[add] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/OWNERS
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/CachedFlagsSafeMode.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/flags/android/java/src/org/chromium/chrome/browser/flags/ChromeFeatureList.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/OmniboxFeatures.java
[modify] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/chrome/browser/recent_tabs/android/java/src/org/chromium/chrome/browser/recent_tabs/RestoreTabsControllerDelegate.java
[rename] https://crrev.com/db3e1d9b131df5a2e2a34114a76a0cbafc3c14d5/base/android/java/src/org/chromium/base/cached_flags/DoubleCachedFieldTrialParameter.java

[hnakashima via monorail]

Updates:
Status: Fixed

Comment #36 on issue 1442347 by hnaka...@chromium.org: Move CachedFlag to base
https://bugs.chromium.org/p/chromium/issues/detail?id=1442347#c36

(No comment was entered for this change.)