Issue 1338388 in chromium: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.

84 views
Skip to first unread message

chiranjeevis via monorail

unread,
Jun 22, 2022, 2:09:34 AM6/22/22
to flag...@chromium.org
Status: Assigned
Owner: ameh...@chromium.org
CC: nyerr...@chromium.org, pmad...@chromium.org, newc...@chromium.org
Labels: hasbisect-per-revision Inhouse-HYD-Reported FoundIn-103 FoundIn-104 FoundIn-105 M-105 RegressedIn-102 Target-103 Target-104 Target-105
Components: Internals>Flags Internals>Flags>Expired
OS: Linux Windows Mac
Pri: 1
Type: Bug-Regression

New issue 1338388 by chiran...@chromium.org: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388

Chrome Version : 105.0.5134.0 (Official Build) canary (arm64) 963af331d2048e45aacc18da349b5ec196a523f0-refs/branch-heads/5134@{#1}

OS : Win (10, 11), Mac(13.0, 11.6, 10.15.7) and Linux 18.04.5 LTS

Steps to reproduce:
1.Launch chrome, open NTP and Navigate to “chrome://flags” Page.
2.Enable the "#temporary-unexpire-flags-m103” & "#temporary-unexpire-flags-m104” flags.
3.Search for the "#happiness-tracking-surveys-for-desktop-demo” flag.

Actual Result : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.

Expected Result : "#happiness-tracking-surveys-for-desktop-demo” flag should be there in chrome flags.

This is a Regression Issue broken in M102 and below is the Per-revision Bisect info,

Good Build : 101.0.4951.64 (Revision : 982481)
Bad Build : 102.0.4952.2 (Revision : 982946)

You are probably looking for a change made after 982577 (known good), but no later than 982578 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/b86da59480ff86bafab8b8f17c8525347f5fee16..61956c443f9f5a05b630b3f1c525b7e9300dd6a0

Suspect : https://chromium.googlesource.com/chromium/src/+/61956c443f9f5a05b630b3f1c525b7e9300dd6a0

Seems this is not related to the Issue hence providing Manual Bisect,

Suspect : https://chromium.googlesource.com/chromium/src/+/9582804a2a70de1d44bf99db232da15fd368f4d6

@amehfooz, Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1.Issue is also repro on Stable ##103.0.5060.53, Beta #103.0.5060.53, and Dev #104.0.5112.12

Kindly refer the Screen shot's given below,

Thank You !

Attachments:
Actual Result.png 93.7 KB
Expected Result.png 137 KB

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags
2. You are auto-CC'd on all issues in component Internals>Flags>Expired

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

avi via monorail

unread,
Jun 22, 2022, 12:55:56 PM6/22/22
to flag...@chromium.org
Updates:
Cc: msr...@chromium.org sau...@google.com
Components: UI>Browser>HaTS
Owner: feu...@google.com

Comment #1 on issue 1338388 by a...@chromium.org: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c1

FYI, happiness-tracking-surveys-for-desktop-demo is a flag that expired in M99. You can “temporarily unexpire” only recently expired flags.

Assigning that flag’s owners.

feuunk via monorail

unread,
Feb 16, 2023, 3:13:07 AM2/16/23
to flag...@chromium.org
Updates:
Status: WontFix

Comment #2 on issue 1338388 by feu...@google.com: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c2

Closing obsolete bug.

feuunk via monorail

unread,
Feb 16, 2023, 3:41:34 AM2/16/23
to flag...@chromium.org
Updates:
Owner: eoko...@chromium.org
Status: Assigned

Comment #3 on issue 1338388 by feu...@google.com: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c3

Actually, turns out this is used by some HaTS manual test cases:

https://testtracker.googleplex.com/efforts/testplans/details/1366574/28923

1.8 Desktop HaTS Next Migration
Tests from 1.8 to 1.8.12

Ehimare, Theo, do you know if those test cases are still relevant for the current sentiment tracking framework?

sauski via monorail

unread,
Feb 17, 2023, 7:39:55 AM2/17/23
to flag...@chromium.org

Comment #4 on issue 1338388 by sau...@google.com: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c4

These tests are for the base HaTS implementation - they are useful as we can't automate them end to end (e.g. the demo survey actually makes contact with the listnr backend).

Could we update the tests to provide the parameter via command line, so we don't have to continue updating the flag expiration / argue for a permanent flag?

sauski via monorail

unread,
Feb 27, 2023, 4:21:56 AM2/27/23
to flag...@chromium.org

Comment #5 on issue 1338388 by sau...@google.com: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c5

Extended flag @ issue 1419298 - it should be present in next canary.

poojand via monorail

unread,
Mar 20, 2023, 1:29:15 AM3/20/23
to flag...@chromium.org
Updates:
Cc: poo...@chromium.org
Labels: TE-Verified-M113 TE-Verified-113.0.5660.0

Comment #6 on issue 1338388 by poo...@chromium.org: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c6

Verified the Fix on OS : Mac(11.4) using latest Canary #113.0.5660.0

Observed that, #happiness-tracking-surveys-for-desktop-demo flag is available under chrome://flags

Please refer screencast attached below.

As fix is working as expected, Adding the TE-verified labels.

Thanks

poojand via monorail

unread,
Mar 20, 2023, 1:30:55 AM3/20/23
to flag...@chromium.org

Comment #7 on issue 1338388 by poo...@chromium.org: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c7

(No comment was entered for this change.)

Attachments:
113.0.5660.0.mov 8.4 MB

sauski via monorail

unread,
Mar 20, 2023, 4:03:09 AM3/20/23
to flag...@chromium.org
Updates:
Status: Verified

Comment #8 on issue 1338388 by sau...@google.com: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c8


(No comment was entered for this change.)

poojand via monorail

unread,
Mar 21, 2023, 6:36:36 AM3/21/23
to flag...@chromium.org

Comment #9 on issue 1338388 by poo...@chromium.org: Regression : "#happiness-tracking-surveys-for-desktop-demo” flag missing in chrome flags.
https://bugs.chromium.org/p/chromium/issues/detail?id=1338388#c9

Fix is working as expected on Win(10,11) and Linux.

Thanks!
Reply all
Reply to author
Forward
0 new messages