Issue 1335923 in chromium: Add Features.JUnitProcessor to BaseRobolectricTestRunner

[hnakashima via monorail]

Status: Untriaged
Owner: ----
CC: mmel...@google.com, ha...@chromium.org, mthi...@chromium.org
Components: Internals>Flags
OS: Android
Pri: 3
Type: Task

New issue 1335923 by hnaka...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923

Features.JUnitProcessor processed @EnableFeatures and @DisabledFeatures and resets flag overrides and cached flag returned states for testing. It is a common pitfall to forget to include in in a Robolectric test.

The blocker for this change is that Features.JUnitProcessor is Chrome-layer, while BaseRobolectricTestRunner is base layer. We could solve this by either:
- Creating a derived ChromeRobolectricTestRunner and mass migrating tests in Chrome to it.
- Moving CachedFeatureFlags to base (which requires removing sDefaults by implementing go/clank-flags-before-native)

I favor moving CachedFeatureFlags to base.

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[mthiesse via monorail]

Comment #1 on issue 1335923 by mthi...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923#c1

+1 moving CachedFeatureFlags to base.

[hnakashima via monorail]

Updates:
Status: Available

Comment #2 on issue 1335923 by hnaka...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923#c2

(No comment was entered for this change.)

[agrieve via monorail]

Updates:
Cc: bjo...@chromium.org hnaka...@chromium.org

Comment #3 on issue 1335923 by agr...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923#c3

Issue 1340381 has been merged into this issue.

[hnakashima via monorail]

Updates:
Cc: matts...@chromium.org yus...@chromium.org yz...@chromium.org wyc...@chromium.org hy...@google.com

Comment #5 on issue 1335923 by hnaka...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923#c5

Issue 967686 has been merged into this issue.

[hnakashima via monorail]

Updates:
Blockedon: 1442347

Comment #6 on issue 1335923 by hnaka...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923#c6

(No comment was entered for this change.)

[hnakashima via monorail]

Updates:
Blockedon: 1442353

Comment #7 on issue 1335923 by hnaka...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923#c7

[hnakashima via monorail]

Updates:
Owner: hnaka...@chromium.org
Status: Assigned

Comment #8 on issue 1335923 by hnaka...@chromium.org: Add Features.JUnitProcessor to BaseRobolectricTestRunner
https://bugs.chromium.org/p/chromium/issues/detail?id=1335923#c8