Issue 1188811 in chromium: Flag expired : treat-unsafe-downloads-as-active-content

378 views
Skip to first unread message

Git Watcher via monorail

unread,
Nov 9, 2021, 12:33:18 AM11/9/21
to flag...@chromium.org

Comment #1 on issue 1188811 by Git Watcher: Flag expired : treat-unsafe-downloads-as-active-content
https://bugs.chromium.org/p/chromium/issues/detail?id=1188811#c1

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/1288c1bd6a81785cd85b965d61820a7cd87a0e9c

commit 1288c1bd6a81785cd85b965d61820a7cd87a0e9c
Author: Shubham Gupta <shubh...@samsung.com>
Date: Tue Nov 09 05:32:29 2021

Remove expired flag from chrome://flags

The flag treat-unsafe-downloads-as-active-content is expired.
This CL removes them from chrome://flags.

Bug: 1188811
Change-Id: I35345006e6a90b2de586fa69d88a7b2d2ad40a6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3266657
Reviewed-by: Joe DeBlasio <jdeb...@chromium.org>
Commit-Queue: Joe DeBlasio <jdeb...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#939706}

[modify] https://crrev.com/1288c1bd6a81785cd85b965d61820a7cd87a0e9c/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/1288c1bd6a81785cd85b965d61820a7cd87a0e9c/chrome/browser/about_flags.cc
[modify] https://crrev.com/1288c1bd6a81785cd85b965d61820a7cd87a0e9c/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/1288c1bd6a81785cd85b965d61820a7cd87a0e9c/chrome/browser/flag-metadata.json

--
You received this message because:
1. You are auto-CC'd on all issues in component Internals>Flags>Expired

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

jdeblasio via monorail

unread,
Nov 9, 2021, 11:33:05 AM11/9/21
to flag...@chromium.org
Updates:
Components: Blink>SecurityFeature>MixedContent UI>Browser>Downloads
Owner: jdeb...@chromium.org
Status: Assigned

Comment #2 on issue 1188811 by jdeb...@chromium.org: Flag expired : treat-unsafe-downloads-as-active-content
https://bugs.chromium.org/p/chromium/issues/detail?id=1188811#c2

The bug in c#1 removes the flag, but the underlying feature is still there. That feature is fully launched and default-enabled, so there's more clean-up to do. We can probably use this bug to track that removal also.

shubh.gupta via monorail

unread,
Aug 17, 2023, 11:46:59 AM8/17/23
to flag...@chromium.org
Updates:
Cc: shubh...@samsung.com
Status: Fixed

Comment #4 on issue 1188811 by shubh...@samsung.com: Flag expired : treat-unsafe-downloads-as-active-content
https://bugs.chromium.org/p/chromium/issues/detail?id=1188811#c4

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages