[Editing] Control text truncation based on selection [chromium/src : main]

[Shweta Bindal (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 3 comments

File third_party/blink/renderer/core/editing/selection_editor.cc

Line 153, Patchset 17: UpdateContainsEntireSelectionFlagForElements(old_selection, new_selection);

Sambamurthy Bandaru . resolved

Use below util functions to get old and new elements. If they are not same, set `SetContainsEntireSelection()`

Shweta Bindal

Done

Line 161, Patchset 17: Element* element_to_clear = nullptr;
if (!old_selection.IsNone()) {
Node* old_anchor = old_selection.Anchor().AnchorNode();
Node* old_focus = old_selection.Focus().AnchorNode();
if (old_anchor && old_focus &&
old_anchor->parentElement() == old_focus->parentElement()) {
element_to_clear = old_anchor->parentElement();
}
}

Sambamurthy Bandaru . resolved

Use an existing util function or create a new one to get `element` from selection.

Shweta Bindal

Done

Line 187, Patchset 17: if (element_to_clear) {
if (LayoutObject* layout_object = element_to_clear->GetLayoutObject()) {
if (layout_object->ContainsEntireSelection()) {
layout_object->SetContainsEntireSelection(false);
const ComputedStyle* style = element_to_clear->GetComputedStyle();
if (style && !style->TextOverflow().IsClip()) {
layout_object->SetNeedsLayout(
layout_invalidation_reason::kStyleChange);
}
}
}
}

Sambamurthy Bandaru . resolved

Move this to a function which takes above `element`, and the boolean flag to set

Shweta Bindal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 20

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 16 Feb 2026 07:15:28 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Sambamurthy Bandaru <sambamurt...@microsoft.com>

[Sambamurthy Bandaru (Gerrit)]

Attention needed from Rohan Raja and Shweta Bindal

Sambamurthy Bandaru added 1 comment

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5478, Patchset 22 (Latest): name: "TextOverflowClipWithCaretSelection",

Sambamurthy Bandaru . unresolved

It's not caret selection anymore rt?

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 22

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Tue, 17 Feb 2026 05:36:47 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Sambamurthy Bandaru (Gerrit)]

Attention needed from Rohan Raja and Shweta Bindal

Sambamurthy Bandaru added 3 comments

Patchset-level comments

File-level comment, Patchset 22 (Latest):

Sambamurthy Bandaru . unresolved

There are many image comparison tests failing with "The three dots should not be selected" or similar expectations. Since the ellipses are no longer shown, should we remove them? Or change the expected text on image, instead of just doing rebaseline using tool.

File third_party/blink/web_tests/flag-specific/disable-site-isolation-trials/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 2, Patchset 22 (Latest):Harness Error. harness_status.status = 1 , harness_status.message = aborted by navigation\nfrom target frame detached\n (Session info: chrome-headless-shell=147.0.7681.0)\nTraceback (most recent call last):\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1147, in run_func\n self.result = True, self.func(self.protocol, self.url, self.timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1255, in do_testharness\n protocol.testharness.close_old_windows()\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 461, in close_old_windows\n self.close_windows(set(self.webdriver.handles) - {\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 472, in close_windows\n self.webdriver.window_handle = window_handle\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 599, in window_handle\n return self.send_session_command("POST", "window", body=body)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 556, in send_session_command\n return self.send_command(method, url, body, timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 517, in send_command\n raise err\nwebdriver.error.WebDriverException: aborted by navigation (500): aborted by navigation\nfrom target frame detached\n (Session info: chrome-headless-shell=147.0.7681.0)\n\nRemote-end stacktrace:\n\n#0 0x5aa3ad57add2 <unknown>\n#1 0x5aa3ad56c39e <unknown>\n#2 0x5aa3aced362b <unknown>\n#3 0x5aa3acec1582 <unknown>\n#4 0x5aa3acebf956 <unknown>\n#5 0x5aa3acebfef4 <unknown>\n#6 0x5aa3aced7d72 <unknown>\n#7 0x5aa3aced8d25 <unknown>\n#8 0x5aa3acedc081 <unknown>\n#9 0x5aa3acedc169 <unknown>\n#10 0x5aa3acf546f1 <unknown>\n#11 0x5aa3acf12590 <unknown>\n#12 0x5aa3acf11540 <unknown>\n#13 0x5aa3acf1232a <unknown>\n#14 0x5aa3ad513310 <unknown>\n#15 0x5aa3ad5308da <unknown>\n#16 0x5aa3ad53039b <unknown>\n#17 0x5aa3ad51e386 <unknown>\n#18 0x5aa3ad5310ea <unknown>\n#19 0x5aa3ad5035f1 <unknown>\n#20 0x5aa3ad558cd8 <unknown>\n#21 0x5aa3ad558e7a <unknown>\n#22 0x5aa3ad56ac7a <unknown>\n#23 0x7921aac94ac3 <unknown>\n#24 0x7921aad268d0 <unknown>\n

Sambamurthy Bandaru . unresolved

Can you explain what went wrong here?

File third_party/blink/web_tests/platform/mac-mac13-arm64/external/wpt/fetch/fetch-later/new-window.https.window-expected.txt

Line 1, Patchset 22 (Latest):This is a testharness.js-based test.

Sambamurthy Bandaru . unresolved

Explain the new failures

Gerrit-Comment-Date: Tue, 17 Feb 2026 05:43:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Sambamurthy Bandaru (Gerrit)]

Attention needed from Rohan Raja and Shweta Bindal

Sambamurthy Bandaru added 7 comments

File third_party/blink/web_tests/platform/mac-mac13/external/wpt/webxr/render_state_update.https-expected.txt

Line 1, Patchset 22 (Latest):This is a testharness.js-based test.

Sambamurthy Bandaru . unresolved

This file can be removed entirely.

File third_party/blink/web_tests/platform/mac-mac14/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 1, Patchset 22 (Latest):This is a testharness.js-based test.

Sambamurthy Bandaru . unresolved

This file too can be removed entirely.

File third_party/blink/web_tests/platform/mac-mac14/external/wpt/webxr/dom-overlay/ar_dom_overlay.https-expected.txt

Line 1, Patchset 22 (Latest):This is a testharness.js-based test.

Sambamurthy Bandaru . unresolved

This file too can be removed entirely.

File third_party/blink/web_tests/platform/mac-mac14/external/wpt/webxr/render_state_update.https-expected.txt

Line 1, Patchset 22 (Latest):This is a testharness.js-based test.

Sambamurthy Bandaru . unresolved

Explain the new failures.

File third_party/blink/web_tests/platform/mac-mac15-arm64/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 1, Patchset 22 (Latest):This is a testharness.js-based test.

Sambamurthy Bandaru . unresolved

This file too can be removed entirely.

File third_party/blink/web_tests/platform/mac/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 2, Patchset 22 (Latest):Harness Error. harness_status.status = 1 , harness_status.message = invalid argument: No target found for targetId\n (Session info: chrome-headless-shell=146.0.7679.0)\nTraceback (most recent call last):\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1147, in run_func\n self.result = True, self.func(self.protocol, self.url, self.timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1255, in do_testharness\n protocol.testharness.close_old_windows()\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 461, in close_old_windows\n self.close_windows(set(self.webdriver.handles) - {\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 473, in close_windows\n remaining_windows = self.webdriver.window.close()\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 282, in close\n handles = self.session.send_session_command("DELETE", "window")\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 556, in send_session_command\n return self.send_command(method, url, body, timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 517, in send_command\n raise err\nwebdriver.error.InvalidArgumentException: invalid argument (400): invalid argument: No target found for targetId\n (Session info: chrome-headless-shell=146.0.7679.0)\n\nRemote-end stacktrace:\n\n0 chromedriver 0x0000000103038582 base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) + 18\n1 chromedriver 0x0000000103029741 base::debug::StackTrace::StackTrace(unsigned long) + 225\n2 chromedriver 0x00000001026743c8 Status::Status(StatusCode, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 248\n3 chromedriver 0x000000010265d84c internal::ParseInspectorError(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 1228\n4 chromedriver 0x000000010265bd7a DevToolsClientImpl::SendCommandInternal(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::DictValue const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::DictValue*, bool, bool, int, Timeout const*) + 5130\n5 chromedriver 0x000000010265be67 DevToolsClientImpl::SendCommandWithTimeout(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::DictValue const&, Timeout const*) + 103\n6 chromedriver 0x000000010264f316 ChromeImpl::CloseTarget(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 198\n7 chromedriver 0x000000010264f6fa ChromeImpl::CloseWebView(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 74\n8 chromedriver 0x000000010270ac13 ExecuteClose(Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*) + 2131\n9 chromedriver 0x00000001026bf22d base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)>::Run(Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*) const & + 157\n10 chromedriver 0x00000001026bdc09 (anonymous namespace)::ExecuteSessionCommandOnSessionThread(char const*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)> const&, bool, bool, base::DictValue const&, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)> const&) + 1177\n11 chromedriver 0x00000001026bedfa base::internal::Invoker<base::internal::FunctorTraits<void (*&&)(char const*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)> const&, bool, bool, base::DictValue const&, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)> const&), char const*&&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>&&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)>&&, bool&&, bool&&, base::DictValue&&, scoped_refptr<base::SingleThreadTaskRunner>&&, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)>&&>, base::internal::BindState<false, true, false, void (*)(char const*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)> const&, bool, bool, base::DictValue const&, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)> const&), base::internal::UnretainedWrapper<char const, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)>, bool, bool, base::DictValue, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)>>, void ()>::RunOnce(base::internal::BindStateBase*) + 74\n12 chromedriver 0x0000000102653811 base::OnceCallback<void ()>::Run() && + 113\n13 chromedriver 0x0000000102f91960 base::TaskAnnotator::RunTaskImpl(base::PendingTask&) + 352\n14 chromedriver 0x0000000102fcb603 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) + 2339\n15 chromedriver 0x0000000102fcaa8b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 123\n16 chromedriver 0x0000000102f943bc base::MessagePumpDefault::Run(base::MessagePump::Delegate*) + 236\n17 chromedriver 0x0000000102fcc71b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 1083\n18 chromedriver 0x0000000102f7cf90 base::RunLoop::Run(base::Location const&) + 1136\n19 chromedriver 0x000000010300eff7 base::Thread::Run(base::RunLoop*) + 151\n20 chromedriver 0x000000010300f427 base::Thread::ThreadMain() + 967\n21 chromedriver 0x0000000103028ba5 base::(anonymous namespace)::ThreadFunc(void*) + 133\n22 libsystem_pthread.dylib 0x00007ff8156d5df1 _pthread_start + 99\n23 libsystem_pthread.dylib 0x00007ff8156d1857 thread_start + 15\n

Sambamurthy Bandaru . unresolved

Explain the error.

File third_party/blink/web_tests/platform/mac/external/wpt/webxr/dom-overlay/ar_dom_overlay.https-expected.txt

Line 1, Patchset 22 (Latest):This is a testharness.js-based test.

Sambamurthy Bandaru . unresolved

Explain the new error

Gerrit-Comment-Date: Tue, 17 Feb 2026 05:46:11 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Shweta Bindal (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 11 comments

Patchset-level comments

File-level comment, Patchset 22:

Sambamurthy Bandaru . resolved

There are many image comparison tests failing with "The three dots should not be selected" or similar expectations. Since the ellipses are no longer shown, should we remove them? Or change the expected text on image, instead of just doing rebaseline using tool.

Shweta Bindal

Done

File third_party/blink/renderer/platform/runtime_enabled_features.json5

Line 5478, Patchset 22: name: "TextOverflowClipWithCaretSelection",

Sambamurthy Bandaru . resolved

It's not caret selection anymore rt?

Shweta Bindal

Done

File third_party/blink/web_tests/flag-specific/disable-site-isolation-trials/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 2, Patchset 22:Harness Error. harness_status.status = 1 , harness_status.message = aborted by navigation\nfrom target frame detached\n (Session info: chrome-headless-shell=147.0.7681.0)\nTraceback (most recent call last):\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1147, in run_func\n self.result = True, self.func(self.protocol, self.url, self.timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1255, in do_testharness\n protocol.testharness.close_old_windows()\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 461, in close_old_windows\n self.close_windows(set(self.webdriver.handles) - {\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 472, in close_windows\n self.webdriver.window_handle = window_handle\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 599, in window_handle\n return self.send_session_command("POST", "window", body=body)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 556, in send_session_command\n return self.send_command(method, url, body, timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/b/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 517, in send_command\n raise err\nwebdriver.error.WebDriverException: aborted by navigation (500): aborted by navigation\nfrom target frame detached\n (Session info: chrome-headless-shell=147.0.7681.0)\n\nRemote-end stacktrace:\n\n#0 0x5aa3ad57add2 <unknown>\n#1 0x5aa3ad56c39e <unknown>\n#2 0x5aa3aced362b <unknown>\n#3 0x5aa3acec1582 <unknown>\n#4 0x5aa3acebf956 <unknown>\n#5 0x5aa3acebfef4 <unknown>\n#6 0x5aa3aced7d72 <unknown>\n#7 0x5aa3aced8d25 <unknown>\n#8 0x5aa3acedc081 <unknown>\n#9 0x5aa3acedc169 <unknown>\n#10 0x5aa3acf546f1 <unknown>\n#11 0x5aa3acf12590 <unknown>\n#12 0x5aa3acf11540 <unknown>\n#13 0x5aa3acf1232a <unknown>\n#14 0x5aa3ad513310 <unknown>\n#15 0x5aa3ad5308da <unknown>\n#16 0x5aa3ad53039b <unknown>\n#17 0x5aa3ad51e386 <unknown>\n#18 0x5aa3ad5310ea <unknown>\n#19 0x5aa3ad5035f1 <unknown>\n#20 0x5aa3ad558cd8 <unknown>\n#21 0x5aa3ad558e7a <unknown>\n#22 0x5aa3ad56ac7a <unknown>\n#23 0x7921aac94ac3 <unknown>\n#24 0x7921aad268d0 <unknown>\n

Sambamurthy Bandaru . resolved

Can you explain what went wrong here?

Shweta Bindal

Needed to delete file

File third_party/blink/web_tests/platform/mac-mac13-arm64/external/wpt/fetch/fetch-later/new-window.https.window-expected.txt

Line 1, Patchset 22:This is a testharness.js-based test.

Sambamurthy Bandaru . resolved

Explain the new failures

Shweta Bindal

Done

File third_party/blink/web_tests/platform/mac-mac13/external/wpt/webxr/render_state_update.https-expected.txt

Line 1, Patchset 22:This is a testharness.js-based test.

Sambamurthy Bandaru . resolved

This file can be removed entirely.

Shweta Bindal

Done

File third_party/blink/web_tests/platform/mac-mac14/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 1, Patchset 22:This is a testharness.js-based test.

Sambamurthy Bandaru . resolved

This file too can be removed entirely.

Shweta Bindal

Done

File third_party/blink/web_tests/platform/mac-mac14/external/wpt/webxr/dom-overlay/ar_dom_overlay.https-expected.txt

Line 1, Patchset 22:This is a testharness.js-based test.

Sambamurthy Bandaru . resolved

This file too can be removed entirely.

Shweta Bindal

Done

File third_party/blink/web_tests/platform/mac-mac14/external/wpt/webxr/render_state_update.https-expected.txt

Line 1, Patchset 22:This is a testharness.js-based test.

Sambamurthy Bandaru . resolved

Explain the new failures.

Shweta Bindal

Done

File third_party/blink/web_tests/platform/mac-mac15-arm64/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 1, Patchset 22:This is a testharness.js-based test.

Sambamurthy Bandaru . resolved

This file too can be removed entirely.

Shweta Bindal

Done

File third_party/blink/web_tests/platform/mac/external/wpt/html/cross-origin-opener-policy/iframe-popup-same-origin-to-same-origin.https_5-6-expected.txt

Line 2, Patchset 22:Harness Error. harness_status.status = 1 , harness_status.message = invalid argument: No target found for targetId\n (Session info: chrome-headless-shell=146.0.7679.0)\nTraceback (most recent call last):\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1147, in run_func\n self.result = True, self.func(self.protocol, self.url, self.timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 1255, in do_testharness\n protocol.testharness.close_old_windows()\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 461, in close_old_windows\n self.close_windows(set(self.webdriver.handles) - {\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/wptrunner/wptrunner/executors/executorwebdriver.py", line 473, in close_windows\n remaining_windows = self.webdriver.window.close()\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 282, in close\n handles = self.session.send_session_command("DELETE", "window")\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 556, in send_session_command\n return self.send_command(method, url, body, timeout)\n ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n File "/Volumes/Work/s/w/ir/third_party/wpt_tools/wpt/tools/webdriver/webdriver/client.py", line 517, in send_command\n raise err\nwebdriver.error.InvalidArgumentException: invalid argument (400): invalid argument: No target found for targetId\n (Session info: chrome-headless-shell=146.0.7679.0)\n\nRemote-end stacktrace:\n\n0 chromedriver 0x0000000103038582 base::debug::CollectStackTrace(base::span<void const*, 18446744073709551615ul, void const**>) + 18\n1 chromedriver 0x0000000103029741 base::debug::StackTrace::StackTrace(unsigned long) + 225\n2 chromedriver 0x00000001026743c8 Status::Status(StatusCode, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 248\n3 chromedriver 0x000000010265d84c internal::ParseInspectorError(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 1228\n4 chromedriver 0x000000010265bd7a DevToolsClientImpl::SendCommandInternal(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::DictValue const&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::DictValue*, bool, bool, int, Timeout const*) + 5130\n5 chromedriver 0x000000010265be67 DevToolsClientImpl::SendCommandWithTimeout(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::DictValue const&, Timeout const*) + 103\n6 chromedriver 0x000000010264f316 ChromeImpl::CloseTarget(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 198\n7 chromedriver 0x000000010264f6fa ChromeImpl::CloseWebView(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&) + 74\n8 chromedriver 0x000000010270ac13 ExecuteClose(Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*) + 2131\n9 chromedriver 0x00000001026bf22d base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)>::Run(Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*) const & + 157\n10 chromedriver 0x00000001026bdc09 (anonymous namespace)::ExecuteSessionCommandOnSessionThread(char const*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)> const&, bool, bool, base::DictValue const&, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)> const&) + 1177\n11 chromedriver 0x00000001026bedfa base::internal::Invoker<base::internal::FunctorTraits<void (*&&)(char const*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)> const&, bool, bool, base::DictValue const&, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)> const&), char const*&&, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>&&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)>&&, bool&&, bool&&, base::DictValue&&, scoped_refptr<base::SingleThreadTaskRunner>&&, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)>&&>, base::internal::BindState<false, true, false, void (*)(char const*, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)> const&, bool, bool, base::DictValue const&, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)> const&), base::internal::UnretainedWrapper<char const, base::unretained_traits::MayNotDangle, (partition_alloc::internal::RawPtrTraits)0>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>>, base::RepeatingCallback<Status (Session*, base::DictValue const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>*)>, bool, bool, base::DictValue, scoped_refptr<base::SingleThreadTaskRunner>, base::RepeatingCallback<void (Status const&, std::__Cr::unique_ptr<base::Value, std::__Cr::default_delete<base::Value>>, std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&, bool)>>, void ()>::RunOnce(base::internal::BindStateBase*) + 74\n12 chromedriver 0x0000000102653811 base::OnceCallback<void ()>::Run() && + 113\n13 chromedriver 0x0000000102f91960 base::TaskAnnotator::RunTaskImpl(base::PendingTask&) + 352\n14 chromedriver 0x0000000102fcb603 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) + 2339\n15 chromedriver 0x0000000102fcaa8b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() + 123\n16 chromedriver 0x0000000102f943bc base::MessagePumpDefault::Run(base::MessagePump::Delegate*) + 236\n17 chromedriver 0x0000000102fcc71b base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run(bool, base::TimeDelta) + 1083\n18 chromedriver 0x0000000102f7cf90 base::RunLoop::Run(base::Location const&) + 1136\n19 chromedriver 0x000000010300eff7 base::Thread::Run(base::RunLoop*) + 151\n20 chromedriver 0x000000010300f427 base::Thread::ThreadMain() + 967\n21 chromedriver 0x0000000103028ba5 base::(anonymous namespace)::ThreadFunc(void*) + 133\n22 libsystem_pthread.dylib 0x00007ff8156d5df1 _pthread_start + 99\n23 libsystem_pthread.dylib 0x00007ff8156d1857 thread_start + 15\n

Sambamurthy Bandaru . resolved

Explain the error.

Shweta Bindal

Done

File third_party/blink/web_tests/platform/mac/external/wpt/webxr/dom-overlay/ar_dom_overlay.https-expected.txt

Line 1, Patchset 22:This is a testharness.js-based test.

Sambamurthy Bandaru . resolved

Explain the new error

Shweta Bindal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 27

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Feb 2026 06:06:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Sambamurthy Bandaru <sambamurt...@microsoft.com>

[Sambamurthy Bandaru (Gerrit)]

Attention needed from Rohan Raja and Shweta Bindal

Sambamurthy Bandaru voted and added 4 comments

Votes added by Sambamurthy Bandaru

Code-Review

+1

4 comments

Patchset-level comments

File-level comment, Patchset 27 (Latest):

Sambamurthy Bandaru . resolved

LGTM with nit comments

File third_party/blink/renderer/core/css/resolver/style_adjuster.cc

Line 1292, Patchset 27 (Latest): if (element && !builder.TextOverflow().IsClip() && !RuntimeEnabledFeatures::TextOverflowClipWithSelectionEnabled()) {

Sambamurthy Bandaru . unresolved

git cl format

File third_party/blink/renderer/core/editing/selection_editor.cc

Line 163, Patchset 27 (Latest): if (!element) {

Sambamurthy Bandaru . unresolved

```suggestion
  if (!element && !element->GetLayoutObject()) {
```

Line 167, Patchset 27 (Latest): if (!layout_object) {
return;
}

Sambamurthy Bandaru . unresolved

remove this block

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 27

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Feb 2026 06:30:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Shweta Bindal (Gerrit)]

Attention needed from Rohan Raja

Shweta Bindal voted and added 3 comments

Votes added by Shweta Bindal

Commit-Queue

+1

3 comments

File third_party/blink/renderer/core/css/resolver/style_adjuster.cc

Line 1292, Patchset 27: if (element && !builder.TextOverflow().IsClip() && !RuntimeEnabledFeatures::TextOverflowClipWithSelectionEnabled()) {

Sambamurthy Bandaru . resolved

git cl format

Shweta Bindal

Done

File third_party/blink/renderer/core/editing/selection_editor.cc

Line 163, Patchset 27: if (!element) {

Sambamurthy Bandaru . resolved

```suggestion
  if (!element && !element->GetLayoutObject()) {
```

Shweta Bindal

Done

Line 167, Patchset 27: if (!layout_object) {
return;
}

Sambamurthy Bandaru . resolved

remove this block

Shweta Bindal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 28

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Feb 2026 08:47:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Sambamurthy Bandaru <sambamurt...@microsoft.com>

[Shweta Bindal (Gerrit)]

Attention needed from Kent Tamura and Rohan Raja

Shweta Bindal voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Rohan Raja

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 28

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Wed, 18 Feb 2026 08:58:27 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Kent Tamura (Gerrit)]

Attention needed from Rohan Raja and Shweta Bindal

Kent Tamura added 4 comments

File third_party/blink/renderer/core/editing/editing_utilities.cc

Line 397, Patchset 28 (Latest): if (anchor && focus && anchor->parentElement() == focus->parentElement()) {

Kent Tamura . unresolved

Does this work well if the common parent is an inline element?

e.g.
```html
<p style="text-overflow:ellipsis">
<span id="common"><span>fo^o</span><span>bar|</span></span>
</p>
```
Suppose that `^` is the anchor point and `|` is the focus point.

File third_party/blink/renderer/core/editing/selection_editor.cc

Line 155, Patchset 28 (Latest): SetContainsEntireSelectionFlag(element_to_clear, false);

Kent Tamura . unresolved

Should we handle **only** cases where a container contains entire selection?

Don't we handle selection across containers?
```html
<p>foo ^bar</p>
<p style="text-overflow:ellipsis">baz| qux...</p>
```
If `^` is the anchor point and `|` is the focus point, we'd like to disable ellipsis at least in the second `<p>`, don't we?

File third_party/blink/renderer/core/layout/inline/inline_layout_algorithm.cc

Line 347, Patchset 28 (Latest): !node_.GetLayoutBlockFlow()->ContainsEntireSelection()) {

Kent Tamura . unresolved

nit: Moving the ContainsEntireSelection() check into ShouldTruncateOverflowingText() would be cleaner.

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . unresolved

Why will it be removed?

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 28

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Thu, 19 Feb 2026 04:34:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Sambamurthy Bandaru (Gerrit)]

Attention needed from Rohan Raja and Shweta Bindal

Sambamurthy Bandaru voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 31

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Fri, 20 Feb 2026 05:22:49 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Shweta Bindal (Gerrit)]

Attention needed from Kent Tamura and Rohan Raja

Shweta Bindal added 4 comments

File third_party/blink/renderer/core/editing/editing_utilities.cc

Line 397, Patchset 28: if (anchor && focus && anchor->parentElement() == focus->parentElement()) {

Kent Tamura . resolved

Does this work well if the common parent is an inline element?

e.g.
```html
<p style="text-overflow:ellipsis">
<span id="common"><span>fo^o</span><span>bar|</span></span>
</p>
```
Suppose that `^` is the anchor point and `|` is the focus point.

Shweta Bindal

changed the approach to clip the text for element which has selection focus

File third_party/blink/renderer/core/editing/selection_editor.cc

Line 155, Patchset 28: SetContainsEntireSelectionFlag(element_to_clear, false);

Kent Tamura . resolved

Should we handle **only** cases where a container contains entire selection?

Don't we handle selection across containers?
```html
<p>foo ^bar</p>
<p style="text-overflow:ellipsis">baz| qux...</p>
```
If `^` is the anchor point and `|` is the focus point, we'd like to disable ellipsis at least in the second `<p>`, don't we?

Shweta Bindal

Done

File third_party/blink/renderer/core/layout/inline/inline_layout_algorithm.cc

Line 347, Patchset 28: !node_.GetLayoutBlockFlow()->ContainsEntireSelection()) {

Kent Tamura . resolved

nit: Moving the ContainsEntireSelection() check into ShouldTruncateOverflowingText() would be cleaner.

Shweta Bindal

Done

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . resolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Rohan Raja

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 31

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Fri, 20 Feb 2026 05:26:58 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>

[Kent Tamura (Gerrit)]

Attention needed from Rohan Raja and Shweta Bindal

Kent Tamura added 2 comments

File third_party/blink/renderer/core/layout/layout_block_flow.cc

Line 672, Patchset 31 (Latest): ContainsSelectionFocus()) {

Kent Tamura . unresolved

I guess `ContainsSelectionFocus()` should be `object_to_check->ContainsSelectionFocus()` for the following case:

```html
<div style="text-overflow:ellispsis">
<div>sub-block</div>
foo | bar (this is wrapped by an anonymous block-flow)
</div>
```

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . unresolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Kent Tamura

Do you mean this CL will change the placeholder/autocomplete behavior?

Will a placeholder have no ellipsis? Will a placeholder have an ellipsis even if the text control is focused? What about interoperability with other browsers? Can we change the behavior by a separated patch?

Anyway, we should update the test for the new behavior, not remove the test.

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 31

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Fri, 20 Feb 2026 05:59:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Shweta Bindal <shweta...@microsoft.com>

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>

[Shweta Bindal (Gerrit)]

Attention needed from Kent Tamura, Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 2 comments

File third_party/blink/renderer/core/layout/layout_block_flow.cc

Line 672, Patchset 31: ContainsSelectionFocus()) {

Kent Tamura . resolved

I guess `ContainsSelectionFocus()` should be `object_to_check->ContainsSelectionFocus()` for the following case:

```html
<div style="text-overflow:ellispsis">
<div>sub-block</div>
foo | bar (this is wrapped by an anonymous block-flow)
</div>
```

Shweta Bindal

Good catch. Changed to object_to_check->ContainsSelectionFocus() and set the flag on the non-anonymous parent that owns the text-overflow style.
Since ShouldTruncateOverflowingText() is evaluated during each child's inline layout and LayoutNG caches child results, the flag change alone doesn't cause cache misses — so we explicitly call SetNeedsLayout() on each block child (and on the block itself when it has no block children) to force re-evaluation.

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . resolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Kent Tamura

Do you mean this CL will change the placeholder/autocomplete behavior?

Will a placeholder have no ellipsis? Will a placeholder have an ellipsis even if the text control is focused? What about interoperability with other browsers? Can we change the behavior by a separated patch?

Anyway, we should update the test for the new behavior, not remove the test.

Shweta Bindal

For placeholder yes behavior will change, placeholder's ellipsis text will not we converted into clipped on selection or focus.
Firefox also behaves in the same way

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 36

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 04:14:29 +0000

[Kent Tamura (Gerrit)]

Attention needed from Rohan Raja, Sambamurthy Bandaru and Shweta Bindal

Kent Tamura added 1 comment

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . unresolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Kent Tamura

Do you mean this CL will change the placeholder/autocomplete behavior?

Will a placeholder have no ellipsis? Will a placeholder have an ellipsis even if the text control is focused? What about interoperability with other browsers? Can we change the behavior by a separated patch?

Anyway, we should update the test for the new behavior, not remove the test.

Shweta Bindal

For placeholder yes behavior will change, placeholder's ellipsis text will not we converted into clipped on selection or focus.
Firefox also behaves in the same way

Kent Tamura

I recommend to drop the placeholder behavior change from this CL, and handle it in a separated CL and behind a separated runtime flag.

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 05:00:58 +0000

[Shweta Bindal (Gerrit)]

Attention needed from Kent Tamura, Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 1 comment

File third_party/blink/web_tests/fast/css/text-overflow-input-focus-placeholder.html

File-level comment, Patchset 28 (Parent):

Kent Tamura . resolved

Why will it be removed?

Shweta Bindal

It was written when someone added change in styleadjuster to change text-overflow property on focus. Now since we are directly setting it from layout, I dont think it will matter if placeholder is clipped or not since user cannot interact with placeholder in any way

Kent Tamura

Do you mean this CL will change the placeholder/autocomplete behavior?

Will a placeholder have no ellipsis? Will a placeholder have an ellipsis even if the text control is focused? What about interoperability with other browsers? Can we change the behavior by a separated patch?

Anyway, we should update the test for the new behavior, not remove the test.

Shweta Bindal

For placeholder yes behavior will change, placeholder's ellipsis text will not we converted into clipped on selection or focus.
Firefox also behaves in the same way

Kent Tamura

I recommend to drop the placeholder behavior change from this CL, and handle it in a separated CL and behind a separated runtime flag.

Shweta Bindal

Made the changes. Will handle removing styleAdjuster code in separate PR

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 38

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 06:06:30 +0000

[Kent Tamura (Gerrit)]

Attention needed from Rohan Raja, Sambamurthy Bandaru and Shweta Bindal

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Code-Review

+1

1 comment

Commit Message

Line 11, Patchset 38 (Latest):during editing. This was a hack in StyleAdjuster.

Kent Tamura . unresolved

The hack in StyleAdjust is only for placeholder and suggestions. This sentense should be removed.

<input>'s behavior is in TextControlInnerEditorElement::CustomStyleForLayoutObject().

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru
• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 06:55:42 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Shweta Bindal (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Shweta Bindal added 1 comment

Commit Message

Line 11, Patchset 38:during editing. This was a hack in StyleAdjuster.

Kent Tamura . resolved

The hack in StyleAdjust is only for placeholder and suggestions. This sentense should be removed.

<input>'s behavior is in TextControlInnerEditorElement::CustomStyleForLayoutObject().

Shweta Bindal

Done

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 39

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 07:28:44 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>

[Shweta Bindal (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Shweta Bindal voted Commit-Queue+2

Commit-Queue

+2

Gerrit-Comment-Date: Mon, 02 Mar 2026 07:29:07 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Blink W3C Test Autoroller (Gerrit)]

Attention needed from Rohan Raja and Sambamurthy Bandaru

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/58159.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:

• Rohan Raja
• Sambamurthy Bandaru

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 39

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Attention: Rohan Raja <ror...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 07:36:56 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Unreviewed changes

38 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

[Editing] Control text truncation based on selection

Previously, text-overflow ellipsis was converted to clip
for focused input elements and placeholders to avoid rendering ellipsis
during editing.

Instead:
- Add |LayoutObject::ContainsSelection()| bitfield to track selection state
- In |SelectionEditor::SetSelection()|, notify parent elements of selection
  changes and update their |ContainsSelection()| state
- In InlineLayoutAlgorithm, skip ellipsis truncation if block contains
  selection |LayoutBlockFlow::ContainsSelection()|

New WPT tests verify ellipsis suppression in editable div/input/textarea
with caret. Updates multiple platform baselines for selection-aware
ellipsis rendering.

Bug: 40731275

Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7452739

Commit-Queue: Shweta Bindal <shweta...@microsoft.com>

Reviewed-by: Kent Tamura <tk...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1592277}

Files:

• M third_party/blink/renderer/core/editing/selection_editor.cc
• M third_party/blink/renderer/core/editing/selection_editor.h
• M third_party/blink/renderer/core/layout/layout_block_flow.cc
• M third_party/blink/renderer/core/layout/layout_object.cc
• M third_party/blink/renderer/core/layout/layout_object.h
• M third_party/blink/renderer/platform/runtime_enabled_features.json5
• A third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-anonymous-block-expected.html
• A third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-anonymous-block.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
• M third_party/blink/web_tests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl.html
• A third_party/blink/web_tests/editing/selection/text-overflow-ellipsis-selection-error-scenarios.html
• A third_party/blink/web_tests/editing/selection/text-overflow-ellipsis-selection.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/reference/text-overflow-ellipsis-editable-div-with-caret-ref.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/reference/text-overflow-ellipsis-textarea-with-caret-ref.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/text-overflow-ellipsis-editable-div-with-caret.html
• A third_party/blink/web_tests/external/wpt/css/css-overflow/text-overflow-ellipsis-textarea-with-caret.html
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/linux/virtual/text-antialias/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14-arm64/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/mac-mac14/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/mac/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/mac/virtual/text-antialias/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
• M third_party/blink/web_tests/platform/win/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-expected.png
• M third_party/blink/web_tests/platform/win/virtual/text-antialias/ellipsis-ltr-text-in-rtl-flow-underline-composition-expected.png

Change size: L

Delta: 44 files changed, 512 insertions(+), 9 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by Kent Tamura

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 40

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

[Blink W3C Test Autoroller (Gerrit)]

Message from Blink W3C Test Autoroller

The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/58159

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Comment-Date: Mon, 02 Mar 2026 08:24:52 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: No

[luci-bisection@appspot.gserviceaccount.com (Gerrit)]

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: revert

[Ian Kilpatrick (Gerrit)]

Attention needed from Shweta Bindal

Ian Kilpatrick added 1 comment

File third_party/blink/renderer/core/layout/layout_object.cc

Line 1835, Patchset 40 (Latest): return block;

Ian Kilpatrick . unresolved

This doesn't do what it says in the method name - e.g. it can return a non-LayoutBlock object is this safe?

Open in Gerrit

Related details

Attention is currently required from:

• Shweta Bindal

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3efb21eb33b2c5277573048e2dd04991650cc24

Gerrit-Change-Number: 7452739

Gerrit-PatchSet: 40

Gerrit-Owner: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Rohan Raja <ror...@microsoft.com>

Gerrit-Reviewer: Sambamurthy Bandaru <sambamurt...@microsoft.com>

Gerrit-Reviewer: Shweta Bindal <shweta...@microsoft.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>

Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>

Gerrit-CC: David Bokan <bo...@chromium.org>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Fredrik Söderquist <f...@opera.com>

Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>

Gerrit-CC: Mathias Bynens <mat...@chromium.org>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Morten Stenshorne <mste...@chromium.org>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>

Gerrit-CC: Sophie Chang <sophi...@chromium.org>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: Zijie He <zij...@google.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Shweta Bindal <shweta...@microsoft.com>

Gerrit-Comment-Date: Mon, 02 Mar 2026 17:33:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No