Erik Chen (Gerrit)

unread,

May 19, 2026, 12:02:08 PMMay 19

to Daniel Cheng, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Permissions Reviews, Peter Beverloo, prerendering-reviews, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Daniel Cheng and Thomas Lukaszewicz

Erik Chen voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention is currently required from:

Daniel Cheng
Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Daniel Cheng (Gerrit)

unread,

May 19, 2026, 12:08:34 PMMay 19

to Erik Chen, Daniel Cheng, Chromium LUCI CQ, Thomas Lukaszewicz, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Permissions Reviews, Peter Beverloo, prerendering-reviews, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Erik Chen and Thomas Lukaszewicz

Daniel Cheng voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen
Thomas Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Thomas Lukaszewicz (Gerrit)

unread,

May 19, 2026, 2:07:35 PMMay 19

to Erik Chen, Daniel Cheng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Permissions Reviews, Peter Beverloo, prerendering-reviews, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Erik Chen

Thomas Lukaszewicz voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Erik Chen (Gerrit)

unread,

May 19, 2026, 2:30:22 PMMay 19

to Thomas Lukaszewicz, Daniel Cheng, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Permissions Reviews, Peter Beverloo, prerendering-reviews, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Erik Chen voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

May 19, 2026, 2:42:37 PMMay 19

to Erik Chen, Thomas Lukaszewicz, Daniel Cheng, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Permissions Reviews, Peter Beverloo, prerendering-reviews, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Reland 1: Remove circular dependencies from //chrome/browser:browser

The initial CL was reverted as a suspect for crbug.com/502732679. The
issue was unrelated and was eventually fixed by crrev.com/c/7858054.

This CL is unchanged from the original CL.

> Remove circular dependencies from //chrome/browser:browser
>
> This CL modularizes `//chrome/browser/BUILD.gn` by extracting many
> header files into separate header-only `source_set` targets (e.g.,
> `certificate_viewer`, `chrome_browser_main`, `icon_manager`,
> `process_singleton`, `app_controller_mac`, etc.). This allows downstream
> targets to depend on individual headers without pulling in the entire
> `:browser` monolith, and eliminates the large
> `allow_circular_includes_from` list on the `:browser` target. Downstream
> `BUILD.gn` files across `chrome/` are updated to depend on the new
> fine-grained targets, and a number of Android-specific `#include`
> directives are annotated with `// nogncheck crbug.com/40147906`.
>
> AGENT_GENERATED_CL
>
> Bug: 353332589
> Change-Id: Iedfb2bcbb9530c70cd24db1754960f60d00ab591
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7841302
> Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>
> Reviewed-by: Daniel Cheng <dch...@chromium.org>
> Commit-Queue: Erik Chen <erik...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1632525}

Change-Id: I512b8a417f9a759838b02629fe07d89fc9f0efbf

Bug: 353332589

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7858342

Commit-Queue: Erik Chen <erik...@chromium.org>

Reviewed-by: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Thomas Lukaszewicz <tl...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1633030}

Files:

M chrome/BUILD.gn
M chrome/app/BUILD.gn
M chrome/browser/BUILD.gn
M chrome/browser/apps/app_shim/BUILD.gn
M chrome/browser/ash/chromebox_for_meetings/browser/BUILD.gn
M chrome/browser/ash/crostini/BUILD.gn
M chrome/browser/ash/login/BUILD.gn
M chrome/browser/ash/login/demo_mode/BUILD.gn
M chrome/browser/chrome_browser_field_trials.cc
M chrome/browser/chrome_browser_interface_binders.cc
M chrome/browser/chrome_content_browser_client.cc
M chrome/browser/devtools/BUILD.gn
M chrome/browser/extensions/BUILD.gn
M chrome/browser/feedback/BUILD.gn
M chrome/browser/first_run/BUILD.gn
M chrome/browser/glic/BUILD.gn
M chrome/browser/lifetime/BUILD.gn
M chrome/browser/mac/BUILD.gn
M chrome/browser/media/cdm_storage_id_key.cc
M chrome/browser/metrics/BUILD.gn
M chrome/browser/notifications/BUILD.gn
M chrome/browser/offline_pages/BUILD.gn
M chrome/browser/policy/BUILD.gn
M chrome/browser/prefs/BUILD.gn
M chrome/browser/preloading/prefetch/BUILD.gn
M chrome/browser/profiles/BUILD.gn
M chrome/browser/safe_browsing/BUILD.gn
M chrome/browser/sessions/BUILD.gn
M chrome/browser/shortcuts/BUILD.gn
M chrome/browser/ssl/BUILD.gn
M chrome/browser/sync/test/integration/BUILD.gn
M chrome/browser/task_manager/BUILD.gn
M chrome/browser/ui/BUILD.gn
M chrome/browser/ui/ash/login/BUILD.gn
M chrome/browser/ui/browser_window/internal/BUILD.gn
M chrome/browser/ui/cocoa/BUILD.gn
M chrome/browser/ui/download/BUILD.gn
M chrome/browser/ui/exclusive_access/BUILD.gn
M chrome/browser/ui/omnibox/BUILD.gn
M chrome/browser/ui/page_info/BUILD.gn
M chrome/browser/ui/prefs/BUILD.gn
M chrome/browser/ui/startup/BUILD.gn
M chrome/browser/ui/startup/default_browser_prompt/BUILD.gn
M chrome/browser/ui/views/crostini/BUILD.gn
M chrome/browser/ui/views/download/BUILD.gn
M chrome/browser/vr/BUILD.gn
M chrome/browser/web_applications/BUILD.gn
M chrome/test/BUILD.gn
M chrome/test/data/webui/BUILD.gn

Change size: L

Delta: 49 files changed, 506 insertions(+), 414 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Thomas Lukaszewicz, +1 by Daniel Cheng

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

James Cook (Gerrit)

unread,

May 27, 2026, 7:05:55 PM (6 days ago) May 27

to Erik Chen, Chromium LUCI CQ, Thomas Lukaszewicz, Daniel Cheng, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, devtools...@chromium.org, Enterprise Policy Reviews, Permissions Reviews, Peter Beverloo, prerendering-reviews, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, chlily...@chromium.org, chromium-a...@chromium.org, chromiumme...@microsoft.com, crost...@chromium.org, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchin...@chromium.org, dmurph+wat...@chromium.org, dmurph+watc...@chromium.org, dtraino...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, japhet+...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, nicolas...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, philli...@chromium.org, rrsilva+wat...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, vakh+safe_br...@chromium.org, webap...@microsoft.com, xinghui...@chromium.org, ydago...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Erik Chen

James Cook added 1 comment

File chrome/test/BUILD.gn

Line 4901, Patchset 3 (Latest): "../browser/extensions/feature_provider_browsertest.cc",

James Cook . unresolved

Was this intentionally moved? It had the effect of stopping this test from running on desktop Android. The move wouldn't affect Win/Mac/Linux/ChromeOS, so I'd be a little surprised if it had an effect on circular dependency problems with chrome/browser. I'm asking because I'm about to re-enable it on desktop Android.

Open in Gerrit

Related details

Attention is currently required from:

Erik Chen

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Reland 1: Remove circular dependencies from //chrome/browser:browser [chromium/src : main]

Erik Chen (Gerrit)

Erik Chen voted Commit-Queue+1

Related details

Daniel Cheng (Gerrit)

Daniel Cheng voted Code-Review+1

Related details

Thomas Lukaszewicz (Gerrit)

Thomas Lukaszewicz voted Code-Review+1

Related details

Erik Chen (Gerrit)

Erik Chen voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information

James Cook (Gerrit)

James Cook added 1 comment

Related details