Rename `mojo_files` and `mojo_files_deps` to `generated_ts_files` and `generated_ts_files_deps` [chromium/src : main]

0 views
Skip to first unread message

Jay Harris (Gerrit)

unread,
Feb 4, 2026, 5:15:45 PM (10 days ago) Feb 4
to Demetrios Papadopoulos, chromium...@chromium.org, Sophie Chang, Peter Williamson, Nikhil Nayunigari, AyeAye, menghua...@google.com, xiangdongkong+...@google.com, stevenjb+wa...@chromium.org, michaelcheco+...@google.com, byronle...@chromium.org, hansberry+w...@chromium.org, khorimoto+wa...@chromium.org, vasilii+watchlis...@chromium.org, suetfei+wa...@google.com, ajayramamurth...@google.com, jackshira+w...@google.com, crisrael+w...@google.com, feature-v...@chromium.org, weiluanw...@google.com, oshima...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, mickeybu...@chromium.org, longbowei+fe...@google.com, jackshira+wa...@google.com, mdjone...@chromium.org, borealis-re...@google.com, chrome-intelligence-te...@google.com, ashleydp+fe...@google.com, gavinwill+watch-...@chromium.org, jimmyxgong+watch-shor...@chromium.org, chromeos-ca...@google.com, druber...@chromium.org, pushi+wat...@google.com, chromium-a...@chromium.org, xlythe+wa...@google.com, tbarzi...@chromium.org, extension...@chromium.org, longbowei+watch-shor...@google.com, nikhilcn+wat...@google.com, wangdanny+fe...@google.com, storage...@chromium.org, chlily...@chromium.org, ayman...@chromium.org, cros-ed...@google.com, jimmyxgong+w...@chromium.org, chungshe...@google.com, michaelcheco+...@google.com, jimmyxgong+f...@chromium.org, cambickel+fe...@google.com, ntp-dev...@chromium.org, dclasson+w...@google.com, chadduffin+w...@chromium.org, jackshira+w...@google.com, croissant-...@chromium.org, dfried...@chromium.org, hsuregan+wa...@chromium.org, omnibox-...@chromium.org, chadduffin+wa...@chromium.org, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, estali...@chromium.org, cambickel+watch-shor...@google.com, khorimoto+w...@chromium.org, ejcaruso+wa...@chromium.org, hansberry+wa...@chromium.org, yuezhang...@chromium.org, gavinwill+sc...@chromium.org, jimmyxgong+watch...@chromium.org, dtraino...@chromium.org, jiajunz+wa...@google.com, jiajunz+wat...@google.com, apaselti...@chromium.org, cros-setti...@google.com, hsuregan+wat...@chromium.org, dewitt...@chromium.org, crost...@chromium.org, yyhyyh+fee...@google.com, feature-me...@chromium.org, chrome-intell...@chromium.org, alexmt...@chromium.org, jonmann+wa...@chromium.org, hansenmichael...@google.com, rrsilva+wat...@google.com, dennyh...@google.com, jdonnel...@chromium.org
Attention needed from Demetrios Papadopoulos

Jay Harris voted and added 1 comment

Votes added by Jay Harris

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jay Harris . resolved

dpapad mind confirming you're okay with this before I tag a bunch of other reviewers?

Open in Gerrit

Related details

Attention is currently required from:
  • Demetrios Papadopoulos
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id0c49e85de0d6105944a7fb9da2ec583cc8cbf59
Gerrit-Change-Number: 7544399
Gerrit-PatchSet: 1
Gerrit-Owner: Jay Harris <harr...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Jay Harris <harr...@chromium.org>
Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
Gerrit-CC: Peter Williamson <pet...@chromium.org>
Gerrit-CC: Sophie Chang <sophi...@chromium.org>
Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Feb 2026 22:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Demetrios Papadopoulos (Gerrit)

unread,
Feb 4, 2026, 5:32:05 PM (10 days ago) Feb 4
to Jay Harris, Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org, Sophie Chang, Peter Williamson, Nikhil Nayunigari, AyeAye, menghua...@google.com, xiangdongkong+...@google.com, stevenjb+wa...@chromium.org, michaelcheco+...@google.com, byronle...@chromium.org, hansberry+w...@chromium.org, khorimoto+wa...@chromium.org, vasilii+watchlis...@chromium.org, suetfei+wa...@google.com, ajayramamurth...@google.com, jackshira+w...@google.com, crisrael+w...@google.com, feature-v...@chromium.org, weiluanw...@google.com, oshima...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, mickeybu...@chromium.org, longbowei+fe...@google.com, jackshira+wa...@google.com, mdjone...@chromium.org, borealis-re...@google.com, chrome-intelligence-te...@google.com, ashleydp+fe...@google.com, gavinwill+watch-...@chromium.org, jimmyxgong+watch-shor...@chromium.org, chromeos-ca...@google.com, druber...@chromium.org, pushi+wat...@google.com, chromium-a...@chromium.org, xlythe+wa...@google.com, tbarzi...@chromium.org, extension...@chromium.org, longbowei+watch-shor...@google.com, nikhilcn+wat...@google.com, wangdanny+fe...@google.com, storage...@chromium.org, chlily...@chromium.org, ayman...@chromium.org, cros-ed...@google.com, jimmyxgong+w...@chromium.org, chungshe...@google.com, michaelcheco+...@google.com, jimmyxgong+f...@chromium.org, cambickel+fe...@google.com, ntp-dev...@chromium.org, dclasson+w...@google.com, chadduffin+w...@chromium.org, jackshira+w...@google.com, croissant-...@chromium.org, dfried...@chromium.org, hsuregan+wa...@chromium.org, omnibox-...@chromium.org, chadduffin+wa...@chromium.org, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, estali...@chromium.org, cambickel+watch-shor...@google.com, khorimoto+w...@chromium.org, ejcaruso+wa...@chromium.org, hansberry+wa...@chromium.org, yuezhang...@chromium.org, gavinwill+sc...@chromium.org, jimmyxgong+watch...@chromium.org, dtraino...@chromium.org, jiajunz+wa...@google.com, jiajunz+wat...@google.com, apaselti...@chromium.org, cros-setti...@google.com, hsuregan+wat...@chromium.org, dewitt...@chromium.org, crost...@chromium.org, yyhyyh+fee...@google.com, feature-me...@chromium.org, chrome-intell...@chromium.org, alexmt...@chromium.org, jonmann+wa...@chromium.org, hansenmichael...@google.com, rrsilva+wat...@google.com, dennyh...@google.com, jdonnel...@chromium.org
Attention needed from Jay Harris and Rebekah Potter

Demetrios Papadopoulos added 1 comment

Patchset-level comments
Demetrios Papadopoulos . unresolved

Could we follow an alternative approach that does not require renaming everything all at once? How about adding the new names, but also keeping the existing names as aliases for the new names. Then we don't need to change everyhing all at once and makes it easier to land this change with less risk of having to revert it and create a lot of churn.

Adding rbpotter@ as well for a 2nd WebUI owner insight.

Open in Gerrit

Related details

Attention is currently required from:
  • Jay Harris
  • Rebekah Potter
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id0c49e85de0d6105944a7fb9da2ec583cc8cbf59
    Gerrit-Change-Number: 7544399
    Gerrit-PatchSet: 1
    Gerrit-Owner: Jay Harris <harr...@chromium.org>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Jay Harris <harr...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-CC: Nikhil Nayunigari <nikh...@google.com>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Sophie Chang <sophi...@chromium.org>
    Gerrit-Attention: Jay Harris <harr...@chromium.org>
    Gerrit-Attention: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 22:31:57 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rebekah Potter (Gerrit)

    unread,
    Feb 5, 2026, 1:43:04 PM (9 days ago) Feb 5
    to Jay Harris, Chromium LUCI CQ, Demetrios Papadopoulos, chromium...@chromium.org, Sophie Chang, Peter Williamson, Nikhil Nayunigari, AyeAye, menghua...@google.com, xiangdongkong+...@google.com, stevenjb+wa...@chromium.org, michaelcheco+...@google.com, byronle...@chromium.org, hansberry+w...@chromium.org, khorimoto+wa...@chromium.org, vasilii+watchlis...@chromium.org, suetfei+wa...@google.com, ajayramamurth...@google.com, jackshira+w...@google.com, crisrael+w...@google.com, feature-v...@chromium.org, weiluanw...@google.com, oshima...@chromium.org, gcasto+w...@chromium.org, hais+wat...@google.com, mickeybu...@chromium.org, longbowei+fe...@google.com, jackshira+wa...@google.com, mdjone...@chromium.org, borealis-re...@google.com, chrome-intelligence-te...@google.com, ashleydp+fe...@google.com, gavinwill+watch-...@chromium.org, jimmyxgong+watch-shor...@chromium.org, chromeos-ca...@google.com, druber...@chromium.org, pushi+wat...@google.com, chromium-a...@chromium.org, xlythe+wa...@google.com, tbarzi...@chromium.org, extension...@chromium.org, longbowei+watch-shor...@google.com, nikhilcn+wat...@google.com, wangdanny+fe...@google.com, storage...@chromium.org, chlily...@chromium.org, ayman...@chromium.org, cros-ed...@google.com, jimmyxgong+w...@chromium.org, chungshe...@google.com, michaelcheco+...@google.com, jimmyxgong+f...@chromium.org, cambickel+fe...@google.com, ntp-dev...@chromium.org, dclasson+w...@google.com, chadduffin+w...@chromium.org, jackshira+w...@google.com, croissant-...@chromium.org, dfried...@chromium.org, hsuregan+wa...@chromium.org, omnibox-...@chromium.org, chadduffin+wa...@chromium.org, chrome-regionalc...@google.com, chrome-tab-group-en...@google.com, estali...@chromium.org, cambickel+watch-shor...@google.com, khorimoto+w...@chromium.org, ejcaruso+wa...@chromium.org, hansberry+wa...@chromium.org, yuezhang...@chromium.org, gavinwill+sc...@chromium.org, jimmyxgong+watch...@chromium.org, dtraino...@chromium.org, jiajunz+wa...@google.com, jiajunz+wat...@google.com, apaselti...@chromium.org, cros-setti...@google.com, hsuregan+wat...@chromium.org, dewitt...@chromium.org, crost...@chromium.org, yyhyyh+fee...@google.com, feature-me...@chromium.org, chrome-intell...@chromium.org, alexmt...@chromium.org, jonmann+wa...@chromium.org, hansenmichael...@google.com, rrsilva+wat...@google.com, dennyh...@google.com, jdonnel...@chromium.org
    Attention needed from Jay Harris

    Rebekah Potter added 1 comment

    Patchset-level comments
    Demetrios Papadopoulos . unresolved

    Could we follow an alternative approach that does not require renaming everything all at once? How about adding the new names, but also keeping the existing names as aliases for the new names. Then we don't need to change everyhing all at once and makes it easier to land this change with less risk of having to revert it and create a lot of churn.

    Adding rbpotter@ as well for a 2nd WebUI owner insight.

    Rebekah Potter

    +1 to the above; I think this will be hard to land without keeping the existing names initially. It also requires multiple OWNERS for review; probably easiest to land changes to directories that WebUI OWNERS don't own separately.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Jay Harris
    Gerrit-Comment-Date: Thu, 05 Feb 2026 18:42:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Demetrios Papadopoulos <dpa...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages