interface XRMediaBinding
attribute @@toStringTag
method constructor
method createCylinderLayer
method createEquirectLayer
method createQuadLayerWe should put this behind a runtime_enabled_feature so that it doesn't appear in virtual/stable yet
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
interface XRMediaBinding
attribute @@toStringTag
method constructor
method createCylinderLayer
method createEquirectLayer
method createQuadLayerWe should put this behind a runtime_enabled_feature so that it doesn't appear in virtual/stable yet
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
public: true,Status should probably be experimental; which would at least expose the regular global-interface-listing-expected.txt entry.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
public: true,Status should probably be experimental; which would at least expose the regular global-interface-listing-expected.txt entry.
this just defines the IDLs. It cannot be experimental yet. Do you want me to change it to experimental in the implementation CL? It always enables the feature currently.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
public: true,Yong Li (xWF)Status should probably be experimental; which would at least expose the regular global-interface-listing-expected.txt entry.
this just defines the IDLs. It cannot be experimental yet. Do you want me to change it to experimental in the implementation CL? It always enables the feature currently.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[RaisesException] XRQuadLayer createQuadLayer(HTMLVideoElement video, optional XRMediaQuadLayerInit init = {});I recall that this came up with a previous CL, but these dictionaries (`XRMediaQuadLayerInit`, `XRMediaCylinderLayerInit`, etc) shouldn't be optional, and it's a bug in the spec forced by our tooling that they are listed as optional there. Can we make these required? Or is there a separate blink-side bug that prevents that?
[RaisesException] XRQuadLayer createQuadLayer(HTMLVideoElement video, optional XRMediaQuadLayerInit init = {});I recall that this came up with a previous CL, but these dictionaries (`XRMediaQuadLayerInit`, `XRMediaCylinderLayerInit`, etc) shouldn't be optional, and it's a bug in the spec forced by our tooling that they are listed as optional there. Can we make these required? Or is there a separate blink-side bug that prevents that?
Do you mean this is a bug? https://www.w3.org/TR/webxrlayers-1/#xrmediabinding
Any quick hint about how this spec gets generated? I feel it may be reasonable to be optional, because their members are all optional. So a default constructor should be fine.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[RaisesException] XRQuadLayer createQuadLayer(HTMLVideoElement video, optional XRMediaQuadLayerInit init = {});Yong Li (xWF)I recall that this came up with a previous CL, but these dictionaries (`XRMediaQuadLayerInit`, `XRMediaCylinderLayerInit`, etc) shouldn't be optional, and it's a bug in the spec forced by our tooling that they are listed as optional there. Can we make these required? Or is there a separate blink-side bug that prevents that?
Do you mean this is a bug? https://www.w3.org/TR/webxrlayers-1/#xrmediabinding
Any quick hint about how this spec gets generated? I feel it may be reasonable to be optional, because their members are all optional. So a default constructor should be fine.
The `space` is required for each of them, so they can't be optional. (It's in the base interface so it's not obvious at first glance.)
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[RaisesException] XRQuadLayer createQuadLayer(HTMLVideoElement video, optional XRMediaQuadLayerInit init = {});Yong Li (xWF)I recall that this came up with a previous CL, but these dictionaries (`XRMediaQuadLayerInit`, `XRMediaCylinderLayerInit`, etc) shouldn't be optional, and it's a bug in the spec forced by our tooling that they are listed as optional there. Can we make these required? Or is there a separate blink-side bug that prevents that?
Brandon JonesDo you mean this is a bug? https://www.w3.org/TR/webxrlayers-1/#xrmediabinding
Any quick hint about how this spec gets generated? I feel it may be reasonable to be optional, because their members are all optional. So a default constructor should be fine.
The `space` is required for each of them, so they can't be optional. (It's in the base interface so it's not obvious at first glance.)
Done
Yong Li (xWF)Status should probably be experimental; which would at least expose the regular global-interface-listing-expected.txt entry.
Alexander Cooperthis just defines the IDLs. It cannot be experimental yet. Do you want me to change it to experimental in the implementation CL? It always enables the feature currently.
experimental just means it's in development.
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
| Code-Review | +1 |
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |