Split feature string parsing and enabled checks [chromium/src : main]

Alexander Cooper (Gerrit)

unread,

Apr 25, 2023, 7:46:48 PM4/25/23

to Piotr Bialecki, blink-...@chromium.org, feature-v...@chromium.org

Attention is currently required from: Piotr Bialecki.

Alexander Cooper would like Piotr Bialecki to review this change.

Split feature string parsing and enabled checks

Currently the function to parse the strings passed by the page *also*
checks if the given feature is enabled, which is a bit obscured. This
change splits those two responsibilities into two functions.

Change-Id: Ia617eb7a97a5e2f5b315057efb008344045586ac
---
M third_party/blink/renderer/modules/xr/xr_system.cc
M third_party/blink/renderer/modules/xr/xr_utils.cc
M third_party/blink/renderer/modules/xr/xr_utils.h
3 files changed, 40 insertions(+), 12 deletions(-)

To view, visit change 4477044. To unsubscribe, or for help writing mail filters, visit settings.

Alexander Cooper (Gerrit)

unread,

Apr 25, 2023, 7:46:52 PM4/25/23

to blink-...@chromium.org, feature-v...@chromium.org, Piotr Bialecki, chromium...@chromium.org

Attention is currently required from: Piotr Bialecki.

Patch set 1:Auto-Submit +1Commit-Queue +1

View Change

1 comment:

Patchset:
- Patch Set #1:
  Piotr PTAL

To view, visit change 4477044. To unsubscribe, or for help writing mail filters, visit settings.

Findit (Gerrit)

unread,

Apr 25, 2023, 9:15:02 PM4/25/23

to Alexander Cooper, blink-...@chromium.org, feature-v...@chromium.org, Chromium LUCI CQ, Piotr Bialecki, chromium...@chromium.org

Attention is currently required from: Alexander Cooper, Piotr Bialecki.

This change meets the code coverage requirements.

Patch set 2:Code-Coverage +1

View Change

To view, visit change 4477044. To unsubscribe, or for help writing mail filters, visit settings.

Piotr Bialecki (Gerrit)

unread,

Apr 26, 2023, 12:49:18 PM4/26/23

to Alexander Cooper, blink-...@chromium.org, feature-v...@chromium.org, Findit, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Alexander Cooper.

Patch set 2:Code-Review +1Commit-Queue +2

View Change

2 comments:

Commit Message:
- Patch Set #2, Line 10: which is a bit obscured
  💯
Patchset:
- Patch Set #2:
  LGTM.

To view, visit change 4477044. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Apr 26, 2023, 12:53:02 PM4/26/23

to Alexander Cooper, blink-...@chromium.org, feature-v...@chromium.org, Piotr Bialecki, Findit, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Piotr Bialecki: Looks good to me; Commit
  Findit: Ok
  Alexander Cooper: Send CL to CQ automatically after approval

Split feature string parsing and enabled checks

Currently the function to parse the strings passed by the page *also*
checks if the given feature is enabled, which is a bit obscured. This
change splits those two responsibilities into two functions.

Change-Id: Ia617eb7a97a5e2f5b315057efb008344045586ac

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4477044
Auto-Submit: Alexander Cooper <alco...@chromium.org>
Code-Coverage: Findit <findit...@appspot.gserviceaccount.com>
Commit-Queue: Piotr Bialecki <bia...@chromium.org>
Reviewed-by: Piotr Bialecki <bia...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1135978}


---
M third_party/blink/renderer/modules/xr/xr_system.cc
M third_party/blink/renderer/modules/xr/xr_utils.cc
M third_party/blink/renderer/modules/xr/xr_utils.h

3 files changed, 43 insertions(+), 14 deletions(-)

To view, visit change 4477044. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward