Reland "[xr] Move GpuFence creation into ClientSharedImage for OpenXR" [chromium/src : main]
0 views
Skip to first unread message
Mingjing Zhang (Gerrit)
11:27 AM (9 hours ago) 11:27 AM
to Chromium LUCI CQ, Vasiliy Telezhnikov, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Vasiliy Telezhnikov
Mingjing Zhang added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Mingjing Zhang . resolved
PTAL at this reland (Commit 1 is the original change). Thanks.
File device/vr/openxr/openxr_graphics_binding.cc
Line 344, Patchset 5 (Latest):
if (layers_sequence_.empty()) {Mingjing Zhang . resolved
Note: this is the check that is also used in `GetSharedImages()` now.
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
11:47 AM (9 hours ago) 11:47 AM
to Mingjing Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Mingjing Zhang
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
12:26 PM (8 hours ago) 12:26 PM
to Alexander Cooper, Vasiliy Telezhnikov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Alexander Cooper
Mingjing Zhang added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mingjing Zhang . resolved
PTAL at this reland (Commit 1 is the original change). Thanks.
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
12:36 PM (8 hours ago) 12:36 PM
to Mingjing Zhang, Vasiliy Telezhnikov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Mingjing Zhang
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
1:33 PM (7 hours ago) 1:33 PM
to Alexander Cooper, Vasiliy Telezhnikov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Mingjing Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:37 PM (7 hours ago) 1:37 PM
to Mingjing Zhang, Alexander Cooper, Vasiliy Telezhnikov, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[xr] Move GpuFence creation into ClientSharedImage for OpenXR"
This is a reland of commit 39b2d5ddfe1aabea931b7f72325c44a4c473c718
The original change attempted to get the active swap chain image
from the base layer OpenXrGraphicsBinding::GetSharedImages(). However,
the base layer may not have an active image even when `base_layer_` is
non-null. This caused a failure in WebXrVrOpenXrBrowserTest.TestLayers.
In this reland, we fix this issue by checking if `layers_sequence_`
is empty before acquiring the active swap chain image from base layer.
Original change's description:
> [xr] Move GpuFence creation into ClientSharedImage for OpenXR
>
> As part of the effort of moving SyncToken management in
> ClientSharedImage, this CL moves the GpuFence creation in OpenXR into
> ClientSharedImage::CreateGpuFenceForSyncTokens(). To support this
> change, we also added a GetSharedImages() member in
> OpenXrGraphicsBinding to retrieve ClientSharedImages for layers, and
> changed the GpuFence destruction timing to match the model used by
> Cardboard in ClientSharedImage::CreateGpuFenceForSyncTokens().
>
> Change-Id: Id9891c9a343b40df4ed687d7bfe34df10c81598c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7866522
> Commit-Queue: Mingjing Zhang <mjz...@chromium.org>
> Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
> Reviewed-by: Alexander Cooper <alco...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1637809}
Include-Ci-Only-Tests: true
Change-Id: I9b64d0d80bfd06dc7d64217970b31ff58d77505f
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Commit-Queue: Mingjing Zhang <mjz...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1640300}
Files:
- M device/vr/openxr/openxr_graphics_binding.cc
- M device/vr/openxr/openxr_graphics_binding.h
- M device/vr/openxr/openxr_render_loop.cc
- M device/vr/openxr/openxr_render_loop.h
Change size: M
Delta: 4 files changed, 42 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Alexander Cooper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages