Refactor ArCompositorFrameSink usage of TextureDrawQuad to unnormalized [chromium/src : main]
0 views
Skip to first unread message
Sky Debreuil (Gerrit)
Dec 8, 2025, 8:41:12 PM (8 days ago) Dec 8
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Vasiliy Telezhnikov
Sky Debreuil voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Dec 11, 2025, 2:19:19 PM (5 days ago) Dec 11
to Sky Debreuil, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Sky Debreuil
Vasiliy Telezhnikov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
2 comments
Patchset-level comments
File device/vr/android/arcore/ar_compositor_frame_sink.cc
Line 440, Patchset 4 (Latest):
const gfx::PointF uv_top_left =Vasiliy Telezhnikov . unresolved
nit: Could you add TODO(crbug.com/451876192) saying that we should investigate sending unormalized coordinates from [here](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/xr/xr_frame_provider.cc;drc=397107e399d4b0f4a6e801e7a888d7d71778529c;l=742).
Related details
Attention is currently required from:
- Sky Debreuil
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Debreuil (Gerrit)
Dec 11, 2025, 2:46:23 PM (5 days ago) Dec 11
to Vasiliy Telezhnikov, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Vasiliy Telezhnikov
Sky Debreuil voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sky Debreuil
| Auto-Submit | +1 |
1 comment
File device/vr/android/arcore/ar_compositor_frame_sink.cc
nit: Could you add TODO(crbug.com/451876192) saying that we should investigate sending unormalized coordinates from [here](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/xr/xr_frame_provider.cc;drc=397107e399d4b0f4a6e801e7a888d7d71778529c;l=742).
Sky Debreuil
Nice that makes sense. I've added the TODO - please let me know if there is anything else 😊
Related details
Attention is currently required from:
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sky Debreuil (Gerrit)
Dec 11, 2025, 2:46:45 PM (5 days ago) Dec 11
to Kramer Ge, Vasiliy Telezhnikov, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Kramer Ge and Vasiliy Telezhnikov
Sky Debreuil added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Sky Debreuil . resolved
Adding you for +1 as I need two upvotes to merge - Vasiliy has already given his +1 😊
Related details
Attention is currently required from:
- Kramer Ge
- Vasiliy Telezhnikov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Vasiliy Telezhnikov (Gerrit)
Dec 11, 2025, 2:49:23 PM (5 days ago) Dec 11
to Sky Debreuil, Kramer Ge, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Kramer Ge and Sky Debreuil
Vasiliy Telezhnikov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Kramer Ge
- Sky Debreuil
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Dec 15, 2025, 3:14:53 PM (23 hours ago) Dec 15
to Sky Debreuil, Colin Blundell, AyeAye, Vasiliy Telezhnikov, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Colin Blundell and Sky Debreuil
Kramer Ge added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Colin Blundell
- Sky Debreuil
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
2:45 AM (11 hours ago) 2:45 AM
to Sky Debreuil, Colin Blundell, AyeAye, Vasiliy Telezhnikov, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Sky Debreuil
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Colin Blundell . resolved
LGTM for OWNERS, defer to Vasiliy on the technical review. Thanks!
Related details
Attention is currently required from:
- Sky Debreuil
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:54 AM (9 hours ago) 4:54 AM
to Sky Debreuil, Colin Blundell, Kramer Ge, AyeAye, Vasiliy Telezhnikov, Code Review Nudger, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Refactor ArCompositorFrameSink usage of TextureDrawQuad to unnormalized
Update `ArCompositorFrameSink` to configure `viz::TextureDrawQuad` with
unnormalized texture coordinates.
Instead of passing normalized UV coordinates (0-1), calculate pixel
coordinates by scaling the bounds against the dimensions of the
underlying shared image. Apply this change to both the XR renderer
content and the camera image, and explicitly set the
`is_tex_coords_normalized` parameter to `false`.
Bug: 451876192
Change-Id: Ica88f770e9ecd4a4112db0571fa02b1804051261
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Auto-Submit: Sky Debreuil <skyde...@google.com>
Cr-Commit-Position: refs/heads/main@{#1559185}
Files:
- M device/vr/android/arcore/ar_compositor_frame_sink.cc
- M third_party/blink/renderer/modules/xr/xr_frame_provider.cc
Change size: M
Delta: 2 files changed, 36 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Colin Blundell, +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages