[blink][xr] Add a XRLayerHolder struct to combine LayerId and image ref [chromium/src : main]

0 views
Skip to first unread message

Mingjing Zhang (Gerrit)

unread,
Mar 4, 2026, 11:34:57 AM (12 days ago) Mar 4
to Vasiliy Telezhnikov, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Vasiliy Telezhnikov

Mingjing Zhang added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Mingjing Zhang . resolved

PTAL. Thanks.

Open in Gerrit

Related details

Attention is currently required from:
  • Vasiliy Telezhnikov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I815f6d790a88b9d009d99f04b4abd48e651adab7
Gerrit-Change-Number: 7511453
Gerrit-PatchSet: 4
Gerrit-Owner: Mingjing Zhang <mjz...@chromium.org>
Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-Attention: Vasiliy Telezhnikov <vas...@chromium.org>
Gerrit-Comment-Date: Wed, 04 Mar 2026 16:34:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Vasiliy Telezhnikov (Gerrit)

unread,
Mar 4, 2026, 2:31:15 PM (11 days ago) Mar 4
to Mingjing Zhang, AI Code Reviewer, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Mingjing Zhang

Vasiliy Telezhnikov voted and added 2 comments

Votes added by Vasiliy Telezhnikov

Code-Review+1

2 comments

Patchset-level comments
Vasiliy Telezhnikov . resolved

lgtm % nit, thanks.

File third_party/blink/renderer/modules/xr/xr_frame_provider.h
Line 38, Patchset 4 (Latest):struct XRLayerHolder {
Vasiliy Telezhnikov . unresolved

nit: XRLayerUpdate, as essentially we're tracking update to each layer.

Open in Gerrit

Related details

Attention is currently required from:
  • Mingjing Zhang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I815f6d790a88b9d009d99f04b4abd48e651adab7
    Gerrit-Change-Number: 7511453
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Reviewer: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Reviewer: Vasiliy Telezhnikov <vas...@chromium.org>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-Attention: Mingjing Zhang <mjz...@chromium.org>
    Gerrit-Comment-Date: Wed, 04 Mar 2026 19:31:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages