[webxr] Fix argument order in XRSystem::CreateViewerSession [chromium/src : main]
0 views
Skip to first unread message
Anna Sato (Gerrit)
Mar 10, 2026, 3:51:54 AM (6 days ago) Mar 10
to Alexander Cooper, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper
Anna Sato voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anna Sato
| Commit-Queue | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Anna Sato . resolved
Could you PTAL when you have a moment? Thanks!
Related details
Attention is currently required from:
- Alexander Cooper
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Brandon Jones (Gerrit)
Mar 10, 2026, 1:16:02 PM (5 days ago) Mar 10
to Anna Sato, Alexander Cooper, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Alexander Cooper and Anna Sato
Brandon Jones voted and added 1 comment![]( "Open in Gerrit")
Votes added by Brandon Jones
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Alexander Cooper
- Anna Sato
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
Mar 10, 2026, 1:28:14 PM (5 days ago) Mar 10
to Anna Sato, Brandon Jones, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Anna Sato
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Anna Sato
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anna Sato (Gerrit)
Mar 10, 2026, 9:17:17 PM (5 days ago) Mar 10
to Alexander Cooper, Brandon Jones, AyeAye, Chromium LUCI CQ, blink-...@chromium.org, feature-v...@chromium.org
Anna Sato voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Mar 10, 2026, 9:20:05 PM (5 days ago) Mar 10
to Anna Sato, Alexander Cooper, Brandon Jones, AyeAye, blink-...@chromium.org, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[webxr] Fix argument order in XRSystem::CreateViewerSession
The `trace_id` argument was introduced in https://crrev.com/c/5771473,
but CreateSession() in CreateSensorlessInlineSession() was called
incorrectly with `true` for `trace_id`. and kInvalidTraceId for
`sensorless_session`.
I couldn't find an associated bug, but this CL fixes the argument order
for correctness.
Bug: 358407362
Change-Id: Iba710e59630c65c90996e272642fcb73e8181e35
Commit-Queue: Anna Sato <anna...@chromium.org>
Reviewed-by: Brandon Jones <baj...@chromium.org>
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1597453}
Files:
- M third_party/blink/renderer/modules/xr/xr_system.cc
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexander Cooper, +1 by Brandon Jones
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages