Alexander Cooper (Gerrit)

unread,

Feb 3, 2026, 10:51:03 PM (11 days ago) Feb 3

to Brian Sheedy, Brandon Jones, Iker Jamardo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

Attention needed from Brandon Jones and Brian Sheedy

Alexander Cooper voted and added 2 comments

Votes added by Alexander Cooper

Auto-Submit

+1

2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Alexander Cooper . resolved

Brian or Brandon PTAL; my goal is to request a merge of this once it gets into Canary.
Iker FYI

File chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArHitTestTest.java

Line 124, Patchset 2: private void sendScreenTapToXrSession(

Alexander Cooper . resolved

These three methods are lifted from WebXrVrCardboardInputTest.java; as a followup I'll merge these into something on the XrTestFramework, but I'd like to keep this change reasonably scoped as I attempt to merge it back.

Open in Gerrit

Related details

Attention is currently required from:

Brandon Jones
Brian Sheedy

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Brian Sheedy (Gerrit)

unread,

Feb 4, 2026, 1:53:01 PM (10 days ago) Feb 4

to Alexander Cooper, Brandon Jones, Iker Jamardo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

Attention needed from Alexander Cooper and Brandon Jones

Brian Sheedy voted and added 3 comments

Votes added by Brian Sheedy

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Brian Sheedy . resolved

LGTM % comments

File chrome/test/data/xr/e2e_test_files/html/test_webxr_transient_hit_test_click.html

Line 2, Patchset 3 (Latest):Tests that AR hit test results are available in rAF as soon as hit test source is available.

Brian Sheedy . unresolved

Comment needs to be updated?

Line 54, Patchset 3 (Latest): hitTestSource = hts;

Brian Sheedy . unresolved

Nit: Either use `hts` or name the parameter `hitTestSource` instead of taking `hts` and immediately renaming it.

Open in Gerrit

Related details

Attention is currently required from:

Alexander Cooper
Brandon Jones

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alexander Cooper (Gerrit)

unread,

Feb 4, 2026, 2:11:56 PM (10 days ago) Feb 4

to Brian Sheedy, Brandon Jones, Iker Jamardo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

Attention needed from Brandon Jones

Alexander Cooper voted and added 2 comments

Votes added by Alexander Cooper

Auto-Submit

+1

2 comments

File chrome/test/data/xr/e2e_test_files/html/test_webxr_transient_hit_test_click.html

Line 2, Patchset 3:Tests that AR hit test results are available in rAF as soon as hit test source is available.

Brian Sheedy . resolved

Comment needs to be updated?

Alexander Cooper

Done

Line 54, Patchset 3: hitTestSource = hts;

Brian Sheedy . resolved

Nit: Either use `hts` or name the parameter `hitTestSource` instead of taking `hts` and immediately renaming it.

Alexander Cooper

Done

Open in Gerrit

Related details

Attention is currently required from:

Brandon Jones

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alexander Cooper (Gerrit)

unread,

Feb 4, 2026, 4:58:43 PM (10 days ago) Feb 4

to Brian Sheedy, Brandon Jones, Iker Jamardo, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

Attention needed from Brandon Jones

Alexander Cooper voted and added 1 comment

Votes added by Alexander Cooper

Commit-Queue

+2

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Alexander Cooper . resolved

Thanks!

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Feb 4, 2026, 5:16:32 PM (10 days ago) Feb 4

to Alexander Cooper, Brian Sheedy, Brandon Jones, Iker Jamardo, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: chrome/test/data/xr/e2e_test_files/html/test_webxr_transient_hit_test_click.html
Insertions: 2, Deletions: 3.

@@ -1,5 +1,5 @@
 <!--
-Tests that AR hit test results are available in rAF as soon as hit test source is available.
+Tests that AR transient hit test results are available in click event handlers.
 -->
 <html>
   <head>
@@ -49,9 +49,8 @@
               console.log('Requesting hit test source');
               sessionInfo.currentSession.requestHitTestSourceForTransientInput({
                 profile: "generic-touchscreen"
-              }).then((hts) => {
+              }).then((hitTestSource) => {
                 console.log('Got hit test source');
-                hitTestSource = hts;
                 session.addEventListener('selectstart', (event) => {
                   if (hitTestSource && testState != TestState.Done) {
                       // This returns an array of results—one for each active touch point
```

Change information

Commit message:

Ensure that WebXR world state is updated for input events

Ensures that the WebXR frame has finished being processed before calling
any methods that potentially send out events to the page. This could
cause pages to operate on an old world state for the click and never get
the actual state of things. This was particularly true for transient hit
tests where the actual results are only present for the single frame and
therefore should be present in the click event that is causing there to
be a transient hit test result.

Bug: 477639547

Change-Id: I572f921255b52676e390db95559b6b483ce0836f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7543161

Commit-Queue: Alexander Cooper <alco...@chromium.org>

Auto-Submit: Alexander Cooper <alco...@chromium.org>

Reviewed-by: Brian Sheedy <bsh...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1579707}

Files:

M chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrArHitTestTest.java
A chrome/test/data/xr/e2e_test_files/html/test_webxr_transient_hit_test_click.html
M third_party/blink/renderer/modules/xr/xr_session.cc

Change size: M

Delta: 3 files changed, 151 insertions(+), 4 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Brian Sheedy

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Ensure that WebXR world state is updated for input events [chromium/src : main]

Alexander Cooper (Gerrit)

Alexander Cooper voted and added 2 comments

Votes added by Alexander Cooper

2 comments

Related details

Brian Sheedy (Gerrit)

Brian Sheedy voted and added 3 comments

Votes added by Brian Sheedy

3 comments

Related details

Alexander Cooper (Gerrit)

Alexander Cooper voted and added 2 comments

Votes added by Alexander Cooper

2 comments

Related details

Alexander Cooper (Gerrit)

Alexander Cooper voted and added 1 comment

Votes added by Alexander Cooper

1 comment

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information