[ImmersivePlayback] Define SceneCore mesh data structures and surface shapes on Android [chromium/src : main]

0 views
Skip to first unread message

Oleh Desiatyrikov (xWF) (Gerrit)

unread,
2:24 PM (6 hours ago) 2:24 PM
to Nick Mondello, Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Gurmeet Kalra and Nick Mondello

Oleh Desiatyrikov (xWF) voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gurmeet Kalra
  • Nick Mondello
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
Gerrit-Change-Number: 7886605
Gerrit-PatchSet: 4
Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
Gerrit-Reviewer: Nick Mondello <mond...@google.com>
Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
Gerrit-Attention: Nick Mondello <mond...@google.com>
Gerrit-Comment-Date: Tue, 02 Jun 2026 18:24:18 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Gurmeet Kalra (Gerrit)

unread,
2:39 PM (6 hours ago) 2:39 PM
to Oleh Desiatyrikov (xWF), Nick Mondello, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
Attention needed from Nick Mondello and Oleh Desiatyrikov (xWF)

Gurmeet Kalra added 1 comment

File chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityUtils.java
Line 49, Patchset 4 (Latest): return DrawMode.TRIANGLES;
Gurmeet Kalra . unresolved

Any reason why we are assuming unknown index type to be set to TRIANGLES. Should it not throw a new IllegalArgumentException?

Open in Gerrit

Related details

Attention is currently required from:
  • Nick Mondello
  • Oleh Desiatyrikov (xWF)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
    Gerrit-Change-Number: 7886605
    Gerrit-PatchSet: 4
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Attention: Nick Mondello <mond...@google.com>
    Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Comment-Date: Tue, 02 Jun 2026 18:39:14 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Oleh Desiatyrikov (xWF) (Gerrit)

    unread,
    2:46 PM (6 hours ago) 2:46 PM
    to Nick Mondello, Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
    Attention needed from Gurmeet Kalra and Nick Mondello

    Oleh Desiatyrikov (xWF) added 1 comment

    File chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityUtils.java
    Line 49, Patchset 4 (Latest): return DrawMode.TRIANGLES;
    Gurmeet Kalra . unresolved

    Any reason why we are assuming unknown index type to be set to TRIANGLES. Should it not throw a new IllegalArgumentException?

    Oleh Desiatyrikov (xWF)

    No, there is no actual reason for this. Just my personal preference. I could throw an exceptions here and handle it in the calling code.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gurmeet Kalra
    • Nick Mondello
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
    Gerrit-Change-Number: 7886605
    Gerrit-PatchSet: 4
    Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
    Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Attention: Nick Mondello <mond...@google.com>
    Gerrit-Comment-Date: Tue, 02 Jun 2026 18:46:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Gurmeet Kalra <gurm...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gurmeet Kalra (Gerrit)

    unread,
    3:08 PM (5 hours ago) 3:08 PM
    to Oleh Desiatyrikov (xWF), Nick Mondello, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
    Attention needed from Nick Mondello and Oleh Desiatyrikov (xWF)

    Gurmeet Kalra voted and added 2 comments

    Votes added by Gurmeet Kalra

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Gurmeet Kalra . resolved

    lgtm

    File chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityUtils.java
    Line 49, Patchset 4 (Latest): return DrawMode.TRIANGLES;
    Gurmeet Kalra . unresolved

    Any reason why we are assuming unknown index type to be set to TRIANGLES. Should it not throw a new IllegalArgumentException?

    Oleh Desiatyrikov (xWF)

    No, there is no actual reason for this. Just my personal preference. I could throw an exceptions here and handle it in the calling code.

    Gurmeet Kalra

    Sg, adding an exception will help capture unknown cases.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nick Mondello
    • Oleh Desiatyrikov (xWF)
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
      Gerrit-Change-Number: 7886605
      Gerrit-PatchSet: 4
      Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Reviewer: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Attention: Nick Mondello <mond...@google.com>
      Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      Gerrit-Comment-Date: Tue, 02 Jun 2026 19:07:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Gurmeet Kalra <gurm...@google.com>
      Comment-In-Reply-To: Oleh Desiatyrikov (xWF) <desiat...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nick Mondello (Gerrit)

      unread,
      3:09 PM (5 hours ago) 3:09 PM
      to Oleh Desiatyrikov (xWF), Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
      Attention needed from Oleh Desiatyrikov (xWF)

      Nick Mondello voted and added 1 comment

      Votes added by Nick Mondello

      Code-Review+1

      1 comment

      File ui/android/java/src/org/chromium/ui/xr/scenecore/XrMeshData.java
      Line 119, Patchset 4 (Latest): float factor = scale / mCurrentScale;
      Nick Mondello . unresolved

      could mCurrentScale ever be 0?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Oleh Desiatyrikov (xWF)
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
        Gerrit-Change-Number: 7886605
        Gerrit-PatchSet: 4
        Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
        Gerrit-Reviewer: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
        Gerrit-Comment-Date: Tue, 02 Jun 2026 19:08:56 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Oleh Desiatyrikov (xWF) (Gerrit)

        unread,
        4:08 PM (4 hours ago) 4:08 PM
        to Nick Mondello, Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
        Attention needed from Gurmeet Kalra and Nick Mondello

        Oleh Desiatyrikov (xWF) added 2 comments

        File chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityUtils.java
        Line 49, Patchset 4: return DrawMode.TRIANGLES;
        Gurmeet Kalra . resolved

        Any reason why we are assuming unknown index type to be set to TRIANGLES. Should it not throw a new IllegalArgumentException?

        Oleh Desiatyrikov (xWF)

        No, there is no actual reason for this. Just my personal preference. I could throw an exceptions here and handle it in the calling code.

        Gurmeet Kalra

        Sg, adding an exception will help capture unknown cases.

        Oleh Desiatyrikov (xWF)

        Done

        File ui/android/java/src/org/chromium/ui/xr/scenecore/XrMeshData.java
        Line 119, Patchset 4: float factor = scale / mCurrentScale;
        Nick Mondello . resolved

        could mCurrentScale ever be 0?

        Oleh Desiatyrikov (xWF)

        Good catch!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Gurmeet Kalra
        • Nick Mondello
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
          Gerrit-Change-Number: 7886605
          Gerrit-PatchSet: 5
          Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
          Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
          Gerrit-Reviewer: Nick Mondello <mond...@google.com>
          Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
          Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
          Gerrit-Attention: Nick Mondello <mond...@google.com>
          Gerrit-Comment-Date: Tue, 02 Jun 2026 20:08:38 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          Comment-In-Reply-To: Gurmeet Kalra <gurm...@google.com>
          Comment-In-Reply-To: Nick Mondello <mond...@google.com>
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Gurmeet Kalra (Gerrit)

          unread,
          4:23 PM (4 hours ago) 4:23 PM
          to Oleh Desiatyrikov (xWF), Nick Mondello, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
          Attention needed from Nick Mondello and Oleh Desiatyrikov (xWF)

          Gurmeet Kalra voted and added 1 comment

          Votes added by Gurmeet Kalra

          Code-Review+1

          1 comment

          Patchset-level comments
          File-level comment, Patchset 5 (Latest):
          Gurmeet Kalra . resolved

          slgtm

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Nick Mondello
          • Oleh Desiatyrikov (xWF)
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
            Gerrit-Change-Number: 7886605
            Gerrit-PatchSet: 5
            Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
            Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
            Gerrit-Reviewer: Nick Mondello <mond...@google.com>
            Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
            Gerrit-Attention: Nick Mondello <mond...@google.com>
            Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
            Gerrit-Comment-Date: Tue, 02 Jun 2026 20:22:50 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Nick Mondello (Gerrit)

            unread,
            4:23 PM (4 hours ago) 4:23 PM
            to Oleh Desiatyrikov (xWF), Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org
            Attention needed from Oleh Desiatyrikov (xWF)

            Nick Mondello voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Oleh Desiatyrikov (xWF)
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
              Gerrit-Change-Number: 7886605
              Gerrit-PatchSet: 5
              Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
              Gerrit-Reviewer: Nick Mondello <mond...@google.com>
              Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Gerrit-Attention: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Gerrit-Comment-Date: Tue, 02 Jun 2026 20:23:16 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Oleh Desiatyrikov (xWF) (Gerrit)

              unread,
              6:19 PM (2 hours ago) 6:19 PM
              to Nick Mondello, Gurmeet Kalra, Chromium LUCI CQ, chromium...@chromium.org, feature-v...@chromium.org

              Oleh Desiatyrikov (xWF) voted Commit-Queue+2

              Commit-Queue+2
              Open in Gerrit

              Related details

              Attention set is empty
              Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
              Gerrit-Change-Number: 7886605
              Gerrit-PatchSet: 5
              Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
              Gerrit-Reviewer: Nick Mondello <mond...@google.com>
              Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Gerrit-Comment-Date: Tue, 02 Jun 2026 22:19:45 +0000
              Gerrit-HasComments: No
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              open
              diffy

              Chromium LUCI CQ (Gerrit)

              unread,
              6:23 PM (2 hours ago) 6:23 PM
              to Oleh Desiatyrikov (xWF), Nick Mondello, Gurmeet Kalra, chromium...@chromium.org, feature-v...@chromium.org

              Chromium LUCI CQ submitted the change

              Change information

              Commit message:
              [ImmersivePlayback] Define SceneCore mesh data structures and surface shapes on Android

              Defines XrMeshData on the Android side to receive serialized mesh
              buffers. Integrates shape support in XrSurfaceEntityHolder and
              implements custom mesh creation utility mapping.
              Bug: 493570550
              Fixed: 493570550
              Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
              Reviewed-by: Gurmeet Kalra <gurm...@google.com>
              Reviewed-by: Nick Mondello <mond...@google.com>
              Commit-Queue: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Cr-Commit-Position: refs/heads/main@{#1640502}
              Files:
              • M chrome/android/modules/xr/BUILD.gn
              • M chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityHolderImpl.java
              • A chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityUtils.java
              • A chrome/android/modules/xr/internal/junit/src/org/chromium/chrome/browser/xr/scenecore/XrMeshDataTest.java
              • M chrome/android/modules/xr/internal/junit/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityHolderImplTest.java
              • A chrome/android/modules/xr/internal/junit/src/org/chromium/chrome/browser/xr/scenecore/XrSurfaceEntityUtilsTest.java
              • M ui/android/BUILD.gn
              • A ui/android/java/src/org/chromium/ui/xr/scenecore/XrMeshData.java
              • M ui/android/java/src/org/chromium/ui/xr/scenecore/XrSurfaceEntityHolder.java
              • M ui/android/java/src/org/chromium/ui/xr/scenecore/XrSurfaceEntityShape.java
              Change size: L
              Delta: 10 files changed, 592 insertions(+), 2 deletions(-)
              Branch: refs/heads/main
              Submit Requirements:
              • requirement satisfiedCode-Review: +1 by Gurmeet Kalra, +1 by Nick Mondello
              Open in Gerrit
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: merged
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: I4f445371c6725a01219bed36e56c94041c60f93f
              Gerrit-Change-Number: 7886605
              Gerrit-PatchSet: 6
              Gerrit-Owner: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
              Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
              Gerrit-Reviewer: Nick Mondello <mond...@google.com>
              Gerrit-Reviewer: Oleh Desiatyrikov (xWF) <desiat...@google.com>
              open
              diffy
              satisfied_requirement
              Reply all
              Reply to author
              Forward
              0 new messages