Roll androidx libraries and update JXR related code [chromium/src : main]

0 views
Skip to first unread message

Nick Mondello (Gerrit)

unread,
Jan 23, 2026, 3:22:27 PMJan 23
to Andrew Grieve, Haiyang Pan, Gurmeet Kalra, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
Attention needed from Andrew Grieve, Gurmeet Kalra and Haiyang Pan

Nick Mondello added 1 comment

Patchset-level comments
File-level comment, Patchset 1:
Andrew Grieve . resolved

I think you'd be fine to add `@SuppressWarnings("UnsafeDynamicallyLoadedCode")` to silence the lint error. The error about ServiceLoader can be suppressed by adding a `-dontwarn`, but I think it's likely that there is a class missing that shouldn't be?

Nick Mondello

I added the suppress. And I have been trying to look into it. I don't think it could have been caused by the exclude group in the build.gradle.template. This doesn't have amything to do with those classes being pulled into the DFM?

Andrew Grieve

This is the class trying to load it via ServiceLoader:
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:xr/runtime/runtime/src/main/kotlin/androidx/xr/runtime/Session.kt;drc=7de1500561e0bab19cb34df21e77e43ce501147f;l=242 (from the xr-runtime library).

This is the library that provides the class:
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:xr/arcore/arcore-openxr/src/main/resources/META-INF/services/androidx.xr.arcore.internal.PerceptionRuntimeFactory;l=1?q=PerceptionRuntimeFactory%20-f:test (arcore-openxr)

It looks like you've got the `deps` set up correctly for these, so I think the issue is that our build system ignores non-.class files within prebuilts by default. You should try adding to customizations.gni an entry for `androidx_xr_arcore_arcore_openxr_java` to have it add `include_java_resources=true`

Nick Mondello

I tried adding it under template("androidx_android_aar_prebuilt") and template("_androidx_prebuilt"), both seem to not get the file included

Nick Mondello

Updating this thread. I patched the changes and ran the fetch all script. When looking at the xr split apk, the class is present, so Andrew suspects there might be a subtle build system bug here. He is going to try and repro/fix within the next day or so

Andrew Grieve

So, the interface that's being looked for is:
```
androidx.xr.runtime.internal.PerceptionRuntimeFactory
```

But the `META-INF/services` filename is: `androidx.xr.arcore.internal.PerceptionRuntimeFactory`

Maybe this package was renamed at some point and the rename forgot to update the META-INF file?


That said, it looks like the loading code tries to load a runtime in other ways as well, so maybe it doesn't need the ServiceLoader call to work? It's hard to tell...

If you need it to work, you can add:
```
diff --git a/chrome/android/modules/xr/BUILD.gn b/chrome/android/modules/xr/BUILD.gn
index 5814e009d00df..139b6007a3e8a 100644
--- a/chrome/android/modules/xr/BUILD.gn
+++ b/chrome/android/modules/xr/BUILD.gn
@@ -14,6 +14,8 @@ android_library("java") {
"internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSceneCoreSessionInitializerImpl.java",
"internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSceneCoreSessionManagerImpl.java",
]
+ additional_jar_files = [
+ [ "service.txt", "META-INF/services/androidx.xr.runtime.internal.PerceptionRuntimeFactory" ] ]
deps = [
"//base:build_info_java",
"//base:bundle_utils_java",
diff --git a/chrome/android/modules/xr/service.txt b/chrome/android/modules/xr/service.txt
new file mode 100644
index 0000000000000..b58ad5b0ba9f3
--- /dev/null
+++ b/chrome/android/modules/xr/service.txt
@@ -0,0 +1 @@
+androidx.xr.arcore.openxr.OpenXrRuntimeFactory
```

Plus this build fix: https://chromium-review.googlesource.com/c/chromium/src/+/7512306

Nick Mondello

SGTM. I'll add it to see if progaurd is satisfied. Then will wait on your build fix to land.

Nick Mondello

Seems progaurd is still unable to find it 😞

Nick Mondello

Spoke with Andrew, the progaurd -dontwarn is still needed. Passing!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Gurmeet Kalra
  • Haiyang Pan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
Gerrit-Change-Number: 7507921
Gerrit-PatchSet: 11
Gerrit-Owner: Nick Mondello <mond...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-Reviewer: Nick Mondello <mond...@google.com>
Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Fri, 23 Jan 2026 20:22:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Andrew Grieve <agr...@chromium.org>
Comment-In-Reply-To: Nick Mondello <mond...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Jan 26, 2026, 10:09:31 AMJan 26
to Nick Mondello, Andrew Grieve, Haiyang Pan, Gurmeet Kalra, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
Attention needed from Gurmeet Kalra, Haiyang Pan and Nick Mondello

Andrew Grieve voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Gurmeet Kalra
  • Haiyang Pan
  • Nick Mondello
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
Gerrit-Change-Number: 7507921
Gerrit-PatchSet: 13
Gerrit-Owner: Nick Mondello <mond...@google.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
Gerrit-Reviewer: Nick Mondello <mond...@google.com>
Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
Gerrit-Attention: Nick Mondello <mond...@google.com>
Gerrit-Attention: Haiyang Pan <hy...@google.com>
Gerrit-Comment-Date: Mon, 26 Jan 2026 15:09:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peter Wen (Gerrit)

unread,
Jan 28, 2026, 1:55:47 PMJan 28
to Nick Mondello, Code Review Nudger, Andrew Grieve, Haiyang Pan, Gurmeet Kalra, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
Attention needed from Gurmeet Kalra, Haiyang Pan and Nick Mondello

Peter Wen voted and added 1 comment

Votes added by Peter Wen

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Peter Wen . resolved

Let's try landing this 😊

Open in Gerrit

Related details

Attention is currently required from:
  • Gurmeet Kalra
  • Haiyang Pan
  • Nick Mondello
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
    Gerrit-Change-Number: 7507921
    Gerrit-PatchSet: 13
    Gerrit-Owner: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Attention: Nick Mondello <mond...@google.com>
    Gerrit-Attention: Haiyang Pan <hy...@google.com>
    Gerrit-Comment-Date: Wed, 28 Jan 2026 18:55:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gurmeet Kalra (Gerrit)

    unread,
    Jan 28, 2026, 2:28:45 PMJan 28
    to Nick Mondello, Peter Wen, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
    Attention needed from Haiyang Pan, Nick Mondello and Peter Wen

    Gurmeet Kalra voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Haiyang Pan
    • Nick Mondello
    • Peter Wen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
    Gerrit-Change-Number: 7507921
    Gerrit-PatchSet: 14
    Gerrit-Owner: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Nick Mondello <mond...@google.com>
    Gerrit-Attention: Peter Wen <wn...@chromium.org>
    Gerrit-Attention: Haiyang Pan <hy...@google.com>
    Gerrit-Comment-Date: Wed, 28 Jan 2026 19:28:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Peter Wen (Gerrit)

    unread,
    Jan 28, 2026, 3:22:49 PMJan 28
    to Nick Mondello, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
    Attention needed from Haiyang Pan and Nick Mondello

    Peter Wen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Haiyang Pan
    • Nick Mondello
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
    Gerrit-Change-Number: 7507921
    Gerrit-PatchSet: 15
    Gerrit-Owner: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
    Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
    Gerrit-Reviewer: Nick Mondello <mond...@google.com>
    Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Nick Mondello <mond...@google.com>
    Gerrit-Attention: Haiyang Pan <hy...@google.com>
    Gerrit-Comment-Date: Wed, 28 Jan 2026 20:22:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Peter Wen (Gerrit)

    unread,
    Jan 28, 2026, 3:49:24 PMJan 28
    to Nick Mondello, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
    Attention needed from Haiyang Pan and Nick Mondello

    Peter Wen voted and added 1 comment

    Votes added by Peter Wen

    Code-Review+1

    Related details

    Attention is currently required from:
    • Haiyang Pan
    • Nick Mondello
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
      Gerrit-Change-Number: 7507921
      Gerrit-PatchSet: 15
      Gerrit-Owner: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Attention: Nick Mondello <mond...@google.com>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Comment-Date: Wed, 28 Jan 2026 20:49:11 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nick Mondello (Gerrit)

      unread,
      Jan 28, 2026, 4:17:38 PMJan 28
      to Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Haiyang Pan and Peter Wen

      Nick Mondello added 1 comment

      Patchset-level comments
      Nick Mondello

      The run had passed previously, so I am not sure what changed? But I think this should be expected to be missing as we are removing it. It is now arcore_arcore_openxr. Is there a hard coded check anywhere that needs to be edited?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Haiyang Pan
      • Peter Wen
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
      Gerrit-Change-Number: 7507921
      Gerrit-PatchSet: 15
      Gerrit-Owner: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-Attention: Peter Wen <wn...@chromium.org>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Comment-Date: Wed, 28 Jan 2026 21:17:21 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Peter Wen <wn...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Andrew Grieve (Gerrit)

      unread,
      Jan 28, 2026, 4:25:56 PMJan 28
      to Nick Mondello, Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Haiyang Pan, Nick Mondello and Peter Wen

      Andrew Grieve voted and added 1 comment

      Votes added by Andrew Grieve

      Code-Review+1

      1 comment

      Patchset-level comments
      Andrew Grieve . resolved

      Looks like this check was recently added.
      @r...@google.com - is this safe to bypass?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Haiyang Pan
      • Nick Mondello
      • Peter Wen
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
      Gerrit-Change-Number: 7507921
      Gerrit-PatchSet: 15
      Gerrit-Owner: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Jordan Brown <r...@google.com>
      Gerrit-Attention: Nick Mondello <mond...@google.com>
      Gerrit-Attention: Peter Wen <wn...@chromium.org>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Comment-Date: Wed, 28 Jan 2026 21:25:47 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Andrew Grieve (Gerrit)

      unread,
      Jan 28, 2026, 4:26:10 PMJan 28
      to Nick Mondello, Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Haiyang Pan, Nick Mondello and Peter Wen

      Andrew Grieve added 1 comment

      Patchset-level comments
      Andrew Grieve . resolved
      Gerrit-Comment-Date: Wed, 28 Jan 2026 21:26:01 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Gurmeet Kalra (Gerrit)

      unread,
      Jan 28, 2026, 5:13:09 PMJan 28
      to Nick Mondello, Jordan Brown, Peter Wen, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Haiyang Pan, Nick Mondello and Peter Wen

      Gurmeet Kalra voted and added 1 comment

      Votes added by Gurmeet Kalra

      Code-Review+1

      1 comment

      File third_party/androidx/bill_of_materials.json
      Line 1440, Patchset 14: "version": "1.7.3"
      Gurmeet Kalra . unresolved

      Please double check on the version downgrade of `kotlinx-coroutines-android` from 1.9.0 to 1.7.3 as this may cause compatibility issues.

      Gerrit-Comment-Date: Wed, 28 Jan 2026 22:12:55 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nick Mondello (Gerrit)

      unread,
      Jan 28, 2026, 5:23:51 PMJan 28
      to Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Gurmeet Kalra, Haiyang Pan and Peter Wen

      Nick Mondello added 1 comment

      File third_party/androidx/bill_of_materials.json
      Line 1440, Patchset 14: "version": "1.7.3"
      Gurmeet Kalra . unresolved

      Please double check on the version downgrade of `kotlinx-coroutines-android` from 1.9.0 to 1.7.3 as this may cause compatibility issues.

      Nick Mondello

      https://chromium-review.googlesource.com/c/chromium/src/+/7004644/5/third_party/androidx/bill_of_materials.json Looking at this cl from sam, they were also downgrading other versions and upgrading this specific one in a manual roll. It is also auto generated. @agr...@chromium.org Is this a reason for concern?

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Gurmeet Kalra
      • Haiyang Pan
      • Peter Wen
      Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Attention: Peter Wen <wn...@chromium.org>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Comment-Date: Wed, 28 Jan 2026 22:23:36 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Gurmeet Kalra <gurm...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nick Mondello (Gerrit)

      unread,
      Jan 29, 2026, 6:10:34 PMJan 29
      to Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Gurmeet Kalra, Haiyang Pan and Peter Wen

      Nick Mondello added 1 comment

      Patchset-level comments
      Peter Wen . resolved

      Hmm... seems like this is a real failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8691399180016458065/+/u/validate_third_party_androidx_committed_libs_androidx_xr_runtime_runtime_openxr_README.chromium/run_validator_on_third_party_androidx_committed_libs_androidx_xr_runtime_runtime_openxr_README.chromium/stdout

      Nick Mondello

      The run had passed previously, so I am not sure what changed? But I think this should be expected to be missing as we are removing it. It is now arcore_arcore_openxr. Is there a hard coded check anywhere that needs to be edited?

      Nick Mondello

      Resolving. Jordan said there is a fix underway, and we also could use the bypass footer

      Gerrit-Comment-Date: Thu, 29 Jan 2026 23:10:19 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Nick Mondello <mond...@google.com>
      Comment-In-Reply-To: Peter Wen <wn...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jordan Brown (Gerrit)

      unread,
      Jan 29, 2026, 9:59:46 PMJan 29
      to Nick Mondello, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Gurmeet Kalra, Haiyang Pan, Nick Mondello and Peter Wen

      Jordan Brown added 1 comment

      Patchset-level comments
      Peter Wen . resolved

      Hmm... seems like this is a real failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8691399180016458065/+/u/validate_third_party_androidx_committed_libs_androidx_xr_runtime_runtime_openxr_README.chromium/run_validator_on_third_party_androidx_committed_libs_androidx_xr_runtime_runtime_openxr_README.chromium/stdout

      Nick Mondello

      The run had passed previously, so I am not sure what changed? But I think this should be expected to be missing as we are removing it. It is now arcore_arcore_openxr. Is there a hard coded check anywhere that needs to be edited?

      Nick Mondello

      Resolving. Jordan said there is a fix underway, and we also could use the bypass footer

      Jordan Brown

      It's now fixed and has passed the run

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Gurmeet Kalra
      • Haiyang Pan
      • Nick Mondello
      • Peter Wen
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
      Gerrit-Change-Number: 7507921
      Gerrit-PatchSet: 18
      Gerrit-Owner: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
      Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
      Gerrit-Reviewer: Nick Mondello <mond...@google.com>
      Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
      Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
      Gerrit-CC: Jordan Brown <r...@google.com>
      Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
      Gerrit-Attention: Nick Mondello <mond...@google.com>
      Gerrit-Attention: Peter Wen <wn...@chromium.org>
      Gerrit-Attention: Haiyang Pan <hy...@google.com>
      Gerrit-Comment-Date: Fri, 30 Jan 2026 02:59:10 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nick Mondello (Gerrit)

      unread,
      Jan 30, 2026, 1:19:22 PMJan 30
      to Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
      Attention needed from Gurmeet Kalra, Haiyang Pan and Peter Wen

      Nick Mondello added 1 comment

      File third_party/androidx/bill_of_materials.json
      Line 1440, Patchset 14: "version": "1.7.3"
      Gurmeet Kalra . resolved

      Please double check on the version downgrade of `kotlinx-coroutines-android` from 1.9.0 to 1.7.3 as this may cause compatibility issues.

      Nick Mondello

      https://chromium-review.googlesource.com/c/chromium/src/+/7004644/5/third_party/androidx/bill_of_materials.json Looking at this cl from sam, they were also downgrading other versions and upgrading this specific one in a manual roll. It is also auto generated. @agr...@chromium.org Is this a reason for concern?

      Nick Mondello

      Resolving. Spoke with Peter he recommended we land this as any issues we can work on, but this needs to get rolled.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Gurmeet Kalra
      • Haiyang Pan
      • Peter Wen
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
        Gerrit-Change-Number: 7507921
        Gerrit-PatchSet: 18
        Gerrit-Owner: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
        Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
        Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
        Gerrit-Reviewer: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
        Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
        Gerrit-CC: Jordan Brown <r...@google.com>
        Gerrit-Attention: Gurmeet Kalra <gurm...@google.com>
        Gerrit-Attention: Peter Wen <wn...@chromium.org>
        Gerrit-Attention: Haiyang Pan <hy...@google.com>
        Gerrit-Comment-Date: Fri, 30 Jan 2026 18:19:04 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Gurmeet Kalra <gurm...@google.com>
        Comment-In-Reply-To: Nick Mondello <mond...@google.com>
        satisfied_requirement
        open
        diffy

        Nick Mondello (Gerrit)

        unread,
        Jan 30, 2026, 1:19:29 PMJan 30
        to Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, Chromium LUCI CQ, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
        Attention needed from Gurmeet Kalra, Haiyang Pan and Peter Wen

        Nick Mondello voted Commit-Queue+2

        Commit-Queue+2
        Gerrit-Comment-Date: Fri, 30 Jan 2026 18:19:10 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        Jan 30, 2026, 1:23:35 PMJan 30
        to Nick Mondello, Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org

        Chromium LUCI CQ submitted the change

        Unreviewed changes

        15 is the latest approved patch-set.
        No files were changed between the latest approved patch-set and the submitted one.

        Change information

        Commit message:
        Roll androidx libraries and update JXR related code

        Updated scenecore requires updated imports and code.

        Roll androidx from kSaH_8VkwR5iiMUNZ... to BRlcqYO1wIQkiQ0OD...

        If this roll has caused a breakage, revert this CL and stop the roller
        using the controls here: https://autoroll.skia.org/r/androidx-chromium
        Please CC
        clank...@google.com,clank-libra...@google.com,wn...@google.com
        on the revert to ensure that a human is aware of the problem.

        To file a bug in Chromium:
        https://bugs.chromium.org/p/chromium/issues/entry

        To report a problem with the AutoRoller itself, please file a bug:
        https://issues.skia.org/issues/new?component=1389291&template=1850622

        Documentation for the AutoRoller is here:
        https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
        Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:test-emulator
        Bug: 473892306
        Fixed: 473892306
        Metadata-Validate-Bypass: Spoke with Jordan, there is a fix underway but bypass footer should work in meantime.
        Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
        Commit-Queue: Nick Mondello <mond...@google.com>
        Reviewed-by: Gurmeet Kalra <gurm...@google.com>
        Reviewed-by: Peter Wen <wn...@chromium.org>
        Reviewed-by: Andrew Grieve <agr...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1577373}
        Files:
        • M DEPS
        • M chrome/android/expectations/trichrome_chrome_64_32_bundle.proguard_flags.expected
        • M chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
        • M chrome/android/modules/xr/BUILD.gn
        • M chrome/android/modules/xr/internal/java/src/org/chromium/chrome/browser/xr/scenecore/XrSceneCoreSessionManagerImpl.java
        • A chrome/android/modules/xr/service.txt
        • M chrome/android/modules/xr/xr_module.gni
        • M third_party/androidx/BUILD.gn
        • M third_party/androidx/additional_readme_paths.json
        • M third_party/androidx/androidx_xr.flags
        • M third_party/androidx/bill_of_materials.json
        • M third_party/androidx/build.gradle
        • M third_party/androidx/committed/libs/androidx_activity_activity/README.chromium
        • M third_party/androidx/committed/libs/androidx_activity_activity_compose/README.chromium
        • M third_party/androidx/committed/libs/androidx_activity_activity_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_annotation_annotation_experimental/README.chromium
        • M third_party/androidx/committed/libs/androidx_annotation_annotation_jvm/README.chromium
        • M third_party/androidx/committed/libs/androidx_appcompat_appcompat/README.chromium
        • M third_party/androidx/committed/libs/androidx_appcompat_appcompat_resources/README.chromium
        • M third_party/androidx/committed/libs/androidx_appsearch_appsearch/README.chromium
        • M third_party/androidx/committed/libs/androidx_appsearch_appsearch_builtin_types/README.chromium
        • M third_party/androidx/committed/libs/androidx_appsearch_appsearch_platform_storage/README.chromium
        • M third_party/androidx/committed/libs/androidx_arch_core_core_common/README.chromium
        • M third_party/androidx/committed/libs/androidx_arch_core_core_runtime/README.chromium
        • M third_party/androidx/committed/libs/androidx_autofill_autofill/README.chromium
        • M third_party/androidx/committed/libs/androidx_benchmark_benchmark_common/README.chromium
        • M third_party/androidx/committed/libs/androidx_benchmark_benchmark_junit4/README.chromium
        • M third_party/androidx/committed/libs/androidx_benchmark_benchmark_macro/README.chromium
        • M third_party/androidx/committed/libs/androidx_benchmark_benchmark_macro_junit4/README.chromium
        • M third_party/androidx/committed/libs/androidx_benchmark_benchmark_traceprocessor_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_biometric_biometric/README.chromium
        • M third_party/androidx/committed/libs/androidx_browser_browser/README.chromium
        • M third_party/androidx/committed/libs/androidx_cardview_cardview/README.chromium
        • M third_party/androidx/committed/libs/androidx_collection_collection_jvm/README.chromium
        • M third_party/androidx/committed/libs/androidx_collection_collection_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_animation_animation_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_animation_animation_core_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_foundation_foundation_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_foundation_foundation_layout_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_material3_material3_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_material_material_ripple_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_runtime_runtime_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_runtime_runtime_annotation_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_runtime_runtime_retain_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_runtime_runtime_saveable_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_geometry_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_graphics_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_test_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_test_junit4_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_test_manifest/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_text_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_text_google_fonts/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_unit_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_compose_ui_ui_util_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_constraintlayout_constraintlayout/README.chromium
        • M third_party/androidx/committed/libs/androidx_constraintlayout_constraintlayout_core/README.chromium
        • M third_party/androidx/committed/libs/androidx_core_core/README.chromium
        • M third_party/androidx/committed/libs/androidx_core_core_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_core_core_viewtree/README.chromium
        • M third_party/androidx/committed/libs/androidx_credentials_credentials/README.chromium
        • M third_party/androidx/committed/libs/androidx_credentials_credentials_play_services_auth/README.chromium
        • M third_party/androidx/committed/libs/androidx_credentials_registry_registry_provider/README.chromium
        • M third_party/androidx/committed/libs/androidx_credentials_registry_registry_provider_play_services/README.chromium
        • M third_party/androidx/committed/libs/androidx_cursoradapter_cursoradapter/README.chromium
        • M third_party/androidx/committed/libs/androidx_datastore_datastore_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_datastore_datastore_core_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_datastore_datastore_core_okio_jvm/README.chromium
        • M third_party/androidx/committed/libs/androidx_datastore_datastore_preferences_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_datastore_datastore_preferences_core_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_datastore_datastore_preferences_external_protobuf/README.chromium
        • M third_party/androidx/committed/libs/androidx_datastore_datastore_preferences_proto/README.chromium
        • M third_party/androidx/committed/libs/androidx_drawerlayout_drawerlayout/README.chromium
        • M third_party/androidx/committed/libs/androidx_fragment_fragment/README.chromium
        • M third_party/androidx/committed/libs/androidx_fragment_fragment_compose/README.chromium
        • M third_party/androidx/committed/libs/androidx_fragment_fragment_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_fragment_fragment_testing/README.chromium
        • M third_party/androidx/committed/libs/androidx_fragment_fragment_testing_manifest/README.chromium
        • M third_party/androidx/committed/libs/androidx_graphics_graphics_path/README.chromium
        • M third_party/androidx/committed/libs/androidx_interpolator_interpolator/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_common_java8/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_common_jvm/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_livedata/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_livedata_core/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_livedata_core_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_livedata_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_process/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_runtime_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_runtime_compose_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_runtime_ktx_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_service/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_viewmodel_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_viewmodel_compose_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_viewmodel_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_lifecycle_lifecycle_viewmodel_savedstate_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_loader_loader/README.chromium
        • M third_party/androidx/committed/libs/androidx_media_media/README.chromium
        • M third_party/androidx/committed/libs/androidx_mediarouter_mediarouter/README.chromium
        • M third_party/androidx/committed/libs/androidx_navigation_navigation_common_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_navigation_navigation_compose_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_navigation_navigation_runtime_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_navigationevent_navigationevent_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_navigationevent_navigationevent_compose_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_paging_paging_common_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_paging_paging_common_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_paging_paging_compose_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_paging_paging_runtime/README.chromium
        • M third_party/androidx/committed/libs/androidx_palette_palette/README.chromium
        • M third_party/androidx/committed/libs/androidx_pdf_pdf_document_service/README.chromium
        • M third_party/androidx/committed/libs/androidx_pdf_pdf_viewer/README.chromium
        • M third_party/androidx/committed/libs/androidx_pdf_pdf_viewer_fragment/README.chromium
        • M third_party/androidx/committed/libs/androidx_preference_preference/README.chromium
        • M third_party/androidx/committed/libs/androidx_profileinstaller_profileinstaller/README.chromium
        • M third_party/androidx/committed/libs/androidx_recyclerview_recyclerview/README.chromium
        • M third_party/androidx/committed/libs/androidx_resourceinspection_resourceinspection_annotation/README.chromium
        • M third_party/androidx/committed/libs/androidx_savedstate_savedstate_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_savedstate_savedstate_compose_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_savedstate_savedstate_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_slidingpanelayout_slidingpanelayout/README.chromium
        • M third_party/androidx/committed/libs/androidx_sqlite_sqlite_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_sqlite_sqlite_framework_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_test_uiautomator_uiautomator/README.chromium
        • M third_party/androidx/committed/libs/androidx_test_uiautomator_uiautomator_shell_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_tracing_tracing_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_tracing_tracing_ktx/README.chromium
        • M third_party/androidx/committed/libs/androidx_viewpager2_viewpager2/README.chromium
        • M third_party/androidx/committed/libs/androidx_webkit_webkit/README.chromium
        • M third_party/androidx/committed/libs/androidx_window_sidecar_sidecar/README.chromium
        • M third_party/androidx/committed/libs/androidx_window_window/README.chromium
        • M third_party/androidx/committed/libs/androidx_window_window_core_android/README.chromium
        • M third_party/androidx/committed/libs/androidx_work_work_multiprocess/README.chromium
        • M third_party/androidx/committed/libs/androidx_work_work_runtime/README.chromium
        • M third_party/androidx/committed/libs/androidx_xr_arcore_arcore/README.chromium
        • R third_party/androidx/committed/libs/androidx_xr_arcore_arcore_openxr/LICENSE
        • A third_party/androidx/committed/libs/androidx_xr_arcore_arcore_openxr/README.chromium
        • R third_party/androidx/committed/libs/androidx_xr_arcore_arcore_openxr/androidx_xr_arcore_arcore_openxr.info
        • C third_party/androidx/committed/libs/androidx_xr_arcore_arcore_projected/LICENSE
        • A third_party/androidx/committed/libs/androidx_xr_arcore_arcore_projected/README.chromium
        • A third_party/androidx/committed/libs/androidx_xr_arcore_arcore_projected/androidx_xr_arcore_arcore_projected.info
        • C third_party/androidx/committed/libs/androidx_xr_arcore_arcore_runtime/LICENSE
        • A third_party/androidx/committed/libs/androidx_xr_arcore_arcore_runtime/README.chromium
        • A third_party/androidx/committed/libs/androidx_xr_arcore_arcore_runtime/androidx_xr_arcore_arcore_runtime.info
        • M third_party/androidx/committed/libs/androidx_xr_runtime_runtime/README.chromium
        • M third_party/androidx/committed/libs/androidx_xr_runtime_runtime_manifest/README.chromium
        • D third_party/androidx/committed/libs/androidx_xr_runtime_runtime_openxr/README.chromium
        • M third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore/README.chromium
        • C third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_runtime/LICENSE
        • A third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_runtime/README.chromium
        • A third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_runtime/androidx_xr_scenecore_scenecore_runtime.info
        • C third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_spatial_core/LICENSE
        • A third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_spatial_core/README.chromium
        • A third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_spatial_core/androidx_xr_scenecore_scenecore_spatial_core.info
        • C third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_spatial_rendering/LICENSE
        • A third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_spatial_rendering/README.chromium
        • A third_party/androidx/committed/libs/androidx_xr_scenecore_scenecore_spatial_rendering/androidx_xr_scenecore_scenecore_spatial_rendering.info
        Change size: L
        Delta: 155 files changed, 611 insertions(+), 231 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Gurmeet Kalra, +1 by Andrew Grieve, +1 by Peter Wen
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I0bfa0418ef27c385fc3c8e91a4ad7bccf034ec65
        Gerrit-Change-Number: 7507921
        Gerrit-PatchSet: 19
        Gerrit-Owner: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Gurmeet Kalra <gurm...@google.com>
        Gerrit-Reviewer: Haiyang Pan <hy...@google.com>
        Gerrit-Reviewer: Nick Mondello <mond...@google.com>
        Gerrit-Reviewer: Peter Wen <wn...@chromium.org>
        open
        diffy
        satisfied_requirement

        Nick Mondello (Gerrit)

        unread,
        Feb 3, 2026, 3:51:10 PM (11 days ago) Feb 3
        to Chromium LUCI CQ, Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org

        Nick Mondello has created a revert of this change

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: revert
        satisfied_requirement
        open
        diffy

        Nick Mondello (Gerrit)

        unread,
        Feb 3, 2026, 5:12:47 PM (11 days ago) Feb 3
        to Chromium LUCI CQ, Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
        satisfied_requirement
        open
        diffy

        Nick Mondello (Gerrit)

        unread,
        Feb 3, 2026, 5:23:24 PM (11 days ago) Feb 3
        to Chromium LUCI CQ, Jordan Brown, Peter Wen, Gurmeet Kalra, Code Review Nudger, Andrew Grieve, Haiyang Pan, AyeAye, feature-v...@chromium.org, feature-me...@chromium.org
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages