WebXR Layers: Implement forceMonoPresentation [chromium/src : main]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
Feb 4, 2026, 3:34:10 PM (10 days ago) Feb 4
to Yong Li (xWF), Brandon Jones, Evgenii Alekseev (xWF), Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Brandon Jones, Evgenii Alekseev (xWF) and Yong Li (xWF)

Alexander Cooper voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
  • Evgenii Alekseev (xWF)
  • Yong Li (xWF)
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I97737f5bb80eb1cbe9a15eb1aa9a8661e64de9b9
Gerrit-Change-Number: 7546597
Gerrit-PatchSet: 1
Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-Comment-Date: Wed, 04 Feb 2026 20:33:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Brandon Jones (Gerrit)

unread,
Feb 4, 2026, 3:56:23 PM (10 days ago) Feb 4
to Yong Li (xWF), Alexander Cooper, Evgenii Alekseev (xWF), Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
Attention needed from Evgenii Alekseev (xWF) and Yong Li (xWF)

Brandon Jones voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Evgenii Alekseev (xWF)
  • Yong Li (xWF)
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97737f5bb80eb1cbe9a15eb1aa9a8661e64de9b9
    Gerrit-Change-Number: 7546597
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 20:56:14 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    Feb 4, 2026, 5:00:00 PM (10 days ago) Feb 4
    to Yong Li (xWF), Chromium IPC Reviews, Giovanni Ortuno Urquidi, Brandon Jones, Alexander Cooper, Evgenii Alekseev (xWF), Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Evgenii Alekseev (xWF) and Giovanni Ortuno Urquidi

    Message from gwsq

    From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
    IPC: ort...@chromium.org

    📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

    IPC reviewer(s): ort...@chromium.org


    Reviewer source(s):
    ort...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Evgenii Alekseev (xWF)
    • Giovanni Ortuno Urquidi
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97737f5bb80eb1cbe9a15eb1aa9a8661e64de9b9
    Gerrit-Change-Number: 7546597
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 21:59:53 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Giovanni Ortuno Urquidi (Gerrit)

    unread,
    Feb 4, 2026, 5:08:42 PM (10 days ago) Feb 4
    to Yong Li (xWF), Giovanni Ortuno Urquidi, Chromium IPC Reviews, Brandon Jones, Alexander Cooper, Evgenii Alekseev (xWF), Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Evgenii Alekseev (xWF) and Yong Li (xWF)

    Giovanni Ortuno Urquidi voted and added 1 comment

    Votes added by Giovanni Ortuno Urquidi

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Giovanni Ortuno Urquidi . resolved

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Evgenii Alekseev (xWF)
    • Yong Li (xWF)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97737f5bb80eb1cbe9a15eb1aa9a8661e64de9b9
    Gerrit-Change-Number: 7546597
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Comment-Date: Wed, 04 Feb 2026 22:08:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yong Li (xWF) (Gerrit)

    unread,
    Feb 5, 2026, 9:02:25 AM (10 days ago) Feb 5
    to Giovanni Ortuno Urquidi, Chromium IPC Reviews, Brandon Jones, Alexander Cooper, Evgenii Alekseev (xWF), Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org
    Attention needed from Evgenii Alekseev (xWF)

    Yong Li (xWF) voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Evgenii Alekseev (xWF)
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97737f5bb80eb1cbe9a15eb1aa9a8661e64de9b9
    Gerrit-Change-Number: 7546597
    Gerrit-PatchSet: 1
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 14:02:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 5, 2026, 9:05:48 AM (10 days ago) Feb 5
    to Yong Li (xWF), Giovanni Ortuno Urquidi, Chromium IPC Reviews, Brandon Jones, Alexander Cooper, Evgenii Alekseev (xWF), chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org, ipc-securi...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WebXR Layers: Implement forceMonoPresentation
    Bug: 480928647
    Change-Id: I97737f5bb80eb1cbe9a15eb1aa9a8661e64de9b9
    Reviewed-by: Alexander Cooper <alco...@chromium.org>
    Reviewed-by: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Reviewed-by: Brandon Jones <baj...@chromium.org>
    Commit-Queue: Yong Li (xWF) <yyon...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1580050}
    Files:
    • M device/vr/openxr/openxr_composition_layer.cc
    • M device/vr/openxr/openxr_graphics_binding.cc
    • M device/vr/public/mojom/vr_service.mojom
    • M third_party/blink/renderer/modules/xr/xr_composition_layer.cc
    • M third_party/blink/renderer/modules/xr/xr_shaped_layer.cc
    • M third_party/blink/renderer/modules/xr/xr_webgl_layer.cc
    Change size: S
    Delta: 6 files changed, 16 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brandon Jones, +1 by Giovanni Ortuno Urquidi, +1 by Alexander Cooper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I97737f5bb80eb1cbe9a15eb1aa9a8661e64de9b9
    Gerrit-Change-Number: 7546597
    Gerrit-PatchSet: 2
    Gerrit-Owner: Yong Li (xWF) <yyon...@google.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Reviewer: Giovanni Ortuno Urquidi <ort...@chromium.org>
    Gerrit-Reviewer: Yong Li (xWF) <yyon...@google.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages