Add some missing includes of //base/types/strong_alias.h [chromium/src : main]

0 views
Skip to first unread message

David Sanders (Gerrit)

unread,
Feb 9, 2026, 2:52:18 AM (6 days ago) Feb 9
to Kentaro Hara, Ian Vollick, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, alexmo...@chromium.org, lize...@chromium.org, chromeos-gfx-...@google.com, csharris...@chromium.org, prerenderi...@chromium.org, lizeb...@chromium.org, gcasto+w...@chromium.org, osaul+aut...@google.com, loading-rev...@chromium.org, vasilii+watchlis...@chromium.org, siyua+aut...@chromium.org, siashah+au...@chromium.org, creis...@chromium.org, tburkar...@chromium.org, bmcquad...@chromium.org, speed-metr...@chromium.org, shgar+aut...@google.com, speed-metrics...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, feature-me...@chromium.org, bartek...@chromium.org, navigation...@chromium.org, media-cro...@chromium.org, cc-...@chromium.org, jbauma...@chromium.org, vinnypersky+...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, alexmt...@chromium.org, chikamu...@chromium.org, scheduler-...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from David Sanders

Message from David Sanders

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I74060a6433905ac45f076afdcd9bcbf1c28bb706
Gerrit-Change-Number: 7554478
Gerrit-PatchSet: 8
Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
Gerrit-CC: Ian Vollick <vol...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
Gerrit-Comment-Date: Mon, 09 Feb 2026 07:52:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Feb 9, 2026, 12:14:29 PM (6 days ago) Feb 9
to David Sanders, Lei Zhang, Kentaro Hara, Ian Vollick, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, alexmo...@chromium.org, lize...@chromium.org, chromeos-gfx-...@google.com, csharris...@chromium.org, prerenderi...@chromium.org, lizeb...@chromium.org, gcasto+w...@chromium.org, osaul+aut...@google.com, loading-rev...@chromium.org, vasilii+watchlis...@chromium.org, siyua+aut...@chromium.org, siashah+au...@chromium.org, creis...@chromium.org, tburkar...@chromium.org, bmcquad...@chromium.org, speed-metr...@chromium.org, shgar+aut...@google.com, speed-metrics...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, feature-me...@chromium.org, bartek...@chromium.org, navigation...@chromium.org, media-cro...@chromium.org, cc-...@chromium.org, jbauma...@chromium.org, vinnypersky+...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, alexmt...@chromium.org, chikamu...@chromium.org, scheduler-...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from David Sanders

Lei Zhang added 1 comment

File media/gpu/v4l2/v4l2_video_decoder_backend_stateless.h
Line 17, Patchset 8 (Latest):#include "base/types/strong_alias.h"
Lei Zhang . unresolved

Not needed here? StrongAlias only menrioned in a comment.

Open in Gerrit

Related details

Attention is currently required from:
  • David Sanders
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I74060a6433905ac45f076afdcd9bcbf1c28bb706
    Gerrit-Change-Number: 7554478
    Gerrit-PatchSet: 8
    Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
    Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-CC: Ian Vollick <vol...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
    Gerrit-Comment-Date: Mon, 09 Feb 2026 17:14:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Sanders (Gerrit)

    unread,
    Feb 9, 2026, 6:21:14 PM (5 days ago) Feb 9
    to Lei Zhang, Kentaro Hara, Ian Vollick, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, alexmo...@chromium.org, lize...@chromium.org, chromeos-gfx-...@google.com, csharris...@chromium.org, prerenderi...@chromium.org, lizeb...@chromium.org, gcasto+w...@chromium.org, osaul+aut...@google.com, loading-rev...@chromium.org, vasilii+watchlis...@chromium.org, siyua+aut...@chromium.org, siashah+au...@chromium.org, creis...@chromium.org, tburkar...@chromium.org, bmcquad...@chromium.org, speed-metr...@chromium.org, shgar+aut...@google.com, speed-metrics...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, feature-me...@chromium.org, bartek...@chromium.org, navigation...@chromium.org, media-cro...@chromium.org, cc-...@chromium.org, jbauma...@chromium.org, vinnypersky+...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, alexmt...@chromium.org, chikamu...@chromium.org, scheduler-...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
    Attention needed from Lei Zhang

    David Sanders added 1 comment

    File media/gpu/v4l2/v4l2_video_decoder_backend_stateless.h
    Line 17, Patchset 8:#include "base/types/strong_alias.h"
    Lei Zhang . resolved

    Not needed here? StrongAlias only menrioned in a comment.

    David Sanders

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Lei Zhang
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I74060a6433905ac45f076afdcd9bcbf1c28bb706
      Gerrit-Change-Number: 7554478
      Gerrit-PatchSet: 9
      Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
      Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-CC: Ian Vollick <vol...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-Attention: Lei Zhang <the...@chromium.org>
      Gerrit-Comment-Date: Mon, 09 Feb 2026 23:21:05 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Lei Zhang (Gerrit)

      unread,
      Feb 9, 2026, 7:11:26 PM (5 days ago) Feb 9
      to David Sanders, Lei Zhang, Kentaro Hara, Ian Vollick, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, alexmo...@chromium.org, lize...@chromium.org, chromeos-gfx-...@google.com, csharris...@chromium.org, prerenderi...@chromium.org, lizeb...@chromium.org, gcasto+w...@chromium.org, osaul+aut...@google.com, loading-rev...@chromium.org, vasilii+watchlis...@chromium.org, siyua+aut...@chromium.org, siashah+au...@chromium.org, creis...@chromium.org, tburkar...@chromium.org, bmcquad...@chromium.org, speed-metr...@chromium.org, shgar+aut...@google.com, speed-metrics...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, feature-me...@chromium.org, bartek...@chromium.org, navigation...@chromium.org, media-cro...@chromium.org, cc-...@chromium.org, jbauma...@chromium.org, vinnypersky+...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, alexmt...@chromium.org, chikamu...@chromium.org, scheduler-...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
      Attention needed from David Sanders

      Lei Zhang voted and added 1 comment

      Votes added by Lei Zhang

      Code-Review+1
      Commit-Queue+2
      Owners-Override+1

      1 comment

      File media/gpu/v4l2/v4l2_video_decoder_backend_stateless.h
      Line 17, Patchset 8:#include "base/types/strong_alias.h"
      Lei Zhang . resolved

      Not needed here? StrongAlias only menrioned in a comment.

      David Sanders

      Done

      Lei Zhang

      Also, please excuse the typo.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • David Sanders
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I74060a6433905ac45f076afdcd9bcbf1c28bb706
      Gerrit-Change-Number: 7554478
      Gerrit-PatchSet: 9
      Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
      Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-CC: Ian Vollick <vol...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-Attention: David Sanders <dsand...@ucsbalum.com>
      Gerrit-Comment-Date: Tue, 10 Feb 2026 00:11:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
      Comment-In-Reply-To: David Sanders <dsand...@ucsbalum.com>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Feb 9, 2026, 9:29:41 PM (5 days ago) Feb 9
      to David Sanders, Lei Zhang, Kentaro Hara, Ian Vollick, AyeAye, wfh+...@chromium.org, alexmo...@chromium.org, lize...@chromium.org, chromeos-gfx-...@google.com, csharris...@chromium.org, prerenderi...@chromium.org, lizeb...@chromium.org, gcasto+w...@chromium.org, osaul+aut...@google.com, loading-rev...@chromium.org, vasilii+watchlis...@chromium.org, siyua+aut...@chromium.org, siashah+au...@chromium.org, creis...@chromium.org, tburkar...@chromium.org, bmcquad...@chromium.org, speed-metr...@chromium.org, shgar+aut...@google.com, speed-metrics...@chromium.org, feature-v...@chromium.org, gavin...@chromium.org, feature-me...@chromium.org, bartek...@chromium.org, navigation...@chromium.org, media-cro...@chromium.org, cc-...@chromium.org, jbauma...@chromium.org, vinnypersky+...@google.com, armalhotra+a...@google.com, browser-comp...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, alexmt...@chromium.org, chikamu...@chromium.org, scheduler-...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Add some missing includes of //base/types/strong_alias.h
      Bug: 40216326
      Change-Id: I74060a6433905ac45f076afdcd9bcbf1c28bb706
      Commit-Queue: David Sanders <dsand...@ucsbalum.com>
      Owners-Override: Lei Zhang <the...@chromium.org>
      Commit-Queue: Lei Zhang <the...@chromium.org>
      Reviewed-by: Lei Zhang <the...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1582213}
      Files:
      • M chrome/browser/navigation_predictor/navigation_predictor.h
      • M chrome/browser/ui/autofill/autofill_popup_controller.h
      • M chrome/browser/ui/views/profiles/sync_confirmation_ui_browsertest.cc
      • M chrome/browser/ui/webui/intro/intro_ui.h
      • M components/autofill/content/renderer/test_utils.cc
      • M components/autofill/core/browser/foundations/form_forest_unittest.cc
      • M components/autofill/core/browser/metrics/payments/card_metadata_metrics.h
      • M components/autofill/core/browser/payments/multiple_request_payments_network_interface.h
      • M components/autofill/core/browser/payments/multiple_request_payments_network_interface_base.h
      • M components/autofill/core/browser/payments/payments_window_manager.h
      • M components/autofill/core/common/autofill_util.h
      • M components/desks_storage/core/local_desk_data_manager_unittest.cc
      • M components/facilitated_payments/core/browser/network_api/facilitated_payments_network_interface.h
      • M components/facilitated_payments/core/browser/pix_account_linking_manager_unittest.cc
      • M components/page_load_metrics/browser/page_load_tracker.h
      • M components/password_manager/core/browser/affiliation/affiliated_match_helper.cc
      • M components/password_manager/core/browser/password_store/fake_password_store_backend.h
      • M components/password_manager/core/browser/password_store/login_database.h
      • M components/password_manager/core/browser/password_store/password_store_change.h
      • M components/password_manager/core/browser/password_store/password_store_interface.h
      • M components/password_manager/core/browser/ui/credential_ui_entry.h
      • M components/password_manager/core/browser/ui/passwords_grouper.h
      • M components/password_manager/core/browser/ui/saved_passwords_presenter.cc
      • M components/password_manager/core/browser/votes_uploader.h
      • M components/webauthn/core/browser/passkey_model.h
      • M content/browser/preloading/prefetch/prefetch_service.h
      • M content/browser/preloading/prerender/prerender_host_unittest.cc
      • M content/browser/private_aggregation/private_aggregation_manager_impl.h
      • M content/browser/renderer_host/compositor_impl_android.h
      • M content/browser/renderer_host/navigation_transitions/navigation_transition_data.h
      • M device/vr/openxr/msft/openxr_scene_object_msft.h
      • M device/vr/openxr/msft/openxr_scene_plane_msft.h
      • M ipc/param_traits_utils.h
      • M ipc/param_traits_utils_unittest.cc
      • M ui/compositor/compositor.h
      Change size: S
      Delta: 35 files changed, 35 insertions(+), 0 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Lei Zhang
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I74060a6433905ac45f076afdcd9bcbf1c28bb706
      Gerrit-Change-Number: 7554478
      Gerrit-PatchSet: 10
      Gerrit-Owner: David Sanders <dsand...@ucsbalum.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Sanders <dsand...@ucsbalum.com>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages