WebXR: Fix viewport height calculation in GetViewportForLayer [chromium/src : main]

0 views
Skip to first unread message

Alexander Cooper (Gerrit)

unread,
Dec 12, 2025, 12:16:19 PM (4 days ago) Dec 12
to zhixin tu, Evgenii Alekseev (xWF), Ho Cheung, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Evgenii Alekseev (xWF) and zhixin tu

Alexander Cooper voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Evgenii Alekseev (xWF)
  • zhixin tu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29840be73ff710c9e5326802b56d88719bd61efe
Gerrit-Change-Number: 7254815
Gerrit-PatchSet: 1
Gerrit-Owner: zhixin tu <tuzhi...@gmail.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-CC: Ho Cheung <hoch...@chromium.org>
Gerrit-Attention: zhixin tu <tuzhi...@gmail.com>
Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-Comment-Date: Fri, 12 Dec 2025 17:16:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alexander Cooper (Gerrit)

unread,
Dec 12, 2025, 12:16:51 PM (4 days ago) Dec 12
to zhixin tu, Brandon Jones, Evgenii Alekseev (xWF), Ho Cheung, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Brandon Jones, Evgenii Alekseev (xWF) and zhixin tu

Alexander Cooper added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Alexander Cooper . resolved

I don't believe ealekseev@ is a committer, adding bajones@ as a second reviewer.

Open in Gerrit

Related details

Attention is currently required from:
  • Brandon Jones
  • Evgenii Alekseev (xWF)
  • zhixin tu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I29840be73ff710c9e5326802b56d88719bd61efe
Gerrit-Change-Number: 7254815
Gerrit-PatchSet: 1
Gerrit-Owner: zhixin tu <tuzhi...@gmail.com>
Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-CC: Ho Cheung <hoch...@chromium.org>
Gerrit-Attention: zhixin tu <tuzhi...@gmail.com>
Gerrit-Attention: Brandon Jones <baj...@chromium.org>
Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
Gerrit-Comment-Date: Fri, 12 Dec 2025 17:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Brandon Jones (Gerrit)

unread,
Dec 12, 2025, 12:33:49 PM (4 days ago) Dec 12
to zhixin tu, Alexander Cooper, Evgenii Alekseev (xWF), Ho Cheung, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
Attention needed from Evgenii Alekseev (xWF) and zhixin tu

Brandon Jones voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Evgenii Alekseev (xWF)
  • zhixin tu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I29840be73ff710c9e5326802b56d88719bd61efe
    Gerrit-Change-Number: 7254815
    Gerrit-PatchSet: 1
    Gerrit-Owner: zhixin tu <tuzhi...@gmail.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-CC: Ho Cheung <hoch...@chromium.org>
    Gerrit-Attention: zhixin tu <tuzhi...@gmail.com>
    Gerrit-Attention: Evgenii Alekseev (xWF) <eale...@google.com>
    Gerrit-Comment-Date: Fri, 12 Dec 2025 17:33:34 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ho Cheung (Gerrit)

    unread,
    Dec 12, 2025, 6:45:44 PM (4 days ago) Dec 12
    to zhixin tu, Brandon Jones, Alexander Cooper, Evgenii Alekseev (xWF), Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org
    Attention needed from Evgenii Alekseev (xWF) and zhixin tu

    Ho Cheung voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Fri, 12 Dec 2025 23:45:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 12, 2025, 7:03:25 PM (4 days ago) Dec 12
    to zhixin tu, Brandon Jones, Alexander Cooper, Evgenii Alekseev (xWF), Ho Cheung, chromium...@chromium.org, blink-...@chromium.org, feature-v...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WebXR: Fix viewport height calculation in GetViewportForLayer

    Use GetVerticalViewCount() to correctly compute the viewport height in
    GetViewportForLayer.
    Bug: 468035615
    Change-Id: I29840be73ff710c9e5326802b56d88719bd61efe
    Reviewed-by: Alexander Cooper <alco...@chromium.org>
    Commit-Queue: Ho Cheung <hoch...@chromium.org>
    Reviewed-by: Brandon Jones <baj...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1558337}
    Files:
    • M AUTHORS
    • M third_party/blink/renderer/modules/xr/xr_webgl_binding.cc
    Change size: XS
    Delta: 2 files changed, 2 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Brandon Jones, +1 by Alexander Cooper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I29840be73ff710c9e5326802b56d88719bd61efe
    Gerrit-Change-Number: 7254815
    Gerrit-PatchSet: 2
    Gerrit-Owner: zhixin tu <tuzhi...@gmail.com>
    Gerrit-Reviewer: Alexander Cooper <alco...@chromium.org>
    Gerrit-Reviewer: Brandon Jones <baj...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Evgenii Alekseev (xWF) <eale...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages