[xr] Move GpuFence creation into ClientSharedImage for OpenXR [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
May 26, 2026, 11:19:55 AM (7 days ago) May 26
to Mingjing Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Mingjing Zhang
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Vasiliy Telezhnikov . resolved
Sorry for the delay, lgtm, thanks.
Related details
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexander Cooper (Gerrit)
May 26, 2026, 12:49:49 PM (7 days ago) May 26
to Mingjing Zhang, Vasiliy Telezhnikov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Attention needed from Mingjing Zhang
Alexander Cooper voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
May 28, 2026, 11:41:10 AM (5 days ago) May 28
to Alexander Cooper, Vasiliy Telezhnikov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Mingjing Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 28, 2026, 1:49:48 PM (5 days ago) May 28
to Mingjing Zhang, Alexander Cooper, Vasiliy Telezhnikov, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[xr] Move GpuFence creation into ClientSharedImage for OpenXR
As part of the effort of moving SyncToken management in
ClientSharedImage, this CL moves the GpuFence creation in OpenXR into
ClientSharedImage::CreateGpuFenceForSyncTokens(). To support this
change, we also added a GetSharedImages() member in
OpenXrGraphicsBinding to retrieve ClientSharedImages for layers, and
changed the GpuFence destruction timing to match the model used by
Cardboard in ClientSharedImage::CreateGpuFenceForSyncTokens().
Change-Id: Id9891c9a343b40df4ed687d7bfe34df10c81598c
Commit-Queue: Mingjing Zhang <mjz...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Reviewed-by: Alexander Cooper <alco...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1637809}
Files:
- M device/vr/openxr/openxr_graphics_binding.cc
- M device/vr/openxr/openxr_graphics_binding.h
- M device/vr/openxr/openxr_render_loop.cc
- M device/vr/openxr/openxr_render_loop.h
Change size: M
Delta: 4 files changed, 42 insertions(+), 18 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov, +1 by Alexander Cooper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tommy Nyquist (Gerrit)
May 28, 2026, 7:43:58 PM (5 days ago) May 28
to Mingjing Zhang, Chromium LUCI CQ, Alexander Cooper, Vasiliy Telezhnikov, android-bu...@system.gserviceaccount.com, feature-v...@chromium.org
Tommy Nyquist has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages